From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org, lenb@kernel.org,
dsmythies@telus.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org, jic23@cam.ac.uk,
keescook@chromium.org
Subject: Re: [PATCH] lib: Extend kstrtobool() to accept "true"/"false"
Date: Tue, 30 Jun 2020 19:38:23 -0700 [thread overview]
Message-ID: <20200630193823.62573c0142ddda1f2bf92cf3@linux-foundation.org> (raw)
In-Reply-To: <20200629120938.GC1319@bug>
On Mon, 29 Jun 2020 14:09:38 +0200 Pavel Machek <pavel@ucw.cz> wrote:
> > Extend the strings recognised by kstrtobool() to cover:
> >
> > - 1/0
> > - y/n
> > - yes/no (new)
> > - t/f (new)
> > - true/false (new)
> > - on/off
>
> Is it good idea to add more values there? It is easy to do, but... we don't want
> people to use this by hand, and ideally everyone would just use 1/0...
>
> I also see potential for confusion... as in echo off > enable_off_mode (ok, this is
> with existing code, but...)
>
> Plus, if programs learn to do "echo true > ..." they will stop working on older kernels.
I'm inclined to agree with this, It is indeed an invitation to write
non-back-compatible userspace and it simply makes the kernel interface
more complex.
prev parent reply other threads:[~2020-07-01 2:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 22:49 [UPDATE][PATCH v3 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency Srinivas Pandruvada
2020-06-26 8:49 ` Borislav Petkov
2020-06-26 9:12 ` Srinivas Pandruvada
2020-06-26 10:22 ` Peter Zijlstra
2020-06-26 10:44 ` [PATCH] lib: Extend kstrtobool() to accept "true"/"false" Peter Zijlstra
2020-06-26 11:10 ` Srinivas Pandruvada
2020-06-26 15:49 ` Rafael J. Wysocki
2020-06-26 15:51 ` Kees Cook
2020-06-29 12:09 ` Pavel Machek
2020-07-01 2:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630193823.62573c0142ddda1f2bf92cf3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dsmythies@telus.net \
--cc=hpa@zytor.com \
--cc=jic23@cam.ac.uk \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).