From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4909BC433DF for ; Mon, 6 Jul 2020 13:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31F7720702 for ; Mon, 6 Jul 2020 13:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729218AbgGFN0g (ORCPT ); Mon, 6 Jul 2020 09:26:36 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60770 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729209AbgGFN0f (ORCPT ); Mon, 6 Jul 2020 09:26:35 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 3769E3ED197AB1A85962; Mon, 6 Jul 2020 21:26:32 +0800 (CST) Received: from kernelci-master.huawei.com (10.175.101.6) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 6 Jul 2020 21:26:23 +0800 From: Wei Yongjun To: Hulk Robot , Zhang Rui , "Daniel Lezcano" CC: Wei Yongjun , Subject: [PATCH -next] thermal: core: Make thermal_cdev_set_cur_state() static Date: Mon, 6 Jul 2020 21:36:33 +0800 Message-ID: <20200706133633.79511-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org sparse report build warning as follows: drivers/thermal/thermal_helpers.c:178:6: warning: symbol 'thermal_cdev_set_cur_state' was not declared. Should it be static? Since function thermal_cdev_set_cur_state() is not used out of thermal_helpers.c, so marks it static. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/thermal/thermal_helpers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c index 53dd92ccfd19..00a3df6a2d62 100644 --- a/drivers/thermal/thermal_helpers.c +++ b/drivers/thermal/thermal_helpers.c @@ -175,7 +175,8 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz) mutex_unlock(&tz->lock); } -void thermal_cdev_set_cur_state(struct thermal_cooling_device *cdev, int target) +static void thermal_cdev_set_cur_state(struct thermal_cooling_device *cdev, + int target) { if (cdev->ops->set_cur_state(cdev, target)) return;