From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Amit Kucheria <amit.kucheria@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064 bindings
Date: Fri, 10 Jul 2020 10:26:57 -0600 [thread overview]
Message-ID: <20200710162657.GB2743639@bogus> (raw)
In-Reply-To: <20200709215136.28044-4-ansuelsmth@gmail.com>
On Thu, Jul 09, 2020 at 11:51:33PM +0200, Ansuel Smith wrote:
> Document the use of regmap phandle for ipq8064 SoCs
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../bindings/thermal/qcom-tsens.yaml | 51 ++++++++++++++++---
> 1 file changed, 44 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d7be931b42d2..5ceb5d720e16 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -24,6 +24,7 @@ properties:
> - enum:
> - qcom,msm8916-tsens
> - qcom,msm8974-tsens
> + - qcom,ipq8064-tsens
> - const: qcom,tsens-v0_1
>
> - description: v1 of TSENS
> @@ -47,6 +48,11 @@ properties:
> - description: TM registers
> - description: SROT registers
>
> + regmap:
> + description:
> + Phandle to the gcc. On ipq8064 SoCs gcc and tsense share the same regs.
> + $ref: /schemas/types.yaml#/definitions/phandle
Can't you make this a child of the gcc and drop this property?
> +
> interrupts:
> minItems: 1
> items:
> @@ -111,17 +117,48 @@ allOf:
> interrupt-names:
> minItems: 2
>
> -required:
> - - compatible
> - - reg
> - - "#qcom,sensors"
> - - interrupts
> - - interrupt-names
> - - "#thermal-sensor-cells"
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,ipq8064-tsens
> + then:
> + required:
> + - compatible
> + - regmap
> + - "#qcom,sensors"
> + - interrupts
> + - interrupt-names
> + - "#thermal-sensor-cells"
> +
> + else:
> + required:
> + - compatible
> + - reg
> + - "#qcom,sensors"
> + - interrupts
> + - interrupt-names
> + - "#thermal-sensor-cells"
Keep all the common required properties and just put reg/regmap in the
if/then if this ends up staying.
Rob
next prev parent reply other threads:[~2020-07-10 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 21:51 [PATCH 0/6] Add support for ipq8064 tsens Ansuel Smith
2020-07-09 21:51 ` [PATCH 1/6] drivers: thermal: tsens: load regmap from phandle for 8960 Ansuel Smith
2020-07-09 21:51 ` [PATCH 2/6] drivers: thermal: tsens: add ipq8064 support Ansuel Smith
2020-07-09 21:51 ` [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064 bindings Ansuel Smith
2020-07-10 16:24 ` Rob Herring
2020-07-10 16:26 ` Rob Herring [this message]
2020-07-10 20:07 ` R: " ansuelsmth
2020-07-14 14:26 ` Rob Herring
2020-07-09 21:51 ` [PATCH 4/6] drivers: thermal: tsens: add interrupt support for 9860 driver Ansuel Smith
2020-07-09 21:51 ` [PATCH 5/6] drivers: thermal: tsens: add support for custom set_trip function Ansuel Smith
2020-07-09 21:51 ` [PATCH 6/6] drivers: thermal: tsens: add set_trip support for 8960 Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710162657.GB2743639@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).