From: Rob Herring <robh@kernel.org>
To: "Daniel González Cabanelas" <dgcbueu@gmail.com>
Cc: linux-pm@vger.kernel.org, sre@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: power: reset: add yaml bindings for LinkStation power off
Date: Mon, 13 Jul 2020 12:36:35 -0600 [thread overview]
Message-ID: <20200713183635.GA503416@bogus> (raw)
In-Reply-To: <2774047.62mrzoXREp@tool>
On Sat, Jun 13, 2020 at 12:26:56PM +0200, Daniel González Cabanelas wrote:
> Add Linkstation poweroff bindings documentation.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
> Changes in v3:
> - "phy-handle,intn" property deleted. Now autodetection used.
> - Cosmetic changes
> Changes in v2:
> - Changed the required properties and description to adjust to the new
> driver now enabling the WoL feature on the device.
>
> .../power/reset/linkstation-poweroff.yaml | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
> new file mode 100644
> index 0000000000..8845333ca4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
As I said before:
GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/linkstation-poweroff.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Buffalo Linkstation poweroff Binding
> +
> +maintainers:
> + - Daniel González Cabanelas <dgcbueu@gmail.com>
> +
> +description: |
> + Some Buffalo LinkStations (ARM MVEBU boards) use an output pin at the ethernet
> + PHY (LED2/INTn) to inform the board if the power off operation must be performed
> + at restart time. This pin is ORed with the power switch and allows the WOL
> + function to be also used.
> +
> + When the power-off handler is called, the ethernet PHY INTn ouptut is set to
> + LOW state. If the restart command is executed then the PHY INTn output is
> + forced to HIGH state.
> +
> +properties:
> + compatible:
> + const: linkstation,power-off
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + poweroff {
> + compatible = "linkstation,power-off";
> + };
This is not what I was suggesting in the last version. You don't need a
binding for this. Use the root node compatible string.
Your driver initcall needs to check the root compatible and create a
platform device if it matches.
Rob
next prev parent reply other threads:[~2020-07-13 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 10:26 [PATCH v3 2/2] dt-bindings: power: reset: add yaml bindings for LinkStation power off Daniel González Cabanelas
2020-07-13 18:36 ` Rob Herring [this message]
2020-07-13 19:54 ` Daniel González Cabanelas
2020-07-13 20:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713183635.GA503416@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dgcbueu@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).