linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Lee <frank@allwinnertech.com>
Cc: mripard@kernel.org, wens@csie.org, mturquette@baylibre.com,
	sboyd@kernel.org, gregory.clement@bootlin.com,
	tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org,
	srinivas.kandagatla@linaro.org, linus.walleij@linaro.org,
	anarsoul@gmail.com, tiny.windzz@gmail.com, rui.zhang@intel.com,
	daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
	lee.jones@linaro.org, p.zabel@pengutronix.de,
	clabbe@baylibre.com, icenowy@aosc.io, megous@megous.com,
	stefan@olimex.com, bage@linutronix.de,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-pm@vger.kernel.org, huangshuosheng@allwinnertech.com,
	liyong@allwinnertech.com
Subject: Re: [PATCH v3 03/16] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings
Date: Mon, 13 Jul 2020 17:01:29 -0600	[thread overview]
Message-ID: <20200713230129.GA875173@bogus> (raw)
In-Reply-To: <20200708071942.22595-4-frank@allwinnertech.com>

On Wed, Jul 08, 2020 at 03:19:29PM +0800, Frank Lee wrote:
> Add device tree binding Documentation details for A100 pinctrl driver,
> whic has an r pin controller and a pin controller with more irq lines.

s/whic/which/

'an r pin controller'?

> 
> Signed-off-by: Frank Lee <frank@allwinnertech.com>
> ---
>  .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml       | 74 +++++++++++++---------
>  1 file changed, 44 insertions(+), 30 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index bfefd09..226aba0 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -48,6 +48,8 @@ properties:
>        - allwinner,sun9i-a80-r-pinctrl
>        - allwinner,sun50i-a64-pinctrl
>        - allwinner,sun50i-a64-r-pinctrl
> +      - allwinner,sun50i-a100-pinctrl
> +      - allwinner,sun50i-a100-r-pinctrl
>        - allwinner,sun50i-h5-pinctrl
>        - allwinner,sun50i-h6-pinctrl
>        - allwinner,sun50i-h6-r-pinctrl
> @@ -59,7 +61,7 @@ properties:
>  
>    interrupts:
>      minItems: 1
> -    maxItems: 5
> +    maxItems: 7
>      description:
>        One interrupt per external interrupt bank supported on the
>        controller, sorted by bank number ascending order.
> @@ -144,75 +146,87 @@ allOf:
>    # FIXME: We should have the pin bank supplies here, but not a lot of
>    # boards are defining it at the moment so it would generate a lot of
>    # warnings.
> -
>    - if:
>        properties:
>          compatible:
>            enum:
> -            - allwinner,sun9i-a80-pinctrl
> +            - allwinner,sun50i-a100-pinctrl
>  
>      then:
>        properties:
>          interrupts:
> -          minItems: 5
> -          maxItems: 5
> +          minItems: 7
> +          maxItems: 7
>  
>      else:
>        if:

This diff is hard to follow. Rather than a continual nesting of 'else' 
clauses, just make each 'if' a new entry under 'allOf' and get rid of 
the else. Perhaps do that in a separate patch first, then this change 
will be easier to review.

>          properties:
>            compatible:
>              enum:
> -              - allwinner,sun6i-a31-pinctrl
> -              - allwinner,sun6i-a31s-pinctrl
> -              - allwinner,sun50i-h6-pinctrl
> +              - allwinner,sun9i-a80-pinctrl
>  
>        then:
>          properties:
>            interrupts:
> -            minItems: 4
> -            maxItems: 4
> +            minItems: 5
> +            maxItems: 5
>  
>        else:
>          if:
>            properties:
>              compatible:
>                enum:
> -                - allwinner,sun8i-a23-pinctrl
> -                - allwinner,sun8i-a83t-pinctrl
> -                - allwinner,sun50i-a64-pinctrl
> -                - allwinner,sun50i-h5-pinctrl
> -                - allwinner,suniv-f1c100s-pinctrl
> +                - allwinner,sun6i-a31-pinctrl
> +                - allwinner,sun6i-a31s-pinctrl
> +                - allwinner,sun50i-h6-pinctrl
>  
>          then:
>            properties:
>              interrupts:
> -              minItems: 3
> -              maxItems: 3
> +              minItems: 4
> +              maxItems: 4
>  
>          else:
>            if:
>              properties:
>                compatible:
>                  enum:
> -                  - allwinner,sun6i-a31-r-pinctrl
> -                  - allwinner,sun8i-a33-pinctrl
> -                  - allwinner,sun8i-h3-pinctrl
> -                  - allwinner,sun8i-v3-pinctrl
> -                  - allwinner,sun8i-v3s-pinctrl
> -                  - allwinner,sun9i-a80-r-pinctrl
> -                  - allwinner,sun50i-h6-r-pinctrl
> +                  - allwinner,sun8i-a23-pinctrl
> +                  - allwinner,sun8i-a83t-pinctrl
> +                  - allwinner,sun50i-a64-pinctrl
> +                  - allwinner,sun50i-h5-pinctrl
> +                  - allwinner,suniv-f1c100s-pinctrl
>  
>            then:
>              properties:
>                interrupts:
> -                minItems: 2
> -                maxItems: 2
> +                minItems: 3
> +                maxItems: 3
>  
>            else:
> -            properties:
> -              interrupts:
> -                minItems: 1
> -                maxItems: 1
> +            if:
> +              properties:
> +                compatible:
> +                  enum:
> +                    - allwinner,sun6i-a31-r-pinctrl
> +                    - allwinner,sun8i-a33-pinctrl
> +                    - allwinner,sun8i-h3-pinctrl
> +                    - allwinner,sun8i-v3-pinctrl
> +                    - allwinner,sun8i-v3s-pinctrl
> +                    - allwinner,sun9i-a80-r-pinctrl
> +                    - allwinner,sun50i-h6-r-pinctrl
> +
> +            then:
> +              properties:
> +                interrupts:
> +                  minItems: 2
> +                  maxItems: 2
> +
> +            else:
> +              properties:
> +                interrupts:
> +                  minItems: 1
> +                  maxItems: 1
>  
>  additionalProperties: false
>  
> -- 
> 1.9.1
> 

  reply	other threads:[~2020-07-13 23:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  7:19 [PATCH v3 00/16] Allwinner A100 Initial support Frank Lee
2020-07-08  7:19 ` [PATCH v3 01/16] dt-bindings: clk: sunxi-ccu: add compatible string for A100 CCU and R-CCU Frank Lee
2020-07-13 22:54   ` Rob Herring
2020-07-13 23:33     ` Rob Herring
2020-07-08  7:19 ` [PATCH v3 02/16] clk: sunxi-ng: add support for the Allwinner A100 CCU Frank Lee
2020-07-08  7:19 ` [PATCH v3 03/16] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings Frank Lee
2020-07-13 23:01   ` Rob Herring [this message]
2020-07-08  7:19 ` [PATCH v3 04/16] dt-bindings: pinctrl: sunxi: make gpio banks supplies required Frank Lee
2020-07-09 16:52   ` Rob Herring
2020-07-09 16:54   ` Rob Herring
2020-07-09 17:17   ` Ondřej Jirman
2020-07-10 12:37     ` Maxime Ripard
2020-07-13  2:32       ` Frank Lee
2020-07-08  7:19 ` [PATCH v3 05/16] pinctrl: sunxi: add support for the Allwinner A100 pin controller Frank Lee
2020-07-08  7:19 ` [PATCH v3 06/16] dt-bindings: nvmem: SID: add binding for A100's SID controller Frank Lee
2020-07-09 16:54   ` Rob Herring
2020-07-08  7:19 ` [PATCH v3 07/16] dt-bindings: thermal: sun8i: Add binding for A100's THS controller Frank Lee
2020-07-13 23:02   ` Rob Herring
2020-07-08  7:19 ` [PATCH v3 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate Frank Lee
2020-07-08  7:19 ` [PATCH v3 09/16] thermal: sun8i: Add A100's THS controller support Frank Lee
2020-07-08  7:19 ` [PATCH v3 10/16] mfd: axp20x: Allow the AXP803 to be probed by I2C Frank Lee
2020-07-16 15:10   ` Lee Jones
2020-07-08  7:45 ` [PATCH v3 00/16] Allwinner A100 Initial support Corentin Labbe
2020-07-13  2:41   ` Frank Lee
2020-07-10 14:28 ` Maxime Ripard
2020-07-13  2:39   ` Frank Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713230129.GA875173@bogus \
    --to=robh@kernel.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=anarsoul@gmail.com \
    --cc=bage@linutronix.de \
    --cc=clabbe@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frank@allwinnertech.com \
    --cc=gregory.clement@bootlin.com \
    --cc=huangshuosheng@allwinnertech.com \
    --cc=icenowy@aosc.io \
    --cc=jason@lakedaemon.net \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=liyong@allwinnertech.com \
    --cc=maz@kernel.org \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=stefan@olimex.com \
    --cc=tglx@linutronix.de \
    --cc=tiny.windzz@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).