From: Rob Herring <robh@kernel.org>
To: Iskren Chernev <iskren.chernev@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Jonathan Bakker <xc-racer2@live.ca>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v3 2/6] dt-bindings: power: supply: Extend max17040 compatibility
Date: Tue, 14 Jul 2020 15:08:16 -0600 [thread overview]
Message-ID: <20200714210816.GA2918005@bogus> (raw)
In-Reply-To: <c4dc5045-48ee-a27b-98a8-22fdb37d6ba9@gmail.com>
On Tue, Jul 14, 2020 at 11:49:44AM +0300, Iskren Chernev wrote:
>
> On 7/13/20 10:03 PM, Rob Herring wrote:
> > On Wed, Jun 24, 2020 at 06:56:29PM +0300, Iskren Chernev wrote:
> >> Maxim max17040 is a fuel gauge from a larger family utilising the Model
> >> Gauge technology. Document all different compatible strings that the
> >> max17040 driver recognizes.
> >>
> >> Some devices in the wild report double the capacity. The
> >> maxim,double-soc (from State-Of-Charge) property fixes that.
> >>
> >> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> >> ---
> >> .../bindings/power/supply/max17040_battery.txt | 15 ++++++++++++++-
> >> 1 file changed, 14 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> index 4e0186b8380fa..554bce82a08e6 100644
> >> --- a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> @@ -2,7 +2,9 @@ max17040_battery
> >> ~~~~~~~~~~~~~~~~
> >>
> >> Required properties :
> >> - - compatible : "maxim,max17040" or "maxim,max77836-battery"
> >> + - compatible : "maxim,max17040", "maxim,max17041", "maxim,max17043",
> >> + "maxim,max17044", "maxim,max17048", "maxim,max17049",
> >> + "maxim,max17058", "maxim,max17059" or "maxim,max77836-battery"
> >> - reg: i2c slave address
> >>
> >> Optional properties :
> >> @@ -11,6 +13,10 @@ Optional properties :
> >> generated. Can be configured from 1 up to 32
> >> (%). If skipped the power up default value of
> >> 4 (%) will be used.
> >> +- maxim,double-soc : Certain devices return double the capacity.
> >> + Specify this boolean property to divide the
> >> + reported value in 2 and thus normalize it.
> >> + SOC == State of Charge == Capacity.
> >
> > This can't be implied by the compatible string?
> >
>
> >From what I can tell - no. Here are multiple examples of downstream code:
Okay,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-07-14 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 15:56 [PATCH v3 0/6] power: supply: max17040 support compatible devices Iskren Chernev
2020-06-24 15:56 ` [PATCH v3 1/6] power: supply: max17040: Use regmap i2c Iskren Chernev
2020-08-28 17:44 ` Sebastian Reichel
2020-06-24 15:56 ` [PATCH v3 2/6] dt-bindings: power: supply: Extend max17040 compatibility Iskren Chernev
2020-07-13 19:03 ` Rob Herring
2020-07-14 8:49 ` Iskren Chernev
2020-07-14 21:08 ` Rob Herring [this message]
2020-06-24 15:56 ` [PATCH v3 3/6] power: supply: max17040: Support compatible devices Iskren Chernev
2020-06-24 15:56 ` [PATCH v3 4/6] dt-bindings: power: supply: max17040: Add maxim,rcomp Iskren Chernev
2020-07-13 19:04 ` Rob Herring
2020-06-24 15:56 ` [PATCH v3 5/6] power: supply: max17040: Support setting rcomp Iskren Chernev
2020-06-24 15:56 ` [PATCH v3 6/6] power: supply: max17040: Support soc alert Iskren Chernev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714210816.GA2918005@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=vladimir.barinov@cogentembedded.com \
--cc=xc-racer2@live.ca \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).