From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEBCC433E1 for ; Wed, 15 Jul 2020 03:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA5152070E for ; Wed, 15 Jul 2020 03:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T6AbBGKL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbgGODHL (ORCPT ); Tue, 14 Jul 2020 23:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbgGODHK (ORCPT ); Tue, 14 Jul 2020 23:07:10 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70BA4C061755 for ; Tue, 14 Jul 2020 20:07:10 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id k71so1736678pje.0 for ; Tue, 14 Jul 2020 20:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0035V8bnG3whIAu8f7LLUznLFIPtedBFd2Vvyt7nBVE=; b=T6AbBGKLFGiO0rMZSPzPGLvnhapccenwdvNWp3pzTj2roNEx6srIAWKTBvrEsL/hBA IZkPg8mUeuKB1PT4pOTI4RjF5htA4bxX6dyCndlvlQe4G3ODxC2ZOvhPWx+05HCv9rDZ va/MRhxP+3uW57aWLqjD3o2VwG34nmWoW4VDWWaVLnO2XyVSQ6mxJiYqPIYyBouwaDte gFQTXx4zqagvxCcyT8kLl6jPMhLAi7mmed0AH0wF+KddDCiP8oCCatuOk/jTqvTazoK2 EjDKeUpPihFzsLsxEaEe6MTwtmRnr+fQ9s2ka4YKgYXJJjwdcjX1AxKMspjlcbaQ/Gx8 Vajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=0035V8bnG3whIAu8f7LLUznLFIPtedBFd2Vvyt7nBVE=; b=ITHzpqXwU4YyzQgn/J5aLjXDGFJNIv5CppW3qq1KINcIcMGltEb7K6O58wp9bEM6KY EaOrHhbf8eJPWG4QFmJ8VIxLIr2jD3DWU2e9J+ZkqP1KZ61/xGS35D86Y0D9IbTL74f5 wcvDZTWNXd/Hkve8tkmxg2+oZizOzb3iW5WlF3aGZaDm3dL3DKLwPBsjuONSyyxv8V7k TzkJXF3mBRREptaLogHzaWdD3ho70/SaNrnZUzT4n4BpfZmuvlVG5mkOgVmhuCa0ot1P gdO9Enl6SmfDPe86OEX2pVATj/NRWHoVpuyfr6Sy1DSe8aNmxmpoxRIU3+McJsgs6Yxl 6MRw== X-Gm-Message-State: AOAM532I4o45I8KkgdJ59XHniG6/WIEoJFe41CQE33AnMfuvAByl42vo FRjG9CtlUzzCvlLWNBjGyWi42g== X-Google-Smtp-Source: ABdhPJy2AmTOb51BDdwUOYzF95HLQmIbML6+9DPgV2vlmfNf/gS+QQumkK0XzVQ3zBHzkUs41mvn/g== X-Received: by 2002:a17:902:8bc7:: with SMTP id r7mr6673755plo.57.1594782428813; Tue, 14 Jul 2020 20:07:08 -0700 (PDT) Received: from localhost ([122.172.34.142]) by smtp.gmail.com with ESMTPSA id h100sm388981pjb.46.2020.07.14.20.07.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2020 20:07:07 -0700 (PDT) Date: Wed, 15 Jul 2020 08:37:06 +0530 From: Viresh Kumar To: Lee Jones Cc: rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Olof Johansson , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Message-ID: <20200715030706.prxya7fyylscoy25@vireshk-i7> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200714145049.2496163-6-lee.jones@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 14-07-20, 15:50, Lee Jones wrote: > If function callers and providers do not share the same prototypes the > compiler complains of missing prototypes. Fix this by moving the > already existing prototypes out to a mutually convenient location. > > Fixes the following W=1 kernel build warning(s): > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] > 109 | int check_astate(void) > | ^~~~~~~~~~~~ > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] > 114 | void restore_astate(int cpu) > | ^~~~~~~~~~~~~~ > > Cc: Olof Johansson > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ Is there no sane way we can include this file directly to the cpufreq file ? > arch/powerpc/platforms/pasemi/powersave.S | 2 ++ > drivers/cpufreq/pasemi-cpufreq.c | 1 + > include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++++ > 4 files changed, 31 insertions(+), 15 deletions(-) > create mode 100644 include/linux/platform_data/pasemi.h -- viresh