From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB94C433E4 for ; Wed, 15 Jul 2020 03:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD1462070E for ; Wed, 15 Jul 2020 03:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mCQYqHda" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728131AbgGODJu (ORCPT ); Tue, 14 Jul 2020 23:09:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbgGODJt (ORCPT ); Tue, 14 Jul 2020 23:09:49 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B47C061755 for ; Tue, 14 Jul 2020 20:09:49 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id gc9so1754255pjb.2 for ; Tue, 14 Jul 2020 20:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R8Gi68qr1aDvO0QyibD3Pq2zcXF2jU6VWUvfFWeUSio=; b=mCQYqHdaeQKSdh/0G0+UcnKbrk3gam4BRinxdpoSmGWJoo7YCrXU1HXoo+l5rldKPl 35He1pWMZF9+F9lDMZ/nN7jyxZJKlRGDfK/7qZh0qgnwbam4p/hkHtbfSI7oUXsU2MYb Cl+PWrpd57mmjpgbe9ZokVqqcc23el1nAOtpj4e4lZMjeIEieffTfWhCh5sYaAZxbY0f cj8Y2A3l/aKfqUHGS48stXID25o58xi/YqXfV+8OlDK+hbdWvRENKfBx96v9J21XA8MR XbeQrkCgsBNXAIX4Fy0Wa8z3FfdSfjqYRN7X6lpEEm36Z9uwGzkz8f8D2M1DjKiUWxtg tJWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R8Gi68qr1aDvO0QyibD3Pq2zcXF2jU6VWUvfFWeUSio=; b=t1Wr6mNPsV0rBlomudyG61Ugsz7R8yWv5XNTd92Ud80QeLMgB901EHijApY3Ht5EbS gT0mzdaL1mBWVL76GpJ3jpAQGDpMk9GP3VzSBbexwTaLtfs6d+aAnk+vz7/akaAECvsU 5VmTHPh6lUe3w60EbbrwXD85wa9JVckdE6Z+jNBxR0MQZYGhKaEXbb5xCA2e4A+CC2W3 O0ZE8qXcgUNU7mjh/kAzzYFVQTJJ6C0z3j3ygR5uK/xkyQpXUecpxjWIjYFeKqKUrjc5 4Jb4F/17qKRw9+KmW8wflSa8pysEVI1Js5ymG7+DGQTusC/vhaCyNW+v0//u0wXJpiej 2/Dw== X-Gm-Message-State: AOAM533Dau2BkIG7i4oh51yc2SVmKwoNeu5wv/0V680ss5wK+S6pAUs1 zKrEC5tpdtDMlFwiqQmfOstilg== X-Google-Smtp-Source: ABdhPJxLkRpCAh56OHvV9+ruY7Vzg+a1Z9+GxC17tANOkAOMf1eHdhsH69mrQ3UVDo33lzSRWmiORw== X-Received: by 2002:a17:902:82cb:: with SMTP id u11mr6359503plz.207.1594782588903; Tue, 14 Jul 2020 20:09:48 -0700 (PDT) Received: from localhost ([122.172.34.142]) by smtp.gmail.com with ESMTPSA id ml8sm369552pjb.47.2020.07.14.20.09.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2020 20:09:48 -0700 (PDT) Date: Wed, 15 Jul 2020 08:39:46 +0530 From: Viresh Kumar To: Lee Jones Cc: rjw@rjwysocki.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Message-ID: <20200715030946.xxetozdxe5slvoid@vireshk-i7> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-8-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714145049.2496163-8-lee.jones@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 14-07-20, 15:50, Lee Jones wrote: > Repair problems with formatting and missing attributes/parameters, and > demote header comments which do not meet the required standards > applicable to kerneldoc. > > Fixes the following W=1 kernel build warning(s): > > drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' > drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' > drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' > drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' > drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' > drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' > drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > drivers/cpufreq/powernv-cpufreq.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 068cc53abe320..2e5a8b8a4abaa 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -64,13 +64,14 @@ > * highest_lpstate_idx > * @last_sampled_time: Time from boot in ms when global pstates were > * last set > - * @last_lpstate_idx, Last set value of local pstate and global > - * last_gpstate_idx pstate in terms of cpufreq table index > + * @last_lpstate_idx: Last set value of local pstate and global > + * @last_gpstate_idx: pstate in terms of cpufreq table index > * @timer: Is used for ramping down if cpu goes idle for > * a long time with global pstate held high > * @gpstate_lock: A spinlock to maintain synchronization between > * routines called by the timer handler and > * governer's target_index calls > + * @policy: Associated CPUFreq policy > */ > struct global_pstate_info { > int highest_lpstate_idx; > @@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift) > > /* Use following functions for conversions between pstate_id and index */ > > -/** > +/* > * idx_to_pstate : Returns the pstate id corresponding to the > * frequency in the cpufreq frequency table > * powernv_freqs indexed by @i. > @@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i) > return powernv_freqs[i].driver_data; > } > > -/** > +/* > * pstate_to_idx : Returns the index in the cpufreq frequencytable > * powernv_freqs for the frequency whose corresponding > * pstate id is @pstate. > @@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) > /** > * gpstate_timer_handler > * > - * @data: pointer to cpufreq_policy on which timer was queued > + * @t: Timer context used to fetch global pstate info struct > * > * This handler brings down the global pstate closer to the local pstate > * according quadratic equation. Queues a new timer if it is still not equal Acked-by: Viresh Kumar -- viresh