From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2087C433E8 for ; Wed, 15 Jul 2020 06:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CB0F206D5 for ; Wed, 15 Jul 2020 06:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XGBsIWWQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728866AbgGOGru (ORCPT ); Wed, 15 Jul 2020 02:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728671AbgGOGrt (ORCPT ); Wed, 15 Jul 2020 02:47:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75500C061794 for ; Tue, 14 Jul 2020 23:47:49 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so4184158wmh.4 for ; Tue, 14 Jul 2020 23:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=XGBsIWWQ4rQmBhLUNdm6ehB4cRfkZzVoo4evT3I5MZ7SfXhse4jI7tKro6tlGtAKvx vcNzSB6Y57nsLmW1KhHblZDArOxm5UCyl04aTLIywFjrAO6Bb420IPRy+hJfGCI/Nwjf IPzjST6rchSVPzMXhsSXZ/Bpx5vG4JxqkeYf57lar4VEG6Twy7oe/ew/R1EeWc5epv+O z9LPHPkZpbgNmnq/TAqRkLbGPBZgSqrF7GCZ4Km2IernIXhXtNVrqPi5Kc+j+Szq5/a1 kvfGT3WcEan0m5hUkC2tLVzin5iVOaSvKqUYm+4lw1rjmisSWY35681iqCSc/NbwDyBq N08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pFEdwPrFAGXygP0PLmBw7h9OMC5JQetuJaGwPug3T84=; b=rQYGRDHjUZGSF8eOlMfvu+9r+ouQ069qIs4139oZAe+JT9dURMhyLa3FoibxpiH4/O mx2k9M0yRijdGGUxoWDDJ6/pZYcqXEm0uoaQpV3tcXsDUBm5Hvp40seoZhsvTTFwtzXM oizVbArLMjGhCIYv1Ss1konFu1eUvkRi4qirN3u1RHGrxtFv71ZQkqj1rMA01YKwaEX6 CLlJ0DYp9Htq39ptIESssb1eHPx+FMskHGbSNQwhjH9CAVfd7rwcSv/hyHW1gwhmtSNa 04pMMKk3nSnbX88yQKdk1uylyzJF5vLTPSy/dZDVa05HUR0pDkpvrUuAIYWgPQVyHaNM MWmA== X-Gm-Message-State: AOAM531Tq5Qr3j0MwBNLySkAxZoIxc7X1i/OgGvgIXmmH5kC+pK3FPRF vSaB1z3ExWlCeaU5osbb5JREoKifEHE= X-Google-Smtp-Source: ABdhPJx+NTfnG9znaTGAktM3qpcuI/D+Sz92/+h/drddXvIQvTwedXSgGSKR6+Zl3zCJHSv8iY4C9A== X-Received: by 2002:a05:600c:2209:: with SMTP id z9mr7012030wml.178.1594795668190; Tue, 14 Jul 2020 23:47:48 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id r28sm2048595wrr.20.2020.07.14.23.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:47:47 -0700 (PDT) Date: Wed, 15 Jul 2020 07:47:46 +0100 From: Lee Jones To: Kim Phillips Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Message-ID: <20200715064746.GU1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-14-lee.jones@linaro.org> <6101e041-41e9-22bc-488d-38124c139bc7@amd.com> <20200714210218.GH1398296@dell> <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f7f2325-8c6a-b005-1f27-67e4b640da31@amd.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 14 Jul 2020, Kim Phillips wrote: > On 7/14/20 4:02 PM, Lee Jones wrote: > > On Tue, 14 Jul 2020, Kim Phillips wrote: > >> On 7/14/20 9:50 AM, Lee Jones wrote: > >>> Can't see them being used anywhere and the compiler doesn't complain > >>> that they're missing, so ... > >>> > >>> Fixes the following W=1 kernel build warning(s): > >>> > >>> drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=] > >>> 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { > >>> | ^~~~~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Cc: Jacob Shin > >>> Signed-off-by: Lee Jones > >>> --- > >> > >> Same comment as for patch 9/13: these are used automatic module loading. > > > > How does that work? > > > > Could you point me to the code which handles that please? > > It's MODULE_DEVICE_TABLE magic. I'll look into that. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog