From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C83C433E1 for ; Thu, 23 Jul 2020 18:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD0EA20B1F for ; Thu, 23 Jul 2020 18:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595529152; bh=ZDU+EEnAEQWEflbNqthke0jssQz/wTzJgnUV5q4keqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uEw287O7IrFD0JCIZFFsgvbm4HPyeMPgzgGX8GiZWQACw9FU7K6PUxkb5APj4l9Tx fZQXI23uICuibteOQt/nxb61QgN64VIaZInBxnpjdloY00ge1ZojqQvyQfjFhoRGYN x4A5aIZd5ck6ErLFH3Dehh/++P5WwmfU+VJmhnko= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbgGWScc (ORCPT ); Thu, 23 Jul 2020 14:32:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:49126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbgGWScc (ORCPT ); Thu, 23 Jul 2020 14:32:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F8DA20709; Thu, 23 Jul 2020 18:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595529151; bh=ZDU+EEnAEQWEflbNqthke0jssQz/wTzJgnUV5q4keqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lPrTsHDb+D4Ge6NG31U0z3PeggId4zb7RAYTrqQ0uoyp9RS8ZBkoNO5NnXx3xRSkJ 38R+0QYeLVuKc4sOTvJ2+xSXaOLxzaDKj0teqXKCYAHZGZnXnVVQTWjpx2bglXS14p yGIN2/GGK/3PmuUAbZbaLBaP1J4ApF0cF2AlLvFs= Date: Thu, 23 Jul 2020 20:32:35 +0200 From: Greg Kroah-Hartman To: Abhishek Pandit-Subedi , rafael.j.wysocki@intel.com Cc: linux-pm@vger.kernel.org, linux-bluetooth@vger.kernel.org, chromeos-bluetooth-upstreaming@chromium.org, swboyd@chromium.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Len Brown , Pavel Machek Subject: Re: [PATCH v5 1/1] power: Emit changed uevent on wakeup_sysfs_add/remove Message-ID: <20200723183235.GA3445384@kroah.com> References: <20200707172845.4177903-1-abhishekpandit@chromium.org> <20200707102823.v5.1.I51f5a0be89595b73c4dc17e6cf4cc6f26dc7f2fc@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707102823.v5.1.I51f5a0be89595b73c4dc17e6cf4cc6f26dc7f2fc@changeid> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 07, 2020 at 10:28:44AM -0700, Abhishek Pandit-Subedi wrote: > Udev rules that depend on the power/wakeup attribute don't get triggered > correctly if device_set_wakeup_capable is called after the device is > created. This can happen for several reasons (driver sets wakeup after > device is created, wakeup is changed on parent device, etc) and it seems > reasonable to emit a changed event when adding or removing attributes on > the device. > > Signed-off-by: Abhishek Pandit-Subedi Rafael, any objection to this? Do you want me to take it through my tree, or are you going to take it through yours? Either is fine for me. thanks, greg k-h