From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Zhang, Rui" <rui.zhang@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] powercap: Add Power Limit4 support
Date: Mon, 27 Jul 2020 15:13:16 +0300 [thread overview]
Message-ID: <20200727121316.GS3703480@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jQp2sHyzFKZu4ZL2HyN+kVax960+n2epTxBZbbZuZo8Q@mail.gmail.com>
On Mon, Jul 27, 2020 at 01:46:12PM +0200, Rafael J. Wysocki wrote:
> On Thu, Jul 16, 2020 at 7:38 PM Sumeet Pawnikar
> <sumeet.r.pawnikar@intel.com> wrote:
> >
> > Modern Intel Mobile platforms support power limit4 (PL4), which is
> > the SoC package level maximum power limit (in Watts). It can be used
> > to preemptively limits potential SoC power to prevent power spikes
> > from tripping the power adapter and battery over-current protection.
> > This patch enables this feature by exposing package level peak power
> > capping control to userspace via RAPL sysfs interface. With this,
> > application like DTPF can modify PL4 power limit, the similar way
> > of other package power limit (PL1).
> > As this feature is not tested on previous generations, here it is
> > enabled only for the platform that has been verified to work,
> > for safety concerns.
>
> Queued up as 5.9 material ->
>
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> > Co-developed-by: Zhang Rui <rui.zhang@intel.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
> -> with this tag removed, because the only case in which you can
> include an S-o-b from someone else is when you also add a From:
> pointing to that person. IOW, you add a From: with a matching S-o-b
> from someone else and you can add your own S-o-b to that.
>
> In this particular case, the C-d-b tag is sufficient to make a record
> of somebody else's contribution to a patch carrying a From: header
> that points to you (ie. your patch).
Rafael, it looks like it contradicts documentation. I mean your amendment.
SoB is specifically required to be coupled with Co-developed-by. That said,
both or none are acceptable. (I don't consider the chain of SoB when it goes
thru maintainers)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-27 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:44 [PATCH v3] powercap: Add Power Limit4 support Sumeet Pawnikar
2020-07-27 11:46 ` Rafael J. Wysocki
2020-07-27 12:13 ` Shevchenko, Andriy [this message]
2020-07-27 12:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727121316.GS3703480@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sumeet.r.pawnikar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).