From: Sebastian Reichel <sre@kernel.org>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: pali@kernel.org, robh@kernel.org, afd@ti.com, dmurphy@ti.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, sspatil@android.com
Subject: Re: [PATCH v18 2/4] dt-bindings: power: Convert battery.txt to battery.yaml
Date: Wed, 29 Jul 2020 18:46:35 +0200 [thread overview]
Message-ID: <20200729164635.cnjbadpq22tigwlc@earth.universe> (raw)
In-Reply-To: <20200728200814.26501-3-r-rivera-matos@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]
Hi Ricardo and Dan,
On Tue, Jul 28, 2020 at 03:08:12PM -0500, Ricardo Rivera-Matos wrote:
> From: Dan Murphy <dmurphy@ti.com>
>
> Convert the battery.txt file to yaml and fix up the examples.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
I merged this doing some modifcations while applying, so that this
is not postponed and risking conflicts due to added properties:
> [...]
> +patternProperties:
> + '^ocv-capacity-table-[0-100]$':
> [...]
[0-100] is a valid regex, but counterintuitively only allows 0 and
1. For example it does not apply for ocv-capacity-table-2.
I used [0-9]+ instead, which is being used by pinctrl.
> +examples:
> + - |
> + power {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + battery: battery {
> + compatible = "simple-battery";
> + over-voltage-threshold-microvolt = <4500000>;
> + re-charge-voltage-microvolt = <250000>;
> + voltage-min-design-microvolt = <3200000>;
> + voltage-max-design-microvolt = <4200000>;
> + energy-full-design-microwatt-hours = <5290000>;
> + charge-full-design-microamp-hours = <1430000>;
> + precharge-current-microamp = <256000>;
> + precharge-upper-limit-microvolt = <2500000>;
> + charge-term-current-microamp = <128000>;
> + constant-charge-current-max-microamp = <900000>;
> + constant-charge-voltage-max-microvolt = <4200000>;
> + factory-internal-resistance-micro-ohms = <250000>;
> + ocv-capacity-celsius = <(-10) 10>;
You state, that there is a table for -10 degrees and one for 10
degrees...
> + ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>;
... and then you provide only the table for -10 degrees. I fixed
this by simply using the previous example (tables for -10, 0 and 10
degrees) and 3 tables and added a comment above the tables.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-29 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 20:08 [PATCH v18 0/4] Add JEITA properties and introduce the bq2515x charger Ricardo Rivera-Matos
2020-07-28 20:08 ` [PATCH v18 1/4] power_supply: Add additional health properties to the header Ricardo Rivera-Matos
2020-07-28 20:08 ` [PATCH v18 2/4] dt-bindings: power: Convert battery.txt to battery.yaml Ricardo Rivera-Matos
2020-07-29 16:46 ` Sebastian Reichel [this message]
2020-07-28 20:08 ` [PATCH v18 3/4] dt-bindings: power: Add the bindings for the bq2515x family of chargers Ricardo Rivera-Matos
2020-07-28 20:08 ` [PATCH v18 4/4] power: supply: bq25150 introduce the bq25150 Ricardo Rivera-Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729164635.cnjbadpq22tigwlc@earth.universe \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=robh@kernel.org \
--cc=sspatil@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).