Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
* [pm:bleeding-edge 83/91] drivers/acpi/processor_idle.c:667:4: warning: 'return' with no value, in function returning non-void
@ 2020-07-30  3:39 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-07-30  3:39 UTC (permalink / raw)
  To: Neal Liu
  Cc: kbuild-all, linux-acpi, devel, linux-pm, Rafael J. Wysocki,
	Sami Tolvanen


[-- Attachment #1: Type: text/plain, Size: 4563 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head:   5bff8c754ebfc08b9cead967f38ebc0152d2076f
commit: efe9711214e6138a5a2a46ca4068bfce50c03444 [83/91] cpuidle: change enter_s2idle() prototype
config: ia64-randconfig-r024-20200729 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout efe9711214e6138a5a2a46ca4068bfce50c03444
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/acpi/processor_idle.c: In function 'acpi_idle_enter':
   drivers/acpi/processor_idle.c:649:25: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     649 |   ACPI_FLUSH_CPU_CACHE();
         |                         ^
   drivers/acpi/processor_idle.c: In function 'acpi_idle_enter_s2idle':
>> drivers/acpi/processor_idle.c:667:4: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
     667 |    return;
         |    ^~~~~~
   drivers/acpi/processor_idle.c:658:12: note: declared here
     658 | static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
         |            ^~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/processor_idle.c:671:4: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
     671 |    return;
         |    ^~~~~~
   drivers/acpi/processor_idle.c:658:12: note: declared here
     658 | static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
         |            ^~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/processor_idle.c: At top level:
   drivers/acpi/processor_idle.c:1085:12: warning: no previous prototype for 'acpi_processor_ffh_lpi_probe' [-Wmissing-prototypes]
    1085 | int __weak acpi_processor_ffh_lpi_probe(unsigned int cpu)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/processor_idle.c:1090:12: warning: no previous prototype for 'acpi_processor_ffh_lpi_enter' [-Wmissing-prototypes]
    1090 | int __weak acpi_processor_ffh_lpi_enter(struct acpi_lpi_state *lpi)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/return +667 drivers/acpi/processor_idle.c

4f86d3a8e297205 Len Brown         2007-10-03  657  
efe9711214e6138 Neal Liu          2020-07-27  658  static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
5f5081852038d9a Rafael J. Wysocki 2015-02-11  659  				  struct cpuidle_driver *drv, int index)
5f5081852038d9a Rafael J. Wysocki 2015-02-11  660  {
5f5081852038d9a Rafael J. Wysocki 2015-02-11  661  	struct acpi_processor_cx *cx = per_cpu(acpi_cstate[index], dev->cpu);
5f5081852038d9a Rafael J. Wysocki 2015-02-11  662  
5f5081852038d9a Rafael J. Wysocki 2015-02-11  663  	if (cx->type == ACPI_STATE_C3) {
5f5081852038d9a Rafael J. Wysocki 2015-02-11  664  		struct acpi_processor *pr = __this_cpu_read(processors);
5f5081852038d9a Rafael J. Wysocki 2015-02-11  665  
5f5081852038d9a Rafael J. Wysocki 2015-02-11  666  		if (unlikely(!pr))
5f5081852038d9a Rafael J. Wysocki 2015-02-11 @667  			return;
5f5081852038d9a Rafael J. Wysocki 2015-02-11  668  
5f5081852038d9a Rafael J. Wysocki 2015-02-11  669  		if (pr->flags.bm_check) {
5f5081852038d9a Rafael J. Wysocki 2015-02-11  670  			acpi_idle_enter_bm(pr, cx, false);
5f5081852038d9a Rafael J. Wysocki 2015-02-11  671  			return;
5f5081852038d9a Rafael J. Wysocki 2015-02-11  672  		} else {
5f5081852038d9a Rafael J. Wysocki 2015-02-11  673  			ACPI_FLUSH_CPU_CACHE();
5f5081852038d9a Rafael J. Wysocki 2015-02-11  674  		}
5f5081852038d9a Rafael J. Wysocki 2015-02-11  675  	}
5f5081852038d9a Rafael J. Wysocki 2015-02-11  676  	acpi_idle_do_entry(cx);
efe9711214e6138 Neal Liu          2020-07-27  677  
efe9711214e6138 Neal Liu          2020-07-27  678  	return 0;
5f5081852038d9a Rafael J. Wysocki 2015-02-11  679  }
5f5081852038d9a Rafael J. Wysocki 2015-02-11  680  

:::::: The code at line 667 was first introduced by commit
:::::: 5f5081852038d9a7b309190730bfb724b413235e ACPI / idle: Implement ->enter_freeze callback routine

:::::: TO: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
:::::: CC: Rafael J. Wysocki <rjw@rjwysocki.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32302 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30  3:39 [pm:bleeding-edge 83/91] drivers/acpi/processor_idle.c:667:4: warning: 'return' with no value, in function returning non-void kernel test robot

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git