Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Qiwu Huang <yanziily@gmail.com>,
	sre@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com,
	Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v4 1/4] power: supply: core: add quick charge type property
Date: Sun, 2 Aug 2020 14:37:42 +0200
Message-ID: <20200802123742.GA257810@kroah.com> (raw)
In-Reply-To: <20200802120015.GA1289@bug>

On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote:
> On Mon 2020-07-20 13:47:14, Qiwu Huang wrote:
> > From: Qiwu Huang <huangqiwu@xiaomi.com>
> > 
> > Reports the kind of quick charge type based on
> > different adapter power.
> > 
> > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> > ---
> >  Documentation/ABI/testing/sysfs-class-power | 21 +++++++++++++++++++++
> >  drivers/power/supply/power_supply_sysfs.c   |  1 +
> >  include/linux/power_supply.h                | 10 ++++++++++
> >  3 files changed, 32 insertions(+)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > index 216d61a22f1e..dd3773dcf16a 100644
> > --- a/Documentation/ABI/testing/sysfs-class-power
> > +++ b/Documentation/ABI/testing/sysfs-class-power
> > @@ -708,3 +708,24 @@ Description:
> >  
> >  		Access: Read
> >  		Valid values: 1-31
> > +
> > +What:		/sys/class/power_supply/<supply_name>/quick_charge_type
> > +Date:		Jul 2020
> > +Contact:	Fei Jiang <jiangfei1@xiaomi.com>
> > +		Description:
> > +		Reports the kind of quick charge type based on different adapter power.
> > +		Different quick charge type represent different charging power.
> > +		QUICK_CHARGE_NORMAL : Charging Power <= 10W
> > +		QUICK_CHARGE_FAST : 10W < Charging Power <= 20W
> > +		QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W
> > +		QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W
> > +		QUICK_CHARGE_SUPER : Charging Power > 50W
> > +
> > +		Access: Read-Only
> > +		Valid values:
> > +			0: QUICK_CHARGE_NORMAL,
> > +			1: QUICK_CHARGE_FAST,
> > +			2: QUICK_CHARGE_FLASH,
> > +			3: QUICK_CHARGE_TURBE,
> > +			4: QUICK_CHARGE_SUPER.
> 
> NAK.
> 
> Just expose value in watts or something... People are talking about > 100W charging, no
> need to go with fast/turbe/super/hyper/nonsense.
> 
> BTW fast charge is already "well defined", and what you call Normal is usually fast charge.

I think these names come from the Qi charging spec, right?  So lets use
what is given to us.

thanks,

greg k-h

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20  5:47 [PATCH v4 0/4] add some power supply properties about wireless/wired charging Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 1/4] power: supply: core: add quick charge type property Qiwu Huang
2020-08-02 12:00   ` Pavel Machek
2020-08-02 12:37     ` Greg KH [this message]
2020-08-02 14:28       ` Pavel Machek
2020-08-02 16:57         ` Greg KH
2020-08-03 11:49           ` Sebastian Reichel
2020-08-03 11:56             ` Greg KH
2020-08-04  2:11               ` ivan
2020-08-04  7:49                 ` Greg KH
2020-07-20  5:47 ` [PATCH v4 2/4] power: supply: core: add wireless charger adapter " Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 3/4] power: supply: core: add wireless signal strength property Qiwu Huang
2020-07-20  5:47 ` [PATCH v4 4/4] power: supply: core: property to control reverse charge Qiwu Huang
2020-07-20  8:21 ` [PATCH v4 0/4] add some power supply properties about wireless/wired charging Greg KH
2020-07-21  3:12   ` ivan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200802123742.GA257810@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=huangqiwu@xiaomi.com \
    --cc=jiangfei1@xiaomi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=yanziily@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git