linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Elliot Berman <eberman@codeaurora.org>
Cc: Andy Yan <andy.yan@rock-chips.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Trilok Soni <tsoni@codeaurora.org>,
	Prasad Sodagudi <psodagud@codeaurora.org>
Subject: Re: [RESEND PATCH v1 1/4] dt-bindings: power: reset: Convert reboot-mode to YAML
Date: Tue, 25 Aug 2020 18:21:01 +0200	[thread overview]
Message-ID: <20200825162101.27ivwlxbby7q7hy6@earth.universe> (raw)
In-Reply-To: <1597776856-12014-2-git-send-email-eberman@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 4315 bytes --]

Hi,

Thanks, queued.

-- Sebastian

On Tue, Aug 18, 2020 at 11:54:13AM -0700, Elliot Berman wrote:
> Convert reboot-mode bindings to YAML.
> 
> Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> ---
>  .../bindings/power/reset/reboot-mode.txt           | 25 ------------
>  .../bindings/power/reset/reboot-mode.yaml          | 47 ++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.txt
>  create mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/reboot-mode.txt
> deleted file mode 100644
> index de34f27..0000000
> --- a/Documentation/devicetree/bindings/power/reset/reboot-mode.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Generic reboot mode core map driver
> -
> -This driver get reboot mode arguments and call the write
> -interface to store the magic value in special register
> -or ram. Then the bootloader can read it and take different
> -action according to the argument stored.
> -
> -All mode properties are vendor specific, it is a indication to tell
> -the bootloader what to do when the system reboots, and should be named
> -as mode-xxx = <magic> (xxx is mode name, magic should be a none-zero value).
> -
> -For example modes common on Android platform:
> -- mode-normal: Normal reboot mode, system reboot with command "reboot".
> -- mode-recovery: Android Recovery mode, it is a mode to format the device or update a new image.
> -- mode-bootloader: Android fastboot mode, it's a mode to re-flash partitions on the Android based device.
> -- mode-loader: A bootloader mode, it's a mode used to download image on Rockchip platform,
> -	       usually used in development.
> -
> -Example:
> -	reboot-mode {
> -		mode-normal = <BOOT_NORMAL>;
> -		mode-recovery = <BOOT_RECOVERY>;
> -		mode-bootloader = <BOOT_FASTBOOT>;
> -		mode-loader = <BOOT_BL_DOWNLOAD>;
> -	}
> diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> new file mode 100644
> index 0000000..a6c9102
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/reboot-mode.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic reboot mode core map
> +
> +maintainers:
> +  - Andy Yan <andy.yan@rock-chips.com>
> +
> +description: |
> +  This driver get reboot mode arguments and call the write
> +  interface to store the magic value in special register
> +  or ram. Then the bootloader can read it and take different
> +  action according to the argument stored.
> +
> +  All mode properties are vendor specific, it is a indication to tell
> +  the bootloader what to do when the system reboots, and should be named
> +  as mode-xxx = <magic> (xxx is mode name, magic should be a non-zero value).
> +
> +  For example, modes common Android platform are:
> +    - normal: Normal reboot mode, system reboot with command "reboot".
> +    - recovery: Android Recovery mode, it is a mode to format the device or update a new image.
> +    - bootloader: Android fastboot mode, it's a mode to re-flash partitions on the Android based device.
> +    - loader: A bootloader mode, it's a mode used to download image on Rockchip platform,
> +              usually used in development.
> +
> +properties:
> +  mode-normal:
> +      $ref: /schemas/types.yaml#/definitions/uint32
> +      description: |
> +        Default value to set on a reboot if no command was provided.
> +
> +patternProperties:
> +  "^mode-.*$":
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +examples:
> +  - |
> +    reboot-mode {
> +      mode-normal = <0>;
> +      mode-recovery = <1>;
> +      mode-bootloader = <2>;
> +      mode-loader = <3>;
> +    };
> +...
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-08-25 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 18:54 [RESEND PATCH v1 0/4] Support spaces in reboot mode framework Elliot Berman
2020-08-18 18:54 ` [RESEND PATCH v1 1/4] dt-bindings: power: reset: Convert reboot-mode to YAML Elliot Berman
2020-08-25 16:21   ` Sebastian Reichel [this message]
2020-08-18 18:54 ` [RESEND PATCH v1 2/4] dt-bindings: power: reset: Add alternate reboot mode format Elliot Berman
2020-08-25 16:23   ` Sebastian Reichel
2020-08-25 21:25   ` Rob Herring
2020-08-26 18:39     ` Elliot Berman
2020-08-18 18:54 ` [RESEND PATCH v1 3/4] power: reset: Add support for reboot mode alternate properties Elliot Berman
2020-08-18 18:54 ` [RESEND PATCH v1 4/4] arm64: dts: qcom: pm8150: Add reboot magic Elliot Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825162101.27ivwlxbby7q7hy6@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=agross@kernel.org \
    --cc=andy.yan@rock-chips.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eberman@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).