From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephan Gerhold <stephan@gerhold.net>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: tegra: Pass multiple versions in opp-supported-hw property
Date: Mon, 31 Aug 2020 10:09:08 +0530 [thread overview]
Message-ID: <20200831043908.mtw4dglybcmcabjb@vireshk-i7> (raw)
In-Reply-To: <b0763074-859f-fccb-dde4-03d1a50ea021@gmail.com>
On 28-08-20, 10:37, Dmitry Osipenko wrote:
> 26.08.2020 14:50, Viresh Kumar пишет:
> > We can now pass multiple versions in "opp-supported-hw" property, lets
> > do that and simplify the tables a bit.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > ---
> > Dmitry, I think there is further scope of simplifying stuff here by
> > using the opp-microvolt-<name> property and corresponding
> > dev_pm_opp_set_prop_name() call.
Any inputs on this Dmitry ?
> > diff --git a/arch/arm/boot/dts/tegra30-cpu-opp.dtsi b/arch/arm/boot/dts/tegra30-cpu-opp.dtsi
> ...
> > - opp@1000000000,975,3,7 {
> > - clock-latency-ns = <100000>;
> > - opp-supported-hw = <0x08 0x0080>;
> > - opp-hz = /bits/ 64 <1000000000>;
> > + opp-supported-hw = <0x0F 0x0001>,
> > + <0x01 0x0002>,
> > + <0x01 0x0010>,
> > + <0x01 0x0080>,
> > + <0x01 0x0100>;
> > + opp-hz = /bits/ 64 <475000000>;
> > };
>
> The only very minor difference between my OPP-gen result and yours is
> that the above hunk has inconsistent single-column formatting, while all
> others are two-column.
Ah, my mistake. Fixed and pushed now.
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
Thanks.
--
viresh
next prev parent reply other threads:[~2020-08-31 4:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:50 [PATCH 0/3] opp: Allow opp-supported-hw to contain multiple versions Viresh Kumar
2020-08-26 11:50 ` [PATCH 1/3] dt-bindings: " Viresh Kumar
2020-08-26 11:50 ` [PATCH 2/3] " Viresh Kumar
2020-08-26 16:59 ` Stephan Gerhold
2020-08-28 7:38 ` Dmitry Osipenko
2020-08-26 11:50 ` [PATCH 3/3] ARM: tegra: Pass multiple versions in opp-supported-hw property Viresh Kumar
2020-08-28 7:37 ` Dmitry Osipenko
2020-08-31 4:39 ` Viresh Kumar [this message]
2020-08-31 7:54 ` Dmitry Osipenko
2020-08-31 8:41 ` Viresh Kumar
2020-08-31 9:54 ` Dmitry Osipenko
2020-08-31 11:04 ` Viresh Kumar
2020-09-01 13:21 ` Dmitry Osipenko
2020-09-02 5:23 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831043908.mtw4dglybcmcabjb@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).