From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875A7C433E0 for ; Tue, 12 Jan 2021 14:48:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 363E323121 for ; Tue, 12 Jan 2021 14:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbhALOsK (ORCPT ); Tue, 12 Jan 2021 09:48:10 -0500 Received: from mail-oi1-f170.google.com ([209.85.167.170]:37409 "EHLO mail-oi1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbhALOsK (ORCPT ); Tue, 12 Jan 2021 09:48:10 -0500 Received: by mail-oi1-f170.google.com with SMTP id l207so2570712oib.4; Tue, 12 Jan 2021 06:47:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fM7xQp3erzKr1NA4fTfzZcmXzvgc/peYjgAUUn7uWyw=; b=dO+eLV64q95puXhnJW8gF5hx386tbnZCSRKfsDQ7OAUt+cvWk/+EBIrS3/9kKTtOoq fS+kPN01DEtMaQqd57jAtKxGph4zrkHEGe23O+3zIgcENIuNGwdjEUx69m0NhHww2XJE +BBSa0OcwTz9Eb/F8wty20/AL+O5QB0G15tOe86Be1S39yAmgbc5F/SBzNzWryX349jk zeYDCtO8eGE4soLcKQPSpKiPGR2qZs/yZ7MCChonZuCCUcoA1MUV7zYf4Qqf0vib5X2U FIgtTSvdEUN/3OEH1jxKiY8TS4gCa4uM/1nPDrOYsVEsCCeboiuAwsAmxcb6tfM/HT/G ed4w== X-Gm-Message-State: AOAM533x+shEmvf5QuAvgFrMQ+XUmOz/wIMJ/j1wAsjI0fIQgx5SBw8J O4BrEBB/XZF2g4lPBO7N6Q== X-Google-Smtp-Source: ABdhPJwcZgbwzeRahJPpZSMpiaWcIjlcHI6CPeiAiAqPyp/VNO1VZhfwn95148OOQWTPVBTGqP0F0Q== X-Received: by 2002:aca:af8b:: with SMTP id y133mr2510768oie.87.1610462849269; Tue, 12 Jan 2021 06:47:29 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y12sm403965oti.0.2021.01.12.06.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 06:47:28 -0800 (PST) Received: (nullmailer pid 327562 invoked by uid 1000); Tue, 12 Jan 2021 14:47:27 -0000 Date: Tue, 12 Jan 2021 08:47:27 -0600 From: Rob Herring To: Roger Lu Cc: Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat , Stephen Boyd , Philipp Zabel , Fan Chen , HenryC Chen , YT Lee , Xiaoqing Liu , Charles Yang , Angus Lin , Mark Rutland , Nishanth Menon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v11 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings Message-ID: <20210112144727.GA321805@robh.at.kernel.org> References: <20210107024356.583-1-roger.lu@mediatek.com> <20210107024356.583-2-roger.lu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107024356.583-2-roger.lu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Jan 07, 2021 at 10:43:50AM +0800, Roger Lu wrote: > Document the binding for enabling mtk svs on MediaTek SoC. > > Signed-off-by: Roger Lu > --- > .../bindings/soc/mediatek/mtk-svs.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml > new file mode 100644 > index 000000000000..bb8c345a0c0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mediatek/mtk-svs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Introduce MTK SVS engine Introduce? That's what this commit does, not what this binding is. > + > +maintainers: > + - Matthias Brugger > + - Kevin Hilman > + - Nishanth Menon This should be someone that knows the h/w. Not who applies patches. Perhaps you. > + > +description: |+ > + The Smart Voltage Scaling(SVS) engine is a piece of hardware > + which has several controllers(banks) for calculating suitable > + voltage to different power domains(CPU/GPU/CCI) according to > + chip process corner, temperatures and other factors. Then DVFS > + driver could apply SVS bank voltage to PMIC/Buck. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8183-svs > + > + reg: > + description: Address range of the MTK SVS controller. > + maxItems: 1 > + > + interrupts: > + description: IRQ for the MTK SVS controller. Drop. That's kind of obvious with only 1 interrupt. > + maxItems: 1 > + > + clocks: > + description: Main clock for MTK SVS controller to work. How many clocks (maxItems)? > + > + clock-names: > + const: main > + > + nvmem-cells: > + maxItems: 2 > + description: > + Phandle to the calibration data provided by a nvmem device. Need to define what each entry is. items: - description: ... - description: ... > + > + nvmem-cell-names: > + items: > + - const: svs-calibration-data > + - const: t-calibration-data > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + svs@1100b000 { > + compatible = "mediatek,mt8183-svs"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = ; > + clocks = <&infracfg CLK_INFRA_THERM>; > + clock-names = "main"; > + nvmem-cells = <&svs_calibration>, <&thermal_calibration>; > + nvmem-cell-names = "svs-calibration-data", "t-calibration-data"; > + }; > + }; > -- > 2.18.0 >