From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: pali@kernel.org, dmurphy@ti.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq27xxx: fix polarity of current_now
Date: Sat, 16 Jan 2021 15:57:04 +0100 [thread overview]
Message-ID: <20210116145704.7hycpifbjgjivqkq@earth.universe> (raw)
In-Reply-To: <20201204144950.8062-1-andreas@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
Hi,
On Fri, Dec 04, 2020 at 03:49:50PM +0100, Andreas Kemnade wrote:
> current_now has to be negative during discharging and positive during
> charging, the behavior seen is the other way round.
>
> Tested on GTA04 with Openmoko battery
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/bq27xxx_battery.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 315e0909e6a4..3ecc18b01d49 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1789,7 +1789,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
>
> if (di->opts & BQ27XXX_O_ZERO) {
> flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, true);
> - if (flags & BQ27000_FLAG_CHGS) {
> + if (!(flags & BQ27000_FLAG_CHGS)) {
> dev_dbg(di->dev, "negative current!\n");
> curr = -curr;
> }
> @@ -1797,7 +1797,7 @@ static int bq27xxx_battery_current(struct bq27xxx_device_info *di,
> val->intval = curr * BQ27XXX_CURRENT_CONSTANT / BQ27XXX_RS;
> } else {
> /* Other gauges return signed value */
> - val->intval = (int)((s16)curr) * 1000;
> + val->intval = -(int)((s16)curr) * 1000;
> }
>
> return 0;
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-16 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 14:49 [PATCH] power: bq27xxx: fix polarity of current_now Andreas Kemnade
2021-01-16 14:57 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116145704.7hycpifbjgjivqkq@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=andreas@kemnade.info \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).