From: Viresh Kumar <viresh.kumar@linaro.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Sibi Sankar <sibis@codeaurora.org>,
Saravana Kannan <saravanak@google.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Android Kernel Team <kernel-team@android.com>,
Linux PM <linux-pm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
Subject: Re: [PATCH v3 3/5] OPP: Improve require-opps linking
Date: Thu, 28 Jan 2021 09:43:42 +0530 [thread overview]
Message-ID: <20210128041342.owkjl4voodw4dcmf@vireshk-i7> (raw)
In-Reply-To: <CAJMQK-hgeOv9XDasmmWGguxyC62SCsSoX5_enEb46whE8_Emew@mail.gmail.com>
On 27-01-21, 22:40, Hsin-Yi Wang wrote:
> Hi Viresh,
>
> I tested this patch with devfreq passive governor[1] and mt8183
> cci[2]. It's also working as expected.
I hope I can add your Tested-by for the patch then, right ?
> [1] https://patchwork.kernel.org/project/linux-pm/cover/20190724014222.110767-1-saravanak@google.com/
> (patch 2,4,5)
> [2] https://patchwork.kernel.org/project/linux-mediatek/cover/1594348284-14199-1-git-send-email-andrew-sh.cheng@mediatek.com/
>
> In my testing case, required_opp_table is not genpd case (mt8183 cci
> is not genpd), so I remove the following constraint. Does that make
> sense to you?
>
> @@ -377,13 +377,6 @@ static void lazy_link_required_opp_table(struct
> opp_table *new_table)
> struct dev_pm_opp *opp;
> int i, ret;
>
> - /*
> - * We only support genpd's OPPs in the "required-opps" for now,
> - * as we don't know much about other cases.
> - */
> - if (!new_table->is_genpd)
> - return;
> -
> mutex_lock(&opp_table_lock);
We will perhaps need more changes than that, but those should be done
separately when you try to add a user for the same.
--
viresh
next prev parent reply other threads:[~2021-01-28 4:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 22:23 [PATCH v3 0/5] Add required-opps support to devfreq passive gov Saravana Kannan
2019-07-17 22:23 ` [PATCH v3 1/5] OPP: Allow required-opps even if the device doesn't have power-domains Saravana Kannan
2019-07-17 22:23 ` [PATCH v3 2/5] OPP: Add function to look up required OPP's for a given OPP Saravana Kannan
2019-07-23 9:53 ` Viresh Kumar
2019-07-24 0:23 ` Saravana Kannan
2019-07-25 2:58 ` Viresh Kumar
2019-07-25 3:46 ` Saravana Kannan
2019-07-25 5:38 ` Viresh Kumar
2019-07-26 1:41 ` Saravana Kannan
2019-07-17 22:23 ` [PATCH v3 3/5] OPP: Improve require-opps linking Saravana Kannan
2019-07-23 10:28 ` Viresh Kumar
2019-07-23 20:36 ` Saravana Kannan
[not found] ` <CAGETcx-6M9Ts8tfMf6aA8GjMyzK5sOLr069ZCxTG7RHMFPLzHw@mail.gmail.com>
2019-07-25 3:07 ` Viresh Kumar
2019-07-25 4:09 ` Saravana Kannan
2019-07-25 5:17 ` Viresh Kumar
2019-07-26 1:52 ` Saravana Kannan
2019-07-26 21:23 ` Saravana Kannan
2019-07-29 7:26 ` Viresh Kumar
2019-07-30 23:02 ` Hsin-Yi Wang
2019-07-30 23:05 ` Saravana Kannan
2019-11-25 11:28 ` Viresh Kumar
2019-11-25 11:29 ` Viresh Kumar
2019-12-05 19:11 ` Saravana Kannan
2019-12-10 5:21 ` Viresh Kumar
2020-01-27 6:11 ` Viresh Kumar
2020-01-29 13:34 ` Sibi Sankar
2020-01-30 4:21 ` Viresh Kumar
2021-01-18 7:21 ` Hsin-Yi Wang
2021-01-18 7:34 ` Viresh Kumar
2021-01-18 7:39 ` Hsin-Yi Wang
2021-01-20 0:05 ` Saravana Kannan
2021-01-27 11:54 ` Viresh Kumar
2021-01-27 14:40 ` Hsin-Yi Wang
2021-01-28 4:13 ` Viresh Kumar [this message]
2021-01-28 5:05 ` Hsin-Yi Wang
2019-07-17 22:23 ` [PATCH v3 4/5] PM / devfreq: Cache OPP table reference in devfreq Saravana Kannan
2019-07-17 22:23 ` [PATCH v3 5/5] PM / devfreq: Add required OPPs support to passive governor Saravana Kannan
2019-07-23 10:04 ` Viresh Kumar
2019-07-24 0:26 ` Saravana Kannan
2019-07-25 3:01 ` Viresh Kumar
2019-07-25 3:58 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128041342.owkjl4voodw4dcmf@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew-sh.cheng@mediatek.com \
--cc=cw00.choi@samsung.com \
--cc=hsinyi@chromium.org \
--cc=kernel-team@android.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).