From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH -next] power: supply: generic-adc-battery: fix possible use-after-free in gab_remove()
Date: Thu, 8 Apr 2021 14:38:49 +0200 [thread overview]
Message-ID: <20210408123849.c7oxkfrvxcvehftr@earth.universe> (raw)
In-Reply-To: <20210407091706.3266580-1-yangyingliang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
Hi,
On Wed, Apr 07, 2021 at 05:17:06PM +0800, Yang Yingliang wrote:
> This driver's remove path calls cancel_delayed_work(). However, that
> function does not wait until the work function finishes. This means
> that the callback function may still be running after the driver's
> remove function has finished, which would result in a use-after-free.
>
> Fix by calling cancel_delayed_work_sync(), which ensures that
> the work is properly cancelled, no longer running, and unable
> to re-schedule itself.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/generic-adc-battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
> index 0032069fbc2b..66039c665dd1 100644
> --- a/drivers/power/supply/generic-adc-battery.c
> +++ b/drivers/power/supply/generic-adc-battery.c
> @@ -373,7 +373,7 @@ static int gab_remove(struct platform_device *pdev)
> }
>
> kfree(adc_bat->psy_desc.properties);
> - cancel_delayed_work(&adc_bat->bat_work);
> + cancel_delayed_work_sync(&adc_bat->bat_work);
> return 0;
> }
>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-08 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:17 [PATCH -next] power: supply: generic-adc-battery: fix possible use-after-free in gab_remove() Yang Yingliang
2021-04-08 12:38 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408123849.c7oxkfrvxcvehftr@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).