* [PATCH v3] thermal: mediatek: add sensors-support
@ 2021-04-20 17:23 Frank Wunderlich
2021-06-07 18:34 ` Aw: " Frank Wunderlich
2021-06-08 14:11 ` Matthias Brugger
0 siblings, 2 replies; 4+ messages in thread
From: Frank Wunderlich @ 2021-04-20 17:23 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria,
Matthias Brugger, linux-pm, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v3: drop no_hwmon - now really, sorry
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
drivers/thermal/mtk_thermal.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 149c6d7fd5a0..85964988684b 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
#include <linux/reset.h>
#include <linux/types.h>
+#include "thermal_hwmon.h"
+
/* AUXADC Registers */
#define AUXADC_CON1_SET_V 0x008
#define AUXADC_CON1_CLR_V 0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
goto err_disable_clk_peri_therm;
}
+ ret = devm_thermal_add_hwmon_sysfs(tzdev);
+ if (ret)
+ dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
return 0;
err_disable_clk_peri_therm:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Aw: [PATCH v3] thermal: mediatek: add sensors-support
2021-04-20 17:23 [PATCH v3] thermal: mediatek: add sensors-support Frank Wunderlich
@ 2021-06-07 18:34 ` Frank Wunderlich
2021-06-08 14:11 ` Matthias Brugger
1 sibling, 0 replies; 4+ messages in thread
From: Frank Wunderlich @ 2021-06-07 18:34 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Daniel Lezcano, Amit Kucheria, Matthias Brugger,
linux-pm, linux-arm-kernel, linux-kernel
Hi,
just a gentle ping ;)
regards Frank
> Gesendet: Dienstag, 20. April 2021 um 19:23 Uhr
> Von: "Frank Wunderlich" <linux@fw-web.de>
> An: linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Amit Kucheria" <amitk@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: [PATCH v3] thermal: mediatek: add sensors-support
>
> From: Frank Wunderlich <frank-w@public-files.de>
>
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v3: drop no_hwmon - now really, sorry
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
> drivers/thermal/mtk_thermal.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 149c6d7fd5a0..85964988684b 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
> #include <linux/reset.h>
> #include <linux/types.h>
>
> +#include "thermal_hwmon.h"
> +
> /* AUXADC Registers */
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> goto err_disable_clk_peri_therm;
> }
>
> + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> + if (ret)
> + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
> return 0;
>
> err_disable_clk_peri_therm:
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] thermal: mediatek: add sensors-support
2021-04-20 17:23 [PATCH v3] thermal: mediatek: add sensors-support Frank Wunderlich
2021-06-07 18:34 ` Aw: " Frank Wunderlich
@ 2021-06-08 14:11 ` Matthias Brugger
1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2021-06-08 14:11 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria, linux-pm,
linux-arm-kernel, linux-kernel
On 20/04/2021 19:23, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v3: drop no_hwmon - now really, sorry
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
> drivers/thermal/mtk_thermal.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 149c6d7fd5a0..85964988684b 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
> #include <linux/reset.h>
> #include <linux/types.h>
>
> +#include "thermal_hwmon.h"
> +
> /* AUXADC Registers */
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> goto err_disable_clk_peri_therm;
> }
>
> + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> + if (ret)
> + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
I think dev_warn() is more appropriate here.
Regards,
Matthias
> +
> return 0;
>
> err_disable_clk_peri_therm:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] thermal: mediatek: add sensors-support
@ 2021-04-20 17:16 Frank Wunderlich
0 siblings, 0 replies; 4+ messages in thread
From: Frank Wunderlich @ 2021-04-20 17:16 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria,
Matthias Brugger, linux-pm, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v3: drop no_hwmon
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
drivers/thermal/mtk_thermal.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 149c6d7fd5a0..32be8a715c7d 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
#include <linux/reset.h>
#include <linux/types.h>
+#include "thermal_hwmon.h"
+
/* AUXADC Registers */
#define AUXADC_CON1_SET_V 0x008
#define AUXADC_CON1_CLR_V 0x00c
@@ -1087,6 +1089,11 @@ static int mtk_thermal_probe(struct platform_device *pdev)
goto err_disable_clk_peri_therm;
}
+ tzdev->tzp->no_hwmon = false;
+ ret = devm_thermal_add_hwmon_sysfs(tzdev);
+ if (ret)
+ dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
return 0;
err_disable_clk_peri_therm:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-08 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 17:23 [PATCH v3] thermal: mediatek: add sensors-support Frank Wunderlich
2021-06-07 18:34 ` Aw: " Frank Wunderlich
2021-06-08 14:11 ` Matthias Brugger
-- strict thread matches above, loose matches on Subject: below --
2021-04-20 17:16 Frank Wunderlich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).