From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Dmitry Osipenko <digetx@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephan Gerhold <stephan@gerhold.net>,
Roja Rani Yarubandi <rojay@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/4] PM: domains: Return early if perf state is already set for the device
Date: Thu, 3 Jun 2021 11:34:36 +0200 [thread overview]
Message-ID: <20210603093438.138705-3-ulf.hansson@linaro.org> (raw)
In-Reply-To: <20210603093438.138705-1-ulf.hansson@linaro.org>
When dev_pm_genpd_set_performance_state() gets called to set a new
performance state for the device, let's take a quicker path by doing an
early return, if it turns out that the new state is already set for the
device.
Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
Changes in v2:
- New patch.
---
drivers/base/power/domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 5c476ed1c6c9..ef25a5b18587 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -387,6 +387,9 @@ static int genpd_set_performance_state(struct device *dev, unsigned int state)
int ret;
prev_state = gpd_data->performance_state;
+ if (prev_state == state)
+ return 0;
+
gpd_data->performance_state = state;
state = _genpd_reeval_performance_state(genpd, state);
--
2.25.1
next prev parent reply other threads:[~2021-06-03 9:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 9:34 [PATCH v2 0/4] PM: domains: Avoid boilerplate code for DVFS in subsystem/drivers Ulf Hansson
2021-06-03 9:34 ` [PATCH v2 1/4] PM: domains: Split code in dev_pm_genpd_set_performance_state() Ulf Hansson
2021-06-03 9:34 ` Ulf Hansson [this message]
2021-06-03 9:34 ` [PATCH v2 3/4] PM: domains: Drop/restore performance state votes for devices at runtime PM Ulf Hansson
2021-06-03 9:55 ` Viresh Kumar
2021-06-03 10:31 ` Ulf Hansson
2021-06-03 11:17 ` Ulf Hansson
2021-06-04 3:53 ` Viresh Kumar
2021-06-04 7:45 ` Ulf Hansson
2021-06-07 4:47 ` Viresh Kumar
2021-06-09 12:25 ` Ulf Hansson
2021-06-03 19:02 ` Dmitry Osipenko
2021-06-03 19:08 ` Dmitry Osipenko
2021-06-04 7:20 ` Ulf Hansson
2021-06-03 9:34 ` [PATCH v2 4/4] PM: domains: Drop/restore performance state votes for devices at system PM Ulf Hansson
2021-06-03 10:20 ` Ulf Hansson
2021-06-03 11:15 ` Mark Brown
2021-06-03 13:48 ` Ulf Hansson
2021-06-08 12:53 ` Stephan Gerhold
2021-06-08 14:08 ` Ulf Hansson
2021-06-08 14:20 ` Mark Brown
2021-06-08 14:39 ` Ulf Hansson
2021-06-08 15:37 ` Stephan Gerhold
2021-06-03 11:12 ` [PATCH v2 0/4] PM: domains: Avoid boilerplate code for DVFS in subsystem/drivers Stephan Gerhold
2021-06-03 15:27 ` Ulf Hansson
2021-06-03 17:14 ` Stephan Gerhold
2021-06-04 7:18 ` Ulf Hansson
2021-06-04 8:23 ` Stephan Gerhold
2021-06-04 10:57 ` Ulf Hansson
2021-06-04 11:50 ` Stephan Gerhold
2021-06-11 16:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603093438.138705-3-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=rojay@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).