From: Viresh Kumar <viresh.kumar@linaro.org>
To: Hector Yuan <hector.yuan@mediatek.com>, Sudeep.Holla@arm.com
Cc: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com
Subject: Re: [PATCH v12 1/2] cpufreq: mediatek-hw: Add support for CPUFREQ HW
Date: Mon, 28 Jun 2021 12:56:41 +0530 [thread overview]
Message-ID: <20210628072641.amqk5d3svwolvhic@vireshk-i7> (raw)
In-Reply-To: <1624781848.1958.16.camel@mtkswgap22>
On 27-06-21, 16:17, Hector Yuan wrote:
> On Mon, 2021-06-14 at 16:10 +0530, Viresh Kumar wrote:
> > On 30-05-21, 00:52, Hector Yuan wrote:
> > > +static int mtk_get_related_cpus(int index, struct cpufreq_mtk *c)
> > > +{
> > > + struct device_node *cpu_np;
> > > + struct of_phandle_args args;
> > > + int cpu, ret;
> > > +
> > > + for_each_possible_cpu(cpu) {
> > > + cpu_np = of_cpu_device_node_get(cpu);
> > > + if (!cpu_np)
> > > + continue;
> > > +
> > > + ret = of_parse_phandle_with_args(cpu_np, "performance-domains",
> > > + "#performance-domain-cells", 0,
> > > + &args);
> > > + of_node_put(cpu_np);
> > > + if (ret < 0)
> > > + continue;
> > > +
> > > + if (index == args.args[0]) {
> > > + cpumask_set_cpu(cpu, &c->related_cpus);
> > > + mtk_freq_domain_map[cpu] = c;
> > > + }
> > > + }
> > > +
> > > + return 0;
> > > +}
> >
> > I really hope this can be moved to a common place as more than one
> > drier should be required to parse this thing.
> >
>
> Yes, this can be a common part for all performance domain users. But may
> I know whats your suggestion? Put this API in another file or? Thanks
Rob, Sudeep: You guys have a suggestion on where can we keep a routine for this
?
--
viresh
next prev parent reply other threads:[~2021-06-28 7:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 16:52 [PATCH v12] cpufreq: mediatek-hw: Add support for Mediatek cpufreq HW driver Hector Yuan
2021-05-29 16:52 ` [PATCH v12 1/2] cpufreq: mediatek-hw: Add support for CPUFREQ HW Hector Yuan
2021-06-14 10:40 ` Viresh Kumar
[not found] ` <1624781848.1958.16.camel@mtkswgap22>
2021-06-28 7:26 ` Viresh Kumar [this message]
2021-06-28 9:09 ` Sudeep Holla
2021-06-29 2:47 ` Viresh Kumar
2021-06-29 9:02 ` Sudeep Holla
2021-06-29 9:05 ` Viresh Kumar
[not found] ` <1625418089.1958.48.camel@mtkswgap22>
2021-07-05 4:32 ` Viresh Kumar
2021-05-29 16:52 ` [PATCH v12 2/2] dt-bindings: cpufreq: add bindings for MediaTek cpufreq HW Hector Yuan
2021-06-02 16:58 ` Rob Herring
2021-06-27 7:56 ` Hector Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628072641.amqk5d3svwolvhic@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Sudeep.Holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=hector.yuan@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).