From: Linus Walleij <linus.walleij@linaro.org>
To: Sebastian Reichel <sre@kernel.org>,
Marcus Cooper <codekipper@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 0/2] More AB8500 charging props
Date: Tue, 23 Nov 2021 00:41:39 +0100 [thread overview]
Message-ID: <20211122234141.3356340-1-linus.walleij@linaro.org> (raw)
These two patches begin to put new stuff into the
drivers/power/supply/ab8500_bmdata.c for:
A) battery temperature look-up and interpolation, and
B) maintenance charging
Some design choices can be discussed, so I included some
HWMON etc maintainers.
NTC resistor:
For the battery NTC temperature we should note the existing NTC
driver in drivers/hwmon/ntc_thermistor.c with bindings
in Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
which is used for stand-alone NTC resistors.
It is probably possible to try to reuse the hwmon code but I
wanted to see if we have buy-in from the hwmon maintainer first.
If yes, I will try to come up with some way of representing the
NTC resistor in the device tree and use it in-tree from the
charging drivers.
Maintenance charging:
I included an infrastructure for maintenance "charging points"
which constitute of a current, a voltage and a safety timer:
struct power_supply_maintenance_charge_table {
int charge_current_max_ua;
int charge_voltage_max_uv;
int charge_safety_timer_minutes;
};
This is all pretty straight-forward if just adding maintenance
charging.
For the bigger picture, however, a charging point can also
include the existing CC/CV current and voltage and the
precharging current and voltage as two charging points,
possibly without corresponding safety timer. If this is
desired I will rework the patch to refactor the existing
currents and voltages into charging points as well.
Linus Walleij (2):
power: supply: ab8500: Standardize NTC battery temp
power: supply: ab8500: Standardize maintenance charging
drivers/power/supply/ab8500-bm.h | 30 --------
drivers/power/supply/ab8500_bmdata.c | 68 +++++++++-------
drivers/power/supply/ab8500_btemp.c | 45 +----------
drivers/power/supply/ab8500_chargalg.c | 41 +++++++---
drivers/power/supply/power_supply_core.c | 63 +++++++++++++++
include/linux/power_supply.h | 98 ++++++++++++++++++++++++
6 files changed, 237 insertions(+), 108 deletions(-)
--
2.31.1
next reply other threads:[~2021-11-22 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 23:41 Linus Walleij [this message]
2021-11-22 23:41 ` [PATCH 1/2] power: supply: ab8500: Standardize NTC battery temp Linus Walleij
2021-12-03 20:53 ` Sebastian Reichel
2021-12-06 0:33 ` Linus Walleij
2021-11-22 23:41 ` [PATCH 2/2] power: supply: ab8500: Standardize maintenance charging Linus Walleij
2021-12-03 21:02 ` Sebastian Reichel
2021-12-06 0:37 ` Linus Walleij
2021-11-23 0:23 ` [PATCH 0/2] More AB8500 charging props Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122234141.3356340-1-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=codekipper@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).