From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
rafael@kernel.org, dietmar.eggemann@arm.com
Subject: Re: [PATCH 2/3] thermal: cpufreq_cooling : Refactor thermal_power_cpu_get_power
Date: Mon, 13 Jun 2022 15:11:52 +0530 [thread overview]
Message-ID: <20220613094152.yfduve64kdp6ztxg@vireshk-i7> (raw)
In-Reply-To: <20220610100343.32378-2-lukasz.luba@arm.com>
On 10-06-22, 11:03, Lukasz Luba wrote:
> Simplify the thermal_power_cpu_get_power trace event by removing
> complicated cpumask and variable length array. Now the tools parsing trace
> output don't have to hassle to get this power data. The simplified format
> version uses 'policy->cpu'. Remove also the 'load' information completely
> since there is very little value of it in this trace event. To get the
> CPUs' load (or utilization) there are other dedicated trace hooks in the
> kernel. This patch also simplifies and speeds-up the main cooling code
> when that trace event is enabled.
>
> Rename the trace event to avoid confusion of tools which parse the trace
> file.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
> drivers/thermal/cpufreq_cooling.c | 18 +-----------------
> include/trace/events/thermal.h | 28 ++++++++--------------------
> 2 files changed, 9 insertions(+), 37 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2022-06-13 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 10:03 [PATCH 1/3] thermal: cpufreq_cooling: Use a copy of local ops for each cooling device Lukasz Luba
2022-06-10 10:03 ` [PATCH 2/3] thermal: cpufreq_cooling : Refactor thermal_power_cpu_get_power Lukasz Luba
2022-06-13 9:41 ` Viresh Kumar [this message]
2022-06-10 10:03 ` [PATCH 3/3] thermal: cpufreq_cooling: Update outdated comments Lukasz Luba
2022-06-13 9:42 ` Viresh Kumar
2022-06-13 9:16 ` [PATCH 1/3] thermal: cpufreq_cooling: Use a copy of local ops for each cooling device Viresh Kumar
2022-06-13 10:37 ` Lukasz Luba
2022-06-13 10:53 ` Viresh Kumar
2022-06-13 11:23 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613094152.yfduve64kdp6ztxg@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).