From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917CBCCA482 for ; Mon, 13 Jun 2022 19:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348499AbiFMTKt (ORCPT ); Mon, 13 Jun 2022 15:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351560AbiFMTKK (ORCPT ); Mon, 13 Jun 2022 15:10:10 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4991F30F69 for ; Mon, 13 Jun 2022 10:08:58 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso6605520pjk.0 for ; Mon, 13 Jun 2022 10:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AZWAPWwrm8+A0CgIBwRq++T65dkqg+V1CymCWTXMIwM=; b=LIOySr/baoj4EAyTjKf+aH+Qatb2p3UHDovP+gotSlTiSN1yTcg4GCjyqC3fyUX7wl npmmJtdNhVDNh5XKGkUnpjvg/YJI9/ZyQwGvcnz/SS0pPOuUekmDMJRnmbvEUG9D+H7+ BZM1DLAMJ8q+I+4MvG2IfeZzZu5Z2p2pmZvJH76I7ELfeoqXCbnsuzr33o2epyIJ5WeO vlWeMTh3YdX80pJSfJHrPWOfpq4BMQV7PRBFhgbMKMVtr4faZ0ISbwZoAbpm/guz5Lxu 3Q1Lh7nmkcWUV2iquou5G8hgE2UlhX7m7htGh4cx10X02rbX81xYSe5d64L24n5jYZOT up1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AZWAPWwrm8+A0CgIBwRq++T65dkqg+V1CymCWTXMIwM=; b=dbWRgus0WZrGyLkyRHQsIz6n16StTLsiYvyyvXazR3Do4q9JU3oZpu+YWQGUeoYh9D 65XYr+14bE7YG14MBD8d8hYUx9Q2fxS/5WG7qXKpHXmKoFJB+loJmEvlDBFw4SllF1V2 /q/8p6vqgWqzIQmh8xED6g++3osfTWI2hCuS/7PeVI8nlh/1n/qeajyVZ0t0s4z+Kr8c GKH40NbmE6+47YaNFK6nnRtyP4qjTVaq6TrgjEoEwVWGA4r1XXhGZUfuHEUu05CNBFM7 2mFGrElXn8tZM2xL5eJVJoUjzsQhoJ98EkHz3yKrhx4ugAtyPJqwrOoZKjtoey+aGZrV y1UA== X-Gm-Message-State: AJIora+B6HmO5agLGMfu2hwkPKdwaA1YZYQh/2lAxLXKKpG78sx/otwi r9pTAMUj0efWU3N6TcvwIcfCdA== X-Google-Smtp-Source: AGRyM1sELmzXAHQOaDg6BJ3FBShrRSur5yPmIKoRf1jf9G2G72yJQERR+jxqILTIiQmADcP/b1HsAg== X-Received: by 2002:a17:902:c94b:b0:166:4f65:cffb with SMTP id i11-20020a170902c94b00b001664f65cffbmr14965pla.103.1655140137656; Mon, 13 Jun 2022 10:08:57 -0700 (PDT) Received: from ash.lan ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id 142-20020a621994000000b00518b4cfbbe0sm5632766pfz.203.2022.06.13.10.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 10:08:56 -0700 (PDT) Date: Mon, 13 Jun 2022 18:08:53 +0100 From: Daniel Thompson To: ChiaEn Wu Cc: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com, lee.jones@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com, ChiaEn Wu Subject: Re: [PATCH v2 15/15] video: backlight: mt6370: Add Mediatek MT6370 support Message-ID: <20220613170853.bffuwkcmflfgg4gt@ash.lan> References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-16-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613111146.25221-16-peterwu.pub@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jun 13, 2022 at 07:11:46PM +0800, ChiaEn Wu wrote: > +static int mt6370_init_backlight_properties(struct mt6370_priv *priv, > + struct backlight_properties *props) Most of the changes in this version looks good... but it looks the new code in this function has a number of problems. See below... > +{ > + struct device *dev = priv->dev; > + u8 prop_val; > + u32 brightness; > + unsigned int mask, val; > + int ret; > + > + /* Vendor optional properties > + * if property not exist, keep value in default. > + */ That's not the right strategy for booleans. Not existing means false (e.g. flags should actively be unset). > + if (device_property_read_bool(dev, "mediatek,bled-pwm-enable")) { > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, > + MT6370_BL_PWM_EN_MASK, > + MT6370_BL_PWM_EN_MASK); > + if (ret) > + return ret; > + } As above comment... all of the boolean properties are now being read incorrectly. > + > + if (device_property_read_bool(dev, "mediatek,bled-pwm-hys-enable")) { > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, > + MT6370_BL_PWM_HYS_EN_MASK, > + MT6370_BL_PWM_HYS_EN_MASK); > + if (ret) > + return ret; > + } > + > + ret = device_property_read_u8(dev, "mediatek,bled-pwm-hys-input-bit", > + &prop_val); > + if (!ret) { > + val = min_t(u8, prop_val, 3) > + << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1); > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, > + MT6370_BL_PWM_HYS_SEL_MASK, val); > + if (ret) > + return ret; > + } > + > + ret = device_property_read_u8(dev, "mediatek,bled-ovp-microvolt", > + &prop_val); > + if (!ret) { > + val = min_t(u8, prop_val, 3) > + << (ffs(MT6370_BL_OVP_SEL_MASK) - 1); This has been renamed but still seems to the using 0, 1, 2, 3 rather than an actual value in microvolts. > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_BSTCTRL, > + MT6370_BL_OVP_SEL_MASK, val); > + if (ret) > + return ret; > + } > + > + if (device_property_read_bool(dev, "mediatek,bled-ovp-shutdown")) { > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_BSTCTRL, > + MT6370_BL_OVP_EN_MASK, > + MT6370_BL_OVP_EN_MASK); > + if (ret) > + return ret; > + } > + > + ret = device_property_read_u8(dev, "mediatek,bled-ocp-microamp", > + &prop_val); > + if (!ret) { > + val = min_t(u8, prop_val, 3) > + << (ffs(MT6370_BL_OC_SEL_MASK) - 1); Likewise, should this be accepting a value in microamps? > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_BSTCTRL, > + MT6370_BL_OC_SEL_MASK, val); > + if (ret) > + return ret; > + } > + > + if (device_property_read_bool(dev, "mediatek,bled-ocp-shutdown")) { > + ret = regmap_update_bits(priv->regmap, MT6370_REG_BL_BSTCTRL, > + MT6370_BL_OC_EN_MASK, > + MT6370_BL_OC_EN_MASK); > + if (ret) > + return ret; > + } > + > + /* Common properties */ > + ret = device_property_read_u32(dev, "max-brightness", &brightness); > + if (ret) > + brightness = MT6370_BL_MAX_BRIGHTNESS; > + > + props->max_brightness = min_t(u32, brightness, > + MT6370_BL_MAX_BRIGHTNESS); > + > + ret = device_property_read_u32(dev, "default-brightness", &brightness); > + if (ret) > + brightness = props->max_brightness; > + > + props->brightness = min_t(u32, brightness, props->max_brightness); > + > + > + ret = device_property_read_u8(dev, "mediatek,bled-channel-use", > + &prop_val); > + if (ret) { > + dev_err(dev, "mediatek,bled-channel-use DT property missing\n"); > + return ret; > + } > + > + if (!prop_val || prop_val > MT6370_BL_MAX_CH) { > + dev_err(dev, "No channel specified (ch_val:%d)\n", prop_val); Error string has not been updated to match condition that triggers it. > + return -EINVAL; > + } Daniel.