linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: [PATCHv2 05/12] power: supply: generic-adc-battery: drop jitter delay support
Date: Tue, 14 Mar 2023 23:55:28 +0100	[thread overview]
Message-ID: <20230314225535.1321736-6-sre@kernel.org> (raw)
In-Reply-To: <20230314225535.1321736-1-sre@kernel.org>

Drop support for configuring IRQ jitter delay by using big
enough fixed value.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/power/supply/generic-adc-battery.c | 13 ++++---------
 include/linux/power/generic-adc-battery.h  |  3 ---
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
index 535972a332b3..e20894460d7f 100644
--- a/drivers/power/supply/generic-adc-battery.c
+++ b/drivers/power/supply/generic-adc-battery.c
@@ -227,12 +227,10 @@ static void gab_work(struct work_struct *work)
 static irqreturn_t gab_charged(int irq, void *dev_id)
 {
 	struct gab *adc_bat = dev_id;
-	struct gab_platform_data *pdata = adc_bat->pdata;
-	int delay;
 
-	delay = pdata->jitter_delay ? pdata->jitter_delay : JITTER_DEFAULT;
 	schedule_delayed_work(&adc_bat->bat_work,
-			msecs_to_jiffies(delay));
+			      msecs_to_jiffies(JITTER_DEFAULT));
+
 	return IRQ_HANDLED;
 }
 
@@ -358,14 +356,11 @@ static int __maybe_unused gab_suspend(struct device *dev)
 static int __maybe_unused gab_resume(struct device *dev)
 {
 	struct gab *adc_bat = dev_get_drvdata(dev);
-	struct gab_platform_data *pdata = adc_bat->pdata;
-	int delay;
-
-	delay = pdata->jitter_delay ? pdata->jitter_delay : JITTER_DEFAULT;
 
 	/* Schedule timer to check current status */
 	schedule_delayed_work(&adc_bat->bat_work,
-			msecs_to_jiffies(delay));
+			      msecs_to_jiffies(JITTER_DEFAULT));
+
 	return 0;
 }
 
diff --git a/include/linux/power/generic-adc-battery.h b/include/linux/power/generic-adc-battery.h
index c68cbf34cd34..50eb4bf28286 100644
--- a/include/linux/power/generic-adc-battery.h
+++ b/include/linux/power/generic-adc-battery.h
@@ -11,13 +11,10 @@
  * @battery_info:         recommended structure to specify static power supply
  *			   parameters
  * @cal_charge:           calculate charge level.
- * @jitter_delay:         delay required after the interrupt to check battery
- *			  status.Default set is 10ms.
  */
 struct gab_platform_data {
 	struct power_supply_info battery_info;
 	int	(*cal_charge)(long value);
-	int     jitter_delay;
 };
 
 #endif /* GENERIC_ADC_BATTERY_H */
-- 
2.39.2


  parent reply	other threads:[~2023-03-14 22:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 22:55 [PATCHv2 00/12] Add DT support for generic ADC battery Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 01/12] dt-bindings: power: supply: adc-battery: add binding Sebastian Reichel
2023-03-15  5:43   ` Matti Vaittinen
2023-03-15  6:43   ` Krzysztof Kozlowski
2023-03-15  7:51   ` Linus Walleij
2023-03-14 22:55 ` [PATCHv2 02/12] power: supply: core: auto-exposure of simple-battery data Sebastian Reichel
2023-03-15  7:01   ` Matti Vaittinen
2023-03-16  0:41     ` Sebastian Reichel
2023-03-16  7:10       ` Matti Vaittinen
2023-03-16  7:13         ` Matti Vaittinen
2023-03-17 22:34         ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 03/12] power: supply: generic-adc-battery: convert to managed resources Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 04/12] power: supply: generic-adc-battery: fix unit scaling Sebastian Reichel
2023-03-14 22:55 ` Sebastian Reichel [this message]
2023-03-14 22:55 ` [PATCHv2 06/12] power: supply: generic-adc-battery: drop charge now support Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 07/12] power: supply: generic-adc-battery: drop memory alloc error message Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 08/12] power: supply: generic-adc-battery: use simple-battery API Sebastian Reichel
2023-03-16  7:38   ` Matti Vaittinen
2023-03-17 21:58     ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 09/12] power: supply: generic-adc-battery: simplify read_channel logic Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 10/12] power: supply: generic-adc-battery: add temperature support Sebastian Reichel
2023-03-15  7:04   ` Matti Vaittinen
2023-03-15  8:04   ` Linus Walleij
2023-03-15 13:08     ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 11/12] power: supply: generic-adc-battery: add DT support Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 12/12] power: supply: generic-adc-battery: update copyright info Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314225535.1321736-6-sre@kernel.org \
    --to=sre@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).