Re: [PATCH] power: supply: generic-adc-battery: remove redundant return code assignment

Re: [PATCH] power: supply: generic-adc-battery: remove redundant return code assignment

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

Hi,

On Fri, Mar 17, 2023 at 08:00:07PM +0300, Anton Gusev wrote:
> Since any subsequent uses of ret reassign it first and PTR_ERR does not
> have any effect on its own, this line has no effect and can be removed.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Anton Gusev <aagusev@ispras.ru>
> ---

Thanks, but the correct thing to do is using ret, which is WIP:

https://lore.kernel.org/linux-pm/20230314225535.1321736-4-sre@kernel.org/T/#u

-- Sebastian

>  drivers/power/supply/generic-adc-battery.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
> index 66039c665dd1..b51e5c4b36ff 100644
> --- a/drivers/power/supply/generic-adc-battery.c
> +++ b/drivers/power/supply/generic-adc-battery.c
> @@ -285,7 +285,6 @@ static int gab_probe(struct platform_device *pdev)
>  		adc_bat->channel[chan] = iio_channel_get(&pdev->dev,
>  							 gab_chan_name[chan]);
>  		if (IS_ERR(adc_bat->channel[chan])) {
> -			ret = PTR_ERR(adc_bat->channel[chan]);
>  			adc_bat->channel[chan] = NULL;
>  		} else {
>  			/* copying properties for supported channels only */
> -- 
> 2.39.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]