From: Lee Jones <lee@kernel.org>
To: "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"sre@kernel.org" <sre@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support
Date: Mon, 24 Apr 2023 09:59:42 +0100 [thread overview]
Message-ID: <20230424085942.GA8035@google.com> (raw)
In-Reply-To: <DM6PR03MB519577728975E086D8EB20F38B669@DM6PR03MB5195.namprd03.prod.outlook.com>
On Sun, 23 Apr 2023, Arslanbenzer, Zeynep wrote:
> On Thu, 30 Mar 2023, Lee Jones wrote:
>
> >On Wed, 22 Mar 2023, Zeynep Arslanbenzer wrote:
> >
> >> MFD driver for MAX77643/MAX77654/MAX77658/MAX77659 to enable its sub
> >
> >Please drop all references to 'MFD'.
> >
> >What are these devices, really? I suspect they are PMICs?
> >
> >> devices.
> >>
> >> The MAX77643 is a multi-function devices. It includes regulator.
> >>
> >> The MAX77654 is a multi-function devices. It includes regulator and
> >> charger.
> >>
> >> The MAX77658 is a multi-function devices. It includes regulator,
> >> charger and battery.
> >>
> >> The MAX77659 is a multi-function devices. It includes regulator and
> >> charger.
> >>
> >> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com>
> >> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> >> ---
> >> drivers/mfd/Kconfig | 15 ++
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/max77658.c | 448 +++++++++++++++++++++++++++++++++++
> >> include/linux/mfd/max77658.h | 88 +++++++
> >> 4 files changed, 552 insertions(+)
> >> create mode 100644 drivers/mfd/max77658.c create mode 100644
> >> include/linux/mfd/max77658.h
> >>
> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index
> >> 8b93856de432..7b4be7fb8662 100644
> >> --- a/drivers/mfd/Kconfig
> >> +++ b/drivers/mfd/Kconfig
> >> @@ -821,6 +821,21 @@ config MFD_MAX77650
> >> the following functionalities of the device: GPIO, regulator,
> >> charger, LED, onkey.
> >>
> >> +config MFD_MAX77658
> >> + tristate "Analog Devices MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support"
> >> + depends on I2C
> >> + depends on OF
> >> + select MFD_CORE
> >> + select REGMAP_I2C
> >> + select REGMAP_IRQ
> >> + help
> >> + Say Y here to add support for Analog Devices
> >> + MAX77643/MAX77654/MAX77658/MAX77659 Power Management IC.
> >
> >"MAX776xx series"?
>
> As I realized later, max77620, max77650, max77686, and max77693 drivers were merged to Linux before our patch. They are also PMIC devices and our patch does not cover them. Therefore, I think it would not be appropriate to use MAX776xx.
Perhaps you can come up with something a little more scalable then.
What if you added support for another 10 devices?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-24 9:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:56 [PATCH v2 0/8] Add MAX77643/MAX77654/MAX77658/MAX77659 PMIC Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 1/8] dt-bindings: regulator: max77658: Add ADI MAX77643/54/58/59 Regulator Zeynep Arslanbenzer
2023-03-22 8:24 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 2/8] regulator: max77658: Add ADI MAX77643/54/58/59 Regulator Support Zeynep Arslanbenzer
2023-03-22 8:25 ` Krzysztof Kozlowski
2023-05-02 6:32 ` Arslanbenzer, Zeynep
2023-05-02 6:36 ` Krzysztof Kozlowski
2023-05-04 10:36 ` Arslanbenzer, Zeynep
2023-05-04 10:45 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 3/8] dt-bindings: power: supply: max77658: Add ADI MAX77654/58/59 Charger Zeynep Arslanbenzer
2023-03-22 8:26 ` Krzysztof Kozlowski
2023-04-17 10:12 ` Arslanbenzer, Zeynep
2023-03-22 5:56 ` [PATCH v2 4/8] power: supply: max77658: Add ADI MAX77654/58/59 Charger Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery Zeynep Arslanbenzer
2023-03-22 8:30 ` Krzysztof Kozlowski
2023-05-01 20:20 ` Arslanbenzer, Zeynep
2023-05-02 6:33 ` Krzysztof Kozlowski
2023-05-02 15:05 ` Arslanbenzer, Zeynep
2023-05-02 17:13 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 6/8] power: supply: max77658: Add ADI MAX77658 Battery Support Zeynep Arslanbenzer
2023-03-22 5:56 ` [PATCH v2 7/8] dt-bindings: mfd: max77658: Add ADI MAX77658 Zeynep Arslanbenzer
2023-03-22 8:33 ` Krzysztof Kozlowski
2023-03-22 5:56 ` [PATCH v2 8/8] mfd: max77658: Add ADI MAX77643/54/58/59 MFD Support Zeynep Arslanbenzer
2023-03-30 12:31 ` Lee Jones
2023-04-17 9:44 ` Arslanbenzer, Zeynep
2023-04-23 21:16 ` Arslanbenzer, Zeynep
2023-04-24 8:59 ` Lee Jones [this message]
2023-04-25 22:03 ` Arslanbenzer, Zeynep
2023-04-26 14:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424085942.GA8035@google.com \
--to=lee@kernel.org \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).