From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: George Cherian <george.cherian@cavium.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
viresh.kumar@linaro.org
Subject: Re: [PATCH] cpufreq: cppc: Use transition_delay_us depending on the transition_latency
Date: Fri, 30 Mar 2018 12:17:03 +0200 [thread overview]
Message-ID: <2363055.ek83znc87k@aspire.rjw.lan> (raw)
In-Reply-To: <1521801031-158659-1-git-send-email-george.cherian@cavium.com>
On Friday, March 23, 2018 11:30:31 AM CEST George Cherian wrote:
> With commit e948bc8fbee0 ("cpufreq: Cap the default transition delay
> value to 10 ms") the cpufreq was not honouring the delay passed via
> ACPI (PCCT). Due to which on ARM based platforms using CPPC the cpufreq
> governor tries to change the frequency of CPU faster than expeted.
>
> This leads to continuous error messages like the following.
> " ACPI CPPC: PCC check channel failed. Status=0 "
>
> Earlier (without above commit) the default transition delay was
> taken form the value passed from PCCT. Use the same value provided by PCCT
> to set the transition_delay_us.
>
> Fixes: e948bc8fbee0 (cpufreq: Cap the default transition delay value to 10 ms)
> Signed-off-by: George Cherian <george.cherian@cavium.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index a1c3025..dcb1cb9 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -20,6 +20,7 @@
> #include <linux/cpu.h>
> #include <linux/cpufreq.h>
> #include <linux/dmi.h>
> +#include <linux/time.h>
> #include <linux/vmalloc.h>
>
> #include <asm/unaligned.h>
> @@ -162,6 +163,8 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
> policy->cpuinfo.max_freq = cppc_dmi_max_khz;
>
> policy->cpuinfo.transition_latency = cppc_get_transition_latency(cpu_num);
> + policy->transition_delay_us = cppc_get_transition_latency(cpu_num) /
> + NSEC_PER_USEC;
> policy->shared_type = cpu->shared_type;
>
> if (policy->shared_type == CPUFREQ_SHARED_TYPE_ANY)
>
Applied, thanks!
prev parent reply other threads:[~2018-03-30 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:30 [PATCH] cpufreq: cppc: Use transition_delay_us depending on the transition_latency George Cherian
2018-03-30 10:17 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2363055.ek83znc87k@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=george.cherian@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).