Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
* Re: linux-next: Tree for Jun 13 (drivers/base/power/domain.c)
       [not found] ` <00d6da06-1316-6560-5541-0caf8ea5084b@infradead.org>
@ 2019-06-13 18:27   ` Rafael J. Wysocki
  2019-06-13 20:13     ` linux-next: Tree for Jun 13 (drivers/soc/qcom/Kconfig) Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-06-13 18:27 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Linux PM list, Greg Kroah-Hartman

On Thursday, June 13, 2019 6:12:43 PM CEST Randy Dunlap wrote:
>  This is a multi-part message in MIME format.
> --------------D4992319A3EA7FFA5EF515C6
> Content-Type: text/plain; charset=windows-1252
> Content-Transfer-Encoding: 8bit
> 
> On 6/13/19 2:30 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20190612:
> > 
> 
> 
> on x86_64:
> 
> ../drivers/base/power/domain.c: In function �genpd_queue_power_off_work�:
> ../drivers/base/power/domain.c:485:13: error: �pm_wq� undeclared (first use in this function)
>   queue_work(pm_wq, &genpd->power_off_work);
>              ^
> ../drivers/base/power/domain.c:485:13: note: each undeclared identifier is reported only once for each function it appears in
> ../drivers/base/power/domain.c: In function �genpd_dev_pm_qos_notifier�:
> ../drivers/base/power/domain.c:675:25: error: �struct dev_pm_info� has no member named �ignore_children�
>    if (!dev || dev->power.ignore_children)
>                          ^
> ../drivers/base/power/domain.c: In function �rtpm_status_str�:
> ../drivers/base/power/domain.c:2754:16: error: �struct dev_pm_info� has no member named �runtime_error�
>   if (dev->power.runtime_error)
>                 ^
> ../drivers/base/power/domain.c:2756:21: error: �struct dev_pm_info� has no member named �disable_depth�
>   else if (dev->power.disable_depth)
>                      ^
> ../drivers/base/power/domain.c:2758:21: error: �struct dev_pm_info� has no member named �runtime_status�
>   else if (dev->power.runtime_status < ARRAY_SIZE(status_lookup))
>                      ^
> ../drivers/base/power/domain.c:2759:31: error: �struct dev_pm_info� has no member named �runtime_status�
>    p = status_lookup[dev->power.runtime_status];
>                                ^
> 
> 
> Full randconfig file is attached.

PM_GENERIC_DOMAINS, which is set, depend on PM, which is not set.

Looks like an impossible configuration to me.




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: Tree for Jun 13 (drivers/soc/qcom/Kconfig)
  2019-06-13 18:27   ` linux-next: Tree for Jun 13 (drivers/base/power/domain.c) Rafael J. Wysocki
@ 2019-06-13 20:13     ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2019-06-13 20:13 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Linux PM list, Greg Kroah-Hartman,
	bjorn.andersson

On 6/13/19 11:27 AM, Rafael J. Wysocki wrote:
> On Thursday, June 13, 2019 6:12:43 PM CEST Randy Dunlap wrote:
>>  This is a multi-part message in MIME format.
>> --------------D4992319A3EA7FFA5EF515C6
>> Content-Type: text/plain; charset=windows-1252
>> Content-Transfer-Encoding: 8bit
>>
>> On 6/13/19 2:30 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20190612:
>>>
>>
>>
>> on x86_64:
>>
>> ../drivers/base/power/domain.c: In function �genpd_queue_power_off_work�:
>> ../drivers/base/power/domain.c:485:13: error: �pm_wq� undeclared (first use in this function)
>>   queue_work(pm_wq, &genpd->power_off_work);
>>              ^
>> ../drivers/base/power/domain.c:485:13: note: each undeclared identifier is reported only once for each function it appears in
>> ../drivers/base/power/domain.c: In function �genpd_dev_pm_qos_notifier�:
>> ../drivers/base/power/domain.c:675:25: error: �struct dev_pm_info� has no member named �ignore_children�
>>    if (!dev || dev->power.ignore_children)
>>                          ^
>> ../drivers/base/power/domain.c: In function �rtpm_status_str�:
>> ../drivers/base/power/domain.c:2754:16: error: �struct dev_pm_info� has no member named �runtime_error�
>>   if (dev->power.runtime_error)
>>                 ^
>> ../drivers/base/power/domain.c:2756:21: error: �struct dev_pm_info� has no member named �disable_depth�
>>   else if (dev->power.disable_depth)
>>                      ^
>> ../drivers/base/power/domain.c:2758:21: error: �struct dev_pm_info� has no member named �runtime_status�
>>   else if (dev->power.runtime_status < ARRAY_SIZE(status_lookup))
>>                      ^
>> ../drivers/base/power/domain.c:2759:31: error: �struct dev_pm_info� has no member named �runtime_status�
>>    p = status_lookup[dev->power.runtime_status];
>>                                ^
>>
>>
>> Full randconfig file is attached.
> 
> PM_GENERIC_DOMAINS, which is set, depend on PM, which is not set.

Thanks for that.  (I changed the subject to indicate the errant entity.)

> Looks like an impossible configuration to me.

It's what happens when a driver selects PM_GENERIC_DOMAINS when PM is not set/enabled.

From drivers/soc/qcom/Kconfig:

config QCOM_AOSS_QMP
	tristate "Qualcomm AOSS Driver"
	depends on ARCH_QCOM || COMPILE_TEST
	depends on MAILBOX
	depends on COMMON_CLK
	select PM_GENERIC_DOMAINS

In my test case, COMPILE_TEST=y.  ARCH_QCOM is not set.

And kconfig does warn:

WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS
  Depends on [n]: PM [=n]
  Selected by [m]:
  - QCOM_AOSS_QMP [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && MAILBOX [=y] && COMMON_CLK [=y]


Who is responsible for that Kconfig segment?
Ah, Bjorn.  Cc-ed.

-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190613193054.37bde7fa@canb.auug.org.au>
     [not found] ` <00d6da06-1316-6560-5541-0caf8ea5084b@infradead.org>
2019-06-13 18:27   ` linux-next: Tree for Jun 13 (drivers/base/power/domain.c) Rafael J. Wysocki
2019-06-13 20:13     ` linux-next: Tree for Jun 13 (drivers/soc/qcom/Kconfig) Randy Dunlap

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org linux-pm@archiver.kernel.org
	public-inbox-index linux-pm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox