From: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>
To: "Randy Dunlap" <rdunlap@infradead.org>, 郭力豪 <lhjeff911@gmail.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"amitk@kernel.org" <amitk@kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus
Date: Wed, 29 Jun 2022 03:31:48 +0000 [thread overview]
Message-ID: <254b6c711c9a464cb23d1eb5957a6af9@sphcmbx01.sunplus.com.tw> (raw)
In-Reply-To: <395072af-3349-cead-fe07-62d3d758d635@infradead.org>
I'm sorry for the wrong indentation problem, it was caused by a wrong setting in the mail server.I will fix it in the next patch.
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Friday, June 10, 2022 11:20 AM
> To: 郭力豪 <lhjeff911@gmail.com>; krzk@kernel.org; rafael@kernel.org; Daniel Lezcano
> <daniel.lezcano@linaro.org>; amitk@kernel.org; rui.zhang@intel.com; robh+dt@kernel.org;
> linux-pm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Lh Kuo 郭力豪 <lh.Kuo@sunplus.com>; Wells Lu 呂芳騰 <wells.lu@sunplus.com>
> Subject: Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus
>
> Hi--
>
> On 6/9/22 18:32, 郭力豪 wrote:
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > 0e5cc94..c85e668 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
> > If you say yes here you get support for the FAN controlled
> > by the Microcontroller found on the Khadas VIM boards.
> >
> > +config SUNPLUS_THERMAL
> > + tristate "Sunplus thermal drivers"
> > + depends on SOC_SP7021 || COMPILE_TEST help
> > + This enable the Sunplus SP7021 thermal driver, which supports the primitive
> > + temperature sensor embedded in Sunplus SP7021 SoC.
> > +
> > + If you have a Sunplus SP7021 platform say Y here and enable this option
> > + to have support for thermal management
>
> End the sentence above with a period ('.').
>
> And the indentation here is all messed up.
> See Documentation/process/coding-style.rst:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat
> different. Lines under a ``config`` definition are indented with one tab, while help text is indented an
> additional two spaces.
>
>
> > +
> > endif
>
> --
> ~Randy
prev parent reply other threads:[~2022-06-29 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 1:32 [PATCH v9 1/2] thermal: Add thermal driver for Sunplus 郭力豪
2022-06-10 3:19 ` Randy Dunlap
2022-06-10 10:30 ` Krzysztof Kozlowski
2022-06-29 3:31 ` Lh Kuo 郭力豪
2022-06-29 3:31 ` Lh Kuo 郭力豪 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254b6c711c9a464cb23d1eb5957a6af9@sphcmbx01.sunplus.com.tw \
--to=lh.kuo@sunplus.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).