* [PATCH] PM / QOS: correct the valid range of pm_qos_class
@ 2013-06-12 5:53 kpark3469
2013-06-12 11:16 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: kpark3469 @ 2013-06-12 5:53 UTC (permalink / raw)
To: linux-pm; +Cc: keun-o.park, len.brown, rjw
From: Sahara <keun-o.park@windriver.com>
The valid start index for pm_qos_array is not 0 but 1. There is a
null_pm_qos at index 0 of pm_qos_array. However, null_pm_qos is not
created as misc device so that inclusion of 0 index for checking
pm_qos_class especially for file operations is not proper here.
Signed-off-by: Sahara <keun-o.park@windriver.com>
---
kernel/power/qos.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 587ddde..ec6f0a7 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -477,7 +477,7 @@ static int find_pm_qos_object_by_minor(int minor)
{
int pm_qos_class;
- for (pm_qos_class = 0;
+ for (pm_qos_class = 1;
pm_qos_class < PM_QOS_NUM_CLASSES; pm_qos_class++) {
if (minor ==
pm_qos_array[pm_qos_class]->pm_qos_power_miscdev.minor)
@@ -491,7 +491,7 @@ static int pm_qos_power_open(struct inode *inode, struct file *filp)
long pm_qos_class;
pm_qos_class = find_pm_qos_object_by_minor(iminor(inode));
- if (pm_qos_class >= 0) {
+ if (pm_qos_class >= 1) {
struct pm_qos_request *req = kzalloc(sizeof(*req), GFP_KERNEL);
if (!req)
return -ENOMEM;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / QOS: correct the valid range of pm_qos_class
2013-06-12 5:53 [PATCH] PM / QOS: correct the valid range of pm_qos_class kpark3469
@ 2013-06-12 11:16 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-06-12 11:16 UTC (permalink / raw)
To: kpark3469; +Cc: linux-pm, keun-o.park, len.brown
On Wednesday, June 12, 2013 02:53:15 PM kpark3469@gmail.com wrote:
> From: Sahara <keun-o.park@windriver.com>
>
> The valid start index for pm_qos_array is not 0 but 1. There is a
> null_pm_qos at index 0 of pm_qos_array. However, null_pm_qos is not
> created as misc device so that inclusion of 0 index for checking
> pm_qos_class especially for file operations is not proper here.
>
> Signed-off-by: Sahara <keun-o.park@windriver.com>
> ---
> kernel/power/qos.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index 587ddde..ec6f0a7 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -477,7 +477,7 @@ static int find_pm_qos_object_by_minor(int minor)
> {
> int pm_qos_class;
>
> - for (pm_qos_class = 0;
> + for (pm_qos_class = 1;
While you're at it, can you please use PM_QOS_CPU_DMA_LATENCY instead of 1
here and below?
Rafael
> pm_qos_class < PM_QOS_NUM_CLASSES; pm_qos_class++) {
> if (minor ==
> pm_qos_array[pm_qos_class]->pm_qos_power_miscdev.minor)
> @@ -491,7 +491,7 @@ static int pm_qos_power_open(struct inode *inode, struct file *filp)
> long pm_qos_class;
>
> pm_qos_class = find_pm_qos_object_by_minor(iminor(inode));
> - if (pm_qos_class >= 0) {
> + if (pm_qos_class >= 1) {
> struct pm_qos_request *req = kzalloc(sizeof(*req), GFP_KERNEL);
> if (!req)
> return -ENOMEM;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / QOS: correct the valid range of pm_qos_class
2013-06-13 2:31 kpark3469
@ 2013-07-09 13:29 ` mark gross
0 siblings, 0 replies; 4+ messages in thread
From: mark gross @ 2013-07-09 13:29 UTC (permalink / raw)
To: kpark3469; +Cc: linux-pm, keun-o.park, len.brown, rjw
On Thu, Jun 13, 2013 at 11:31:57AM +0900, kpark3469@gmail.com wrote:
> From: Sahara <keun-o.park@windriver.com>
>
> The valid start index for pm_qos_array is not 0 but 1. There is a
> null_pm_qos at index 0 of pm_qos_array. However, null_pm_qos is not
> created as misc device so that inclusion of 0 index for checking
> pm_qos_class especially for file operations is not proper here.
>
> Signed-off-by: Sahara <keun-o.park@windriver.com>
> ---
> kernel/power/qos.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index 587ddde..f2f5f6e 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -477,7 +477,7 @@ static int find_pm_qos_object_by_minor(int minor)
> {
> int pm_qos_class;
>
> - for (pm_qos_class = 0;
> + for (pm_qos_class = PM_QOS_CPU_DMA_LATENCY;
why not: for (pm_qos_class = PM_QOS_RESERVED + 1;?
I don't like assigning symantics implying DMA_LATENCY is the first qos class.
This is implicitly assuming an order I don't think is proper to assume.
humph. this has already been merged. My gripe is WRT style anyway.
surves me right for not paying attention. I'll post an stylistic tweak later.
--mark
> pm_qos_class < PM_QOS_NUM_CLASSES; pm_qos_class++) {
> if (minor ==
> pm_qos_array[pm_qos_class]->pm_qos_power_miscdev.minor)
> @@ -491,7 +491,7 @@ static int pm_qos_power_open(struct inode *inode, struct file *filp)
> long pm_qos_class;
>
> pm_qos_class = find_pm_qos_object_by_minor(iminor(inode));
> - if (pm_qos_class >= 0) {
> + if (pm_qos_class >= PM_QOS_CPU_DMA_LATENCY) {
> struct pm_qos_request *req = kzalloc(sizeof(*req), GFP_KERNEL);
> if (!req)
> return -ENOMEM;
> @@ -584,7 +584,7 @@ static int __init pm_qos_power_init(void)
>
> BUILD_BUG_ON(ARRAY_SIZE(pm_qos_array) != PM_QOS_NUM_CLASSES);
>
> - for (i = 1; i < PM_QOS_NUM_CLASSES; i++) {
> + for (i = PM_QOS_CPU_DMA_LATENCY; i < PM_QOS_NUM_CLASSES; i++) {
> ret = register_pm_qos_misc(pm_qos_array[i]);
> if (ret < 0) {
> printk(KERN_ERR "pm_qos_param: %s setup failed\n",
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PM / QOS: correct the valid range of pm_qos_class
@ 2013-06-13 2:31 kpark3469
2013-07-09 13:29 ` mark gross
0 siblings, 1 reply; 4+ messages in thread
From: kpark3469 @ 2013-06-13 2:31 UTC (permalink / raw)
To: linux-pm; +Cc: keun-o.park, len.brown, rjw
From: Sahara <keun-o.park@windriver.com>
The valid start index for pm_qos_array is not 0 but 1. There is a
null_pm_qos at index 0 of pm_qos_array. However, null_pm_qos is not
created as misc device so that inclusion of 0 index for checking
pm_qos_class especially for file operations is not proper here.
Signed-off-by: Sahara <keun-o.park@windriver.com>
---
kernel/power/qos.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 587ddde..f2f5f6e 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -477,7 +477,7 @@ static int find_pm_qos_object_by_minor(int minor)
{
int pm_qos_class;
- for (pm_qos_class = 0;
+ for (pm_qos_class = PM_QOS_CPU_DMA_LATENCY;
pm_qos_class < PM_QOS_NUM_CLASSES; pm_qos_class++) {
if (minor ==
pm_qos_array[pm_qos_class]->pm_qos_power_miscdev.minor)
@@ -491,7 +491,7 @@ static int pm_qos_power_open(struct inode *inode, struct file *filp)
long pm_qos_class;
pm_qos_class = find_pm_qos_object_by_minor(iminor(inode));
- if (pm_qos_class >= 0) {
+ if (pm_qos_class >= PM_QOS_CPU_DMA_LATENCY) {
struct pm_qos_request *req = kzalloc(sizeof(*req), GFP_KERNEL);
if (!req)
return -ENOMEM;
@@ -584,7 +584,7 @@ static int __init pm_qos_power_init(void)
BUILD_BUG_ON(ARRAY_SIZE(pm_qos_array) != PM_QOS_NUM_CLASSES);
- for (i = 1; i < PM_QOS_NUM_CLASSES; i++) {
+ for (i = PM_QOS_CPU_DMA_LATENCY; i < PM_QOS_NUM_CLASSES; i++) {
ret = register_pm_qos_misc(pm_qos_array[i]);
if (ret < 0) {
printk(KERN_ERR "pm_qos_param: %s setup failed\n",
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-09 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-12 5:53 [PATCH] PM / QOS: correct the valid range of pm_qos_class kpark3469
2013-06-12 11:16 ` Rafael J. Wysocki
2013-06-13 2:31 kpark3469
2013-07-09 13:29 ` mark gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).