Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] tools/power turbostat: Add Ice Lake NNPI support
@ 2019-06-14  7:39 Rajneesh Bhardwaj
  2019-06-14  7:39 ` [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver Rajneesh Bhardwaj
  0 siblings, 1 reply; 7+ messages in thread
From: Rajneesh Bhardwaj @ 2019-06-14  7:39 UTC (permalink / raw)
  To: rjw, linux-kernel
  Cc: len.brown, rafael.j.wysocki, Rajneesh Bhardwaj, Len Brown, Linux PM

This enables turbostat utility on Ice Lake NNPI SoC.

Cc: Len Brown <lenb@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>
Link: https://lkml.org/lkml/2019/6/5/1034
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index c7727be9719f..d225cd373966 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -4594,6 +4594,7 @@ unsigned int intel_model_duplicates(unsigned int model)
 		return INTEL_FAM6_SKYLAKE_MOBILE;
 
 	case INTEL_FAM6_ICELAKE_MOBILE:
+	case INTEL_FAM6_ICELAKE_NNPI:
 		return INTEL_FAM6_CANNONLAKE_MOBILE;
 	}
 	return model;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
  2019-06-14  7:39 [PATCH 1/2] tools/power turbostat: Add Ice Lake NNPI support Rajneesh Bhardwaj
@ 2019-06-14  7:39 ` Rajneesh Bhardwaj
  2019-06-14  7:49   ` Bhardwaj, Rajneesh
  0 siblings, 1 reply; 7+ messages in thread
From: Rajneesh Bhardwaj @ 2019-06-14  7:39 UTC (permalink / raw)
  To: rjw, linux-kernel
  Cc: len.brown, rafael.j.wysocki, Rajneesh Bhardwaj, linux-pm

Enables support for ICL-NNPI, neural network processor for deep learning
inference. From RAPL point of view it is same as Ice Lake Mobile
processor.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org
Link: https://lkml.org/lkml/2019/6/5/1034
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
---
 drivers/powercap/intel_rapl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index 4347f15165f8..19d470c73b6e 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1156,7 +1156,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
 	INTEL_CPU_FAM6(KABYLAKE_MOBILE,		rapl_defaults_core),
 	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
 	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
-	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
+	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
 
 	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
 	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
  2019-06-14  7:39 ` [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver Rajneesh Bhardwaj
@ 2019-06-14  7:49   ` Bhardwaj, Rajneesh
  0 siblings, 0 replies; 7+ messages in thread
From: Bhardwaj, Rajneesh @ 2019-06-14  7:49 UTC (permalink / raw)
  To: rjw, linux-kernel; +Cc: len.brown, rafael.j.wysocki, linux-pm

Hi Rafael

On 14-Jun-19 1:09 PM, Rajneesh Bhardwaj wrote:
> Enables support for ICL-NNPI, neural network processor for deep learning
> inference. From RAPL point of view it is same as Ice Lake Mobile
> processor.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: linux-pm@vger.kernel.org
> Link: https://lkml.org/lkml/2019/6/5/1034
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> ---
>   drivers/powercap/intel_rapl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index 4347f15165f8..19d470c73b6e 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1156,7 +1156,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
>   	INTEL_CPU_FAM6(KABYLAKE_MOBILE,		rapl_defaults_core),
>   	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
>   	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
> -	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
> +	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),

Sorry, i sent the wrong patch, please ignore this one. I will send 
another one.

Thanks.

>   	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
>   	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
  2019-06-28  8:21   ` Bhardwaj, Rajneesh
@ 2019-07-05 10:13     ` Rafael J. Wysocki
  0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2019-07-05 10:13 UTC (permalink / raw)
  To: Bhardwaj, Rajneesh; +Cc: linux-kernel, len.brown, rafael.j.wysocki, linux-pm

On Friday, June 28, 2019 10:21:41 AM CEST Bhardwaj, Rajneesh wrote:
> 
> On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote:
> > On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote:
> >> Enables support for ICL-NNPI, which is a neural network processor for deep
> >> learning inference. From RAPL point of view it is same as Ice Lake Mobile
> >> processor.
> >>
> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> >> Cc: linux-pm@vger.kernel.org
> >> Link: https://lkml.org/lkml/2019/6/5/1034
> >> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> >> ---
> >>   drivers/powercap/intel_rapl.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> >> index 4347f15165f8..431c8c8bdf07 100644
> >> --- a/drivers/powercap/intel_rapl.c
> >> +++ b/drivers/powercap/intel_rapl.c
> >> @@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
> >>   	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
> >>   	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
> >>   	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
> >> +	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
> >>   
> >>   	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
> >>   	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
> >>
> > It is in my queue, but I get build errors when I try to apply it.
> >
> > I guess the definition of ICELAKE_NNPI is not there in the Linus' tree yet.
> 
> Yes, though 
> https://www.spinics.net/lists/linux-tip-commits/msg48978.html is 
> accepted by Thomas already.

It is not in 5.2-rc7, though, AFAICS.

The patch is still in my queue and waiting.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
  2019-06-27 22:02 ` Rafael J. Wysocki
@ 2019-06-28  8:21   ` Bhardwaj, Rajneesh
  2019-07-05 10:13     ` Rafael J. Wysocki
  0 siblings, 1 reply; 7+ messages in thread
From: Bhardwaj, Rajneesh @ 2019-06-28  8:21 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-kernel, len.brown, rafael.j.wysocki, linux-pm


On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote:
> On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote:
>> Enables support for ICL-NNPI, which is a neural network processor for deep
>> learning inference. From RAPL point of view it is same as Ice Lake Mobile
>> processor.
>>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Cc: linux-pm@vger.kernel.org
>> Link: https://lkml.org/lkml/2019/6/5/1034
>> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>> ---
>>   drivers/powercap/intel_rapl.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
>> index 4347f15165f8..431c8c8bdf07 100644
>> --- a/drivers/powercap/intel_rapl.c
>> +++ b/drivers/powercap/intel_rapl.c
>> @@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
>>   	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
>>   	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
>>   	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
>> +	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
>>   
>>   	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
>>   	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
>>
> It is in my queue, but I get build errors when I try to apply it.
>
> I guess the definition of ICELAKE_NNPI is not there in the Linus' tree yet.

Yes, though 
https://www.spinics.net/lists/linux-tip-commits/msg48978.html is 
accepted by Thomas already.


>
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
  2019-06-14  8:05 Rajneesh Bhardwaj
@ 2019-06-27 22:02 ` Rafael J. Wysocki
  2019-06-28  8:21   ` Bhardwaj, Rajneesh
  0 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2019-06-27 22:02 UTC (permalink / raw)
  To: Rajneesh Bhardwaj; +Cc: linux-kernel, len.brown, rafael.j.wysocki, linux-pm

On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote:
> Enables support for ICL-NNPI, which is a neural network processor for deep
> learning inference. From RAPL point of view it is same as Ice Lake Mobile
> processor.
> 
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: linux-pm@vger.kernel.org
> Link: https://lkml.org/lkml/2019/6/5/1034
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> ---
>  drivers/powercap/intel_rapl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index 4347f15165f8..431c8c8bdf07 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
>  	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
>  	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
>  	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
> +	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
>  
>  	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
>  	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
> 

It is in my queue, but I get build errors when I try to apply it.

I guess the definition of ICELAKE_NNPI is not there in the Linus' tree yet.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
@ 2019-06-14  8:05 Rajneesh Bhardwaj
  2019-06-27 22:02 ` Rafael J. Wysocki
  0 siblings, 1 reply; 7+ messages in thread
From: Rajneesh Bhardwaj @ 2019-06-14  8:05 UTC (permalink / raw)
  To: rjw, linux-kernel
  Cc: len.brown, rafael.j.wysocki, Rajneesh Bhardwaj, linux-pm

Enables support for ICL-NNPI, which is a neural network processor for deep
learning inference. From RAPL point of view it is same as Ice Lake Mobile
processor.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org
Link: https://lkml.org/lkml/2019/6/5/1034
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
---
 drivers/powercap/intel_rapl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index 4347f15165f8..431c8c8bdf07 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
 	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
 	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
 	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
+	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
 
 	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
 	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14  7:39 [PATCH 1/2] tools/power turbostat: Add Ice Lake NNPI support Rajneesh Bhardwaj
2019-06-14  7:39 ` [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver Rajneesh Bhardwaj
2019-06-14  7:49   ` Bhardwaj, Rajneesh
2019-06-14  8:05 Rajneesh Bhardwaj
2019-06-27 22:02 ` Rafael J. Wysocki
2019-06-28  8:21   ` Bhardwaj, Rajneesh
2019-07-05 10:13     ` Rafael J. Wysocki

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org linux-pm@archiver.kernel.org
	public-inbox-index linux-pm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox