From: shuah <shuah@kernel.org>
To: Abhishek Goel <huntbag@linux.vnet.ibm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: trenn@suse.com, shuah <shuah@kernel.org>
Subject: Re: [PATCH] cpupower : Handle set and info subcommands for powerpc
Date: Wed, 11 Sep 2019 04:11:21 -0600 [thread overview]
Message-ID: <3326dc53-f8a1-dd7b-5ae8-b86ef5ef8b24@kernel.org> (raw)
In-Reply-To: <20190911095424.49605-1-huntbag@linux.vnet.ibm.com>
On 9/11/19 3:54 AM, Abhishek Goel wrote:
> Cpupower tool has set and info options which are not being used by
> POWER machines. For powerpc, we will return directly for these two
> subcommands. This removes the ambiguous error message while using set
> option in case of power systems.
What is the error message you see? Please include it in the commit log.
>
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> ---
> tools/power/cpupower/utils/cpupower-info.c | 5 +++++
> tools/power/cpupower/utils/cpupower-set.c | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/tools/power/cpupower/utils/cpupower-info.c b/tools/power/cpupower/utils/cpupower-info.c
> index 4c9d342b70ff..674b707a76af 100644
> --- a/tools/power/cpupower/utils/cpupower-info.c
> +++ b/tools/power/cpupower/utils/cpupower-info.c
> @@ -39,6 +39,11 @@ int cmd_info(int argc, char **argv)
> } params = {};
> int ret = 0;
>
> + #ifdef __powerpc__
> + printf(_("Cannot read info as system does not support performance bias setting\n"));
> + return 0;
> + #endif
> +
I am not in favor of bailing out this early with this ifdef switch.
I would rather see this checked somehow(?) when the ambiguous error
happens.
> setlocale(LC_ALL, "");
> textdomain(PACKAGE);
>
> diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> index 3cd95c6cb974..c95b29278780 100644
> --- a/tools/power/cpupower/utils/cpupower-set.c
> +++ b/tools/power/cpupower/utils/cpupower-set.c
> @@ -41,6 +41,11 @@ int cmd_set(int argc, char **argv)
> int perf_bias = 0;
> int ret = 0;
>
> + #ifdef __powerpc__
> + printf(_("System does not support performance bias setting\n"));
> + return 0;
> + #endif
> +
Same here.
> setlocale(LC_ALL, "");
> textdomain(PACKAGE);
>
>
thanks,
-- Shuah
next parent reply other threads:[~2019-09-11 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190911095424.49605-1-huntbag@linux.vnet.ibm.com>
2019-09-11 10:11 ` shuah [this message]
2019-09-12 9:43 ` [PATCH] cpupower : Handle set and info subcommands for powerpc Abhishek
2019-09-12 10:16 ` Thomas Renninger
2019-09-12 10:23 ` Abhishek
2019-09-12 9:54 ` Thomas Renninger
2019-09-12 10:19 ` Abhishek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3326dc53-f8a1-dd7b-5ae8-b86ef5ef8b24@kernel.org \
--to=shuah@kernel.org \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).