From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B08C433E2 for ; Tue, 8 Sep 2020 20:54:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1752C2145D for ; Tue, 8 Sep 2020 20:54:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QhUQEaQe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728572AbgIHUy2 (ORCPT ); Tue, 8 Sep 2020 16:54:28 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:55778 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgIHUy2 (ORCPT ); Tue, 8 Sep 2020 16:54:28 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 088KsQs8107270; Tue, 8 Sep 2020 15:54:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599598466; bh=E+9QQ1DscF13tPkWOq65brrJgmxAQwKmqNygQNuWZ/c=; h=Subject:To:References:From:Date:In-Reply-To; b=QhUQEaQePJl8Cw2nDK49nFeiH2sQmJRJL4lMhm/bobWMHZin3GbNtTSNn3UCTr2gf oliyLXD0KvuR/ezNitAOkL3A3rCcirmlDvTSm8N774Kj86AnkREdYs7Lc+dowb7ttp T+G24QFvgx+npn0ViuUI6PB0ThbsRHQpn7GUB3cY= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 088KsQND031826 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Sep 2020 15:54:26 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 8 Sep 2020 15:54:26 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 8 Sep 2020 15:54:26 -0500 Received: from [10.250.38.37] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 088KsQmm046976; Tue, 8 Sep 2020 15:54:26 -0500 Subject: Re: [PATCH 2/7] power: supply: bq27xxx: report "not charging" on all types To: Krzysztof Kozlowski , Sebastian Reichel , Rob Herring , =?UTF-8?Q?Pali_Roh=c3=a1r?= , , , References: <20200908201319.3567-1-krzk@kernel.org> <20200908201319.3567-2-krzk@kernel.org> From: Dan Murphy Message-ID: <33361ba9-51df-3b09-6744-9806cdf166db@ti.com> Date: Tue, 8 Sep 2020 15:54:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908201319.3567-2-krzk@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Krzysztof On 9/8/20 3:13 PM, Krzysztof Kozlowski wrote: > Commit 6f24ff97e323 ("power: supply: bq27xxx_battery: Add the > BQ27Z561 Battery monitor") and commit d74534c27775 ("power: > bq27xxx_battery: Add support for additional bq27xxx family devices") > added support for new device types by copying most of the code and > adding necessary quirks. > > However they did not copy the code in bq27xxx_battery_status() > responsible for returning POWER_SUPPLY_STATUS_NOT_CHARGING. > > Unify the bq27xxx_battery_status() so for all types when charger is > supplied, it will return "not charging" status. If this is a fix then please populate the Fixes tag. But not sure how both commits are tied here Dan