From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
Tomasz Figa <tfiga@chromium.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
srv_heupstream@mediatek.com,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks
Date: Fri, 22 May 2020 13:15:12 +0200 [thread overview]
Message-ID: <34736047-3fc8-385b-cdea-79b061deb7b4@samsung.com> (raw)
In-Reply-To: <20200522101327.13456-1-m.szyprowski@samsung.com>
Hi All,
On 22.05.2020 12:13, Marek Szyprowski wrote:
> Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in
> adapter") added generic suspend and resume functions for i2c devices.
> Those functions unconditionally access an i2c_client structure assigned
> to the given i2c device. However, there exist i2c devices in the system
> without a valid i2c_client. Add the needed check before accessing the
> i2c_client.
Just one more comment. The devices without i2c_client structure are the
i2c 'devices' associated with the respective i2c bus. They are visible
in /sys:
ls -l /sys/bus/i2c/devices/i2c-*
I wonder if this patch has been ever tested with system suspend/resume,
as those devices are always available in the system...
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-05-22 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200522101524eucas1p1aeef4a054a80b5d822ed3dc4b16139d7@eucas1p1.samsung.com>
2020-05-22 10:13 ` [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks Marek Szyprowski
2020-05-22 11:15 ` Marek Szyprowski [this message]
2020-05-22 14:20 ` Wolfram Sang
2020-05-25 12:28 ` Tomasz Figa
2020-05-25 12:43 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34736047-3fc8-385b-cdea-79b061deb7b4@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=bibby.hsieh@mediatek.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).