From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>,
Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: <sre@kernel.org>, <pali@kernel.org>, <afd@ti.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <sspatil@android.com>
Subject: Re: [PATCH v13 2/4] dt-bindings: power: Convert battery.txt to battery.yaml
Date: Tue, 30 Jun 2020 07:12:16 -0500 [thread overview]
Message-ID: <371c96ae-09b1-4d1b-14b0-f9628b922ce5@ti.com> (raw)
In-Reply-To: <20200629225630.GA3114703@bogus>
Rob
On 6/29/20 5:56 PM, Rob Herring wrote:
> On Mon, Jun 22, 2020 at 02:18:35PM -0500, Ricardo Rivera-Matos wrote:
>> From: Dan Murphy<dmurphy@ti.com>
>>
>> Convert the battery.txt file to yaml and fix up the examples.
>>
>> Signed-off-by: Dan Murphy<dmurphy@ti.com>
>> ---
>> .../bindings/power/supply/battery.txt | 83 +----------
>> .../bindings/power/supply/battery.yaml | 139 ++++++++++++++++++
>> 2 files changed, 141 insertions(+), 81 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/power/supply/battery.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt
>> index 5e29595edd74..4c5216fcb760 100644
>> --- a/Documentation/devicetree/bindings/power/supply/battery.txt
>> +++ b/Documentation/devicetree/bindings/power/supply/battery.txt
>> @@ -1,87 +1,8 @@
>> -Battery Characteristics
>> -
>> -The devicetree battery node provides static battery characteristics.
>> -In smart batteries, these are typically stored in non-volatile memory
>> -on a fuel gauge chip. The battery node should be used where there is
>> -no appropriate non-volatile memory, or it is unprogrammed/incorrect.
>> -
>> -Upstream dts files should not include battery nodes, unless the battery
>> -represented cannot easily be replaced in the system by one of a
>> -different type. This prevents unpredictable, potentially harmful,
>> -behavior should a replacement that changes the battery type occur
>> -without a corresponding update to the dtb.
>> +The contents of this file has been moved to battery.yaml
>>
>> Please note that not all charger drivers respect all of the properties.
>>
>> -Required Properties:
>> - - compatible: Must be "simple-battery"
>> -
>> -Optional Properties:
>> - over-voltage-threshold-microvolt: battery over-voltage limit
>> - re-charge-voltage-microvolt: limit to automatically start charging again
> Why are some things not moved?
These were applied recently to the text file on May 8th. They just
showed up in the 5.8 kernel.
Not sure if there are any more pending changes for the battery.txt but
they should be on hold until the yaml is applied.
We will update the yaml
Dan
next prev parent reply other threads:[~2020-06-30 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 19:18 [PATCH v13 0/4] Add JEITA properties and introduce the bq2515x charger Ricardo Rivera-Matos
2020-06-22 19:18 ` [PATCH v13 1/4] power_supply: Add additional health properties to the header Ricardo Rivera-Matos
2020-06-22 19:18 ` [PATCH v13 2/4] dt-bindings: power: Convert battery.txt to battery.yaml Ricardo Rivera-Matos
2020-06-29 22:56 ` Rob Herring
2020-06-30 12:12 ` Dan Murphy [this message]
2020-06-22 19:18 ` [PATCH v13 3/4] dt-bindings: power: Add the bindings for the bq2515x family of chargers Ricardo Rivera-Matos
2020-06-29 22:57 ` Rob Herring
2020-06-22 19:18 ` [PATCH v13 4/4] power: supply: bq25150 introduce the bq25150 Ricardo Rivera-Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=371c96ae-09b1-4d1b-14b0-f9628b922ce5@ti.com \
--to=dmurphy@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=sspatil@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).