From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95278C433E1 for ; Wed, 26 Aug 2020 16:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79F572078B for ; Wed, 26 Aug 2020 16:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgHZQxA (ORCPT ); Wed, 26 Aug 2020 12:53:00 -0400 Received: from mga01.intel.com ([192.55.52.88]:8075 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbgHZQw6 (ORCPT ); Wed, 26 Aug 2020 12:52:58 -0400 IronPort-SDR: kukMBqYf7ya60bqwi5Z8Q61ahgOHiI53jnyEKXD/DhVOoJNixLt5jRfusB1HrPzAoEJjYZBbPp fhE/5ocEZ6Mw== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="174383946" X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="174383946" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 09:52:57 -0700 IronPort-SDR: Npc9IP5GJnDHn3tW7dPtZlA7CcT6572KfKtlCH/xLBwxlDLiErCqnJYoij4YqNtKHAawJOKpk+ ueTtmAjdNZ+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="299538165" Received: from linux.intel.com ([10.54.29.200]) by orsmga006.jf.intel.com with ESMTP; 26 Aug 2020 09:52:55 -0700 Received: from abityuts-desk1.fi.intel.com (abityuts-desk1.fi.intel.com [10.237.72.186]) by linux.intel.com (Postfix) with ESMTP id AC9E25805ED; Wed, 26 Aug 2020 09:52:53 -0700 (PDT) Message-ID: <39d26cecd7e911c6527e05fbe5049b13a5d53788.camel@gmail.com> Subject: Re: [PATCH] intel_idle: Add ICL support From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: "Rafael J. Wysocki" Cc: Guilhem Lettron , Zhang Rui , Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Date: Wed, 26 Aug 2020 19:52:52 +0300 In-Reply-To: References: <20200826120421.44356-1-guilhem@barpilot.io> <8fa7622dacc03f2fbd67e810f53389e3ede544e8.camel@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 2020-08-26 at 18:43 +0200, Rafael J. Wysocki wrote: > > I am curious, somehow that patch makes a difference. > > It does make a difference, because it makes the processor spend more > time in PC2. Which very well may be because the processor cannot > enter deeper C-states. OK, you are right, we do not indeed have PC10 in both cases. The file was wrapped and I unwrapped it incorrectly. So indeed this is the real problem to solve, and the patch does not solve it.