From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [GIT PULL] Thermal management updates for v4.17-rc1 Date: Fri, 13 Apr 2018 12:30:04 +0200 Message-ID: <3b41052a-233d-9992-223a-d16f48295905@linaro.org> References: <1523436077.16235.5.camel@intel.com> <3546651.LUmDXQgY88@amdc3058> <16cbc915-ad89-7bab-c644-8086cfef082f@linaro.org> <4212243.RcCUWlsaar@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <4212243.RcCUWlsaar@amdc3058> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Zhang Rui , Eduardo Valentin , Linus Torvalds , LKML , Linux PM list , "Li, Philip" List-Id: linux-pm@vger.kernel.org On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: [ ... ] >>> It is okay to return 0 because this code-path (the default one) will be >>> never hit by the driver (probe makes sure of it) - the default case is >>> here is just to silence compilation errors.. >> >> The init function is making sure cal_type is one or another. Can you fix >> it correctly by replacing the 'switch' by a 'if' instead of adding dead >> branches to please gcc? >> >> if (data->cal_type == TYPE_TWO_POINT_TRIMMING) { >> return ...; >> } >> >> return ...; > > I'm not the one that added this switch statement (it has been there since > 2011) and I would be happy to remove it. Actually the switch statement was fine until the cleanup. > However could we please defer > this to v4.17 and merge the current set of Exynos thermal fixes/cleanups > (they simplify the driver a lot and make ground for future changes)? Regarding the latest comment, this can be fixed properly by 'return' (or whatever you want which does not get around of gcc warnings). -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog