From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Antoine Tenart <atenart@kernel.org>,
rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 0/2] thermal: int340x: fix tcc offset on resume
Date: Thu, 09 Sep 2021 02:35:20 -0700 [thread overview]
Message-ID: <3cb749ed8cd7dba9b7757a83e8b5ac871c5855f2.camel@linux.intel.com> (raw)
In-Reply-To: <20210909085613.5577-1-atenart@kernel.org>
On Thu, 2021-09-09 at 10:56 +0200, Antoine Tenart wrote:
> Hi,
>
> This is a follow-up of [1]. As discussed in the initial thread, the fix
> is now split into two commits: the two commits combined are fixing the
> issue in a nice way for 5.15, but only the first one is meant to be
> applied on stable kernels (to avoid conflicts).
>
> The issue this is fixing is described in patch 1. Tl;dr: a
> suspend/resume cycle can end-up in setting a wrong tcc offset value,
> which can lead to machines shutting down because of overheating (when
> they should not).
>
> I've stripped the Acked-by/Tested-by flags from v1 as the patch was
> split. But the end result for 5.15+ kernels should be the same.
>
> Thanks,
> Antoine
>
> [1]
> https://lore.kernel.org/linux-pm/20210908161632.15520-1-atenart@kernel.org/T/
>
> Antoine Tenart (2):
> thermal: int340x: do not set a wrong tcc offset on resume
> thermal: int340x: improve the tcc offset saving for suspend/resume
>
> .../intel/int340x_thermal/int3401_thermal.c | 8 +++-
> .../processor_thermal_device.c | 39 ++++++++++++++-----
> .../processor_thermal_device.h | 1 +
> .../processor_thermal_device_pci.c | 18 ++++++++-
> .../processor_thermal_device_pci_legacy.c | 8 +++-
> 5 files changed, 62 insertions(+), 12 deletions(-)
>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tested-by: Srinivas Pandruvada <srinivas.pI andruvada@linux.intel.com>
next prev parent reply other threads:[~2021-09-09 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 8:56 [PATCH v2 0/2] thermal: int340x: fix tcc offset on resume Antoine Tenart
2021-09-09 8:56 ` [PATCH v2 1/2] thermal: int340x: do not set a wrong " Antoine Tenart
2021-09-24 16:27 ` Srinivas Pandruvada
2021-09-24 17:40 ` Daniel Lezcano
2021-09-24 17:51 ` Srinivas Pandruvada
2021-10-20 13:38 ` Antoine Tenart
2021-10-21 9:47 ` Daniel Lezcano
2021-10-21 10:02 ` Antoine Tenart
2021-09-09 8:56 ` [PATCH v2 2/2] thermal: int340x: improve the tcc offset saving for suspend/resume Antoine Tenart
2021-09-09 9:35 ` Srinivas Pandruvada [this message]
2021-09-17 7:56 ` [PATCH v2 0/2] thermal: int340x: fix tcc offset on resume Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb749ed8cd7dba9b7757a83e8b5ac871c5855f2.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=amitk@kernel.org \
--cc=atenart@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).