Re: [PATCH v5 0/8] Add support for mp2733 battery charger

From: saravanan sekar <sravanhome@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	lee.jones@linaro.org, linux-iio@vger.kernel.org,
	jic23@kernel.org, sre@kernel.org, andy.shevchenko@gmail.com,
	lars@metafoo.de, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org
Subject: Re: [PATCH v5 0/8] Add support for mp2733 battery charger
Date: Fri, 4 Nov 2022 08:13:57 +0100	[thread overview]
Message-ID: <3e1b8549-0961-697b-63b8-db6b37d53c6b@gmail.com> (raw)
In-Reply-To: <8ba915b1-be77-f78e-87b0-9a00c8387084@linaro.org>

On 04/11/22 02:54, Krzysztof Kozlowski wrote:
> On 29/10/2022 05:29, Saravanan Sekar wrote:
>> changes in v5:
>>    - fixed commit message on v5-0002 and v5-0004
>>
>> changes in v4:
>>    - fixed attributes groups review comments in v3
>>    - added new bug fix patches v4-0007 and v4-0008
>>
>> changes in v3:
>>    - fixed dt_binding_check error
>>    - fixed spelling usb->USB
>>
>> changes in v2:
>>    - fixed spelling
>>    - revert back probe to probe_new in mfd driver
>>
>> I do not see a cover letter, but FWIW,
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> This does not belong to the cover letter. Please add respective tags to
> patches, where applicable. If Andy gave Rb tag for entire patchset, add
> it to the patches.
>

Hello Krzysztof,

These are v1 comments from Andy to me, all of them are addressed and I 
kept in cover letter for history

>> for all patches except DT binding
>> Note, some of the comments regarding spelling were given, I believe
>> you are going to address them in v3.
> 
> ...and this comment is from who? Andy?
> 
>>
>>
>> add support for mp2733 Battery charger control driver for Monolithic
>> Power System's MP2733 chipset
>>
>> Saravanan Sekar (8):
>>    iio: adc: mp2629: fix wrong comparison of channel
>>    mfd: mp2629: fix failed to get iio channel by device name
>>    iio: adc: mp2629: fix potential array out of bound access
>>    power: supply: fix wrong interpretation of register value
>>    mfd: mp2629: Add support for mps mp2733 battery charger
>>    iio: adc: mp2629: restrict input voltage mask for mp2629
>>    power: supply: Add support for mp2733 battery charger
>>    power: supply: mp2629: Add USB fast charge settings
>>
>>   .../ABI/testing/sysfs-class-power-mp2629      |  16 ++
>>   drivers/iio/adc/mp2629_adc.c                  |   8 +-
>>   drivers/mfd/mp2629.c                          |   7 +-
>>   drivers/power/supply/mp2629_charger.c         | 229 +++++++++++++++---
>>   include/linux/mfd/mp2629.h                    |   6 +
> 
> Why do you Cc DT maintainers?
>

This patch series includes DT bindings documentation which has already 
merged by 15Jun2022.

https://lore.kernel.org/all/20220615145357.2370044-3-sravanhome@gmail.com/

>>   5 files changed, 228 insertions(+), 38 deletions(-)
>>
> 
> Best regards,
> Krzysztof
> 

Thanks,
Saravanan