From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73894C433DF for ; Wed, 1 Jul 2020 12:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 529D620760 for ; Wed, 1 Jul 2020 12:13:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E42DMvK0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730539AbgGAMN4 (ORCPT ); Wed, 1 Jul 2020 08:13:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730271AbgGAMN4 (ORCPT ); Wed, 1 Jul 2020 08:13:56 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E972C061755 for ; Wed, 1 Jul 2020 05:13:56 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a6so18116243wmm.0 for ; Wed, 01 Jul 2020 05:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=36Rdlv4HCit+buU+nGQUelnhzD705QsSVBz4bAQcgV8=; b=E42DMvK0MtHtwtKuxE7/3asHCY49FrguUSRXvkfkXjKnKX4Eyf+hYX5dgc0SWicUqx RqSA2xg6/fXG4hIQ1FY1xZZJuDd3xmI79vH6Cy7lZBFCbg9C1ApTL7lOaOgloNSJDBZC rC2BT7oTMRHnRJhFaaCdaAtuPA6c5KGmBJF839PegAKb99lKV7BL9CyHS5m89s+ilEFd SJqUO5ce97PI+u4b8siqd1UAA0uB5F7B9nExRUHWvb7K4z4A0dPscp9yK/r+4RoHZEb+ cEG3xw+GXQoyG3TtQC10rV/8BInK01Rtg9iLESDyX0jMDKG0B6yqpaR5DRhC1rKUIWsO ndww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=36Rdlv4HCit+buU+nGQUelnhzD705QsSVBz4bAQcgV8=; b=HMKqSS43Wm8syoHBl+kyi3ezqt21HINjOvFtlwwRc84AniNNYaQSTAXxEk1ZlY/BjZ TYwLgbS8AruL4XKHGM9rpVct1ZO+N495sKXIxriebVMvPnStQpucnt7xCrrL/SchkGG5 H7Pfy9qbnZs2xFQxzpKhu+VEMqtKmqBwMTRX9pCqfyRvMMtvWCJKT8Dutt6Rat5vya5X mIZ2vi0o/Xa04+zrM3jzrDYVuZLi/DOoTuAE6h4MguLCJzLQhhRfOL6xUykaJmyuHFjQ AqIJGQXUB+3gRVMEgplAFZY1Ukx1fV/0y3Qe/j/5LIpgfXNyoDRNJTqOkJ8Mq1hih93q izbg== X-Gm-Message-State: AOAM532qYhJXbcUmKzKQ/AIgTUeNn6lNM4ml0zrvF29t7GsSuaQ8Ol0+ 10ewM2GNTquum0qsupr0LDQkyQ== X-Google-Smtp-Source: ABdhPJwsIgwqaWKXArfWPW61iIeQQD1yndav5I/DH52zb3ks7tfaJ/qsFv9EM/powgfPjuEu9sFcYQ== X-Received: by 2002:a7b:ca52:: with SMTP id m18mr26079690wml.92.1593605634644; Wed, 01 Jul 2020 05:13:54 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:54f4:a99f:ab88:bc07? ([2a01:e34:ed2f:f020:54f4:a99f:ab88:bc07]) by smtp.googlemail.com with ESMTPSA id x11sm6660826wmc.26.2020.07.01.05.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 05:13:53 -0700 (PDT) Subject: Re: [PATCH v2 3/5] thermal: core: Remove old uapi generic netlink To: Amit Kucheria , Linux PM list Cc: Zhang Rui , Srinivas Pandruvada , Ram Chandrasekar , Linux Kernel Mailing List References: <20200625144509.17918-1-daniel.lezcano@linaro.org> <20200625144509.17918-3-daniel.lezcano@linaro.org> <0fe6837f-9b44-4578-23f2-3e4932d01122@linaro.org> From: Daniel Lezcano Message-ID: <3fa94347-8392-5324-da0a-91ff97f6ecfc@linaro.org> Date: Wed, 1 Jul 2020 14:13:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 01/07/2020 14:10, Amit Kucheria wrote: > On Wed, Jul 1, 2020 at 3:15 PM Daniel Lezcano wrote: >> >> On 01/07/2020 11:33, Amit Kucheria wrote: >>> On Wed, Jul 1, 2020 at 2:56 PM Daniel Lezcano wrote: >>>> >>>> On 30/06/2020 13:47, Amit Kucheria wrote: >>>>> On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano >>>>> wrote: >>>>>> > >>>>>> /* Adding event notification support elements */ >>>>>> #define THERMAL_GENL_FAMILY_NAME "thermal_event" >>>>>> -#define THERMAL_GENL_VERSION 0x01 >>>>>> +#define THERMAL_GENL_VERSION 0x02 >>>>> >>>>> This hunk should be removed since you set version back to 1 in the >>>>> next patch and we don't actually intend to bump the version yet. >>>> >>>> Well, I've been very strict here for git-bisecting. >>>> >>>> I move to V2 because of the removal, but when adding the new genetlink >>>> code, the family name changed, so we returned back to the V1 as it is a >>>> new genetlink thermal brand. >>> >>> I don't understand the move to v2 for an empty skeleton UAPI. For the >>> purposes of bisection, couldn't you just remove all the v1 UAPI (w/o >>> bumping to v2) and then add a new UAPI in the next patch? >>> >>>> The name is change because it is no longer event based but also sampling >>>> and commands. >>> >>> In this case, just to avoid any confusion, the new UAPI could be v2 >>> making the transition clear in case of bisection. >>> >>> I'm afraid the v1->v2->v1 is a bit more confusing. >> >> Let me elaborate a bit: >> >> Why there is this patch ? >> - By removing this code first, the next patch will just contain >> additions, I thought it would be clearer >> >> Why increase the version here ? >> - Code must continue to compile and as the 'thermal_event' family is now >> different from V1, the version is changed >> >> Why the version goes to V1 in the next patch ? >> - The family name is changed as it is not doing event only, so it is a >> new netlink thermal protocol and we begin at V1 >> >> So the main reason of this patch is to be very strict in the iteration >> changes. May be it is too much, in this case I can merge this patch with >> 4/5, the old netlink protocol removal will be lost in the addition of >> the new protocol. I'm fine with that if you think it is simpler. > > Considering that there are no users of v1 currently, it feels a bit > over engineered, IMHO. > > Also, the new UAPI doesn't need to begin at v1. Just having it start > at v2 will avoid this confusion, no? Ok, I will merge both patches but I will keep the V1 because the netlink protocol is a new one. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog