From: Thomas Renninger <trenn@suse.de>
To: Abhishek <huntbag@linux.vnet.ibm.com>
Cc: shuah <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
Thomas Renninger <trenn@suse.com>
Subject: Re: [PATCH] cpupower : Handle set and info subcommands for powerpc
Date: Thu, 12 Sep 2019 12:16:41 +0200 [thread overview]
Message-ID: <4161437.KdBApSEpf3@skinner.arch.suse.de> (raw)
In-Reply-To: <f43715dd-219b-d3ae-58a9-f343fe745d7d@linux.vnet.ibm.com>
On Thursday, September 12, 2019 11:43:40 AM CEST Abhishek wrote:
> Hi Shuah,
>
> Thanks for the review. Few comments below.
...
> Since these two options are not being used by any other architecture
> except x86, I suggest these options should not even be shown for
> other architecture. So we can do something like this in cpupower.c :
>
> static struct cmd_struct commands[] = {
> .............
> +#if defined (__x86_64__) || defined (__i386__)
> { "set", cmd_set, 1 },
> { "info", cmd_info, 0 },
> +#endif
> ..............
>
> Is this Okay?
No, I expected you to add something meaningful for Power case...
Just kidding. If this works without any side-effects in not x86 case, this
approach seem to be the best solution for now.
Thanks.
Thomas
next prev parent reply other threads:[~2019-09-12 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190911095424.49605-1-huntbag@linux.vnet.ibm.com>
2019-09-11 10:11 ` [PATCH] cpupower : Handle set and info subcommands for powerpc shuah
2019-09-12 9:43 ` Abhishek
2019-09-12 10:16 ` Thomas Renninger [this message]
2019-09-12 10:23 ` Abhishek
2019-09-12 9:54 ` Thomas Renninger
2019-09-12 10:19 ` Abhishek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4161437.KdBApSEpf3@skinner.arch.suse.de \
--to=trenn@suse.de \
--cc=ego@linux.vnet.ibm.com \
--cc=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).