From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958ABC31E40 for ; Mon, 12 Aug 2019 08:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59E642070C for ; Mon, 12 Aug 2019 08:59:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KxsZjLOH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727165AbfHLI7I (ORCPT ); Mon, 12 Aug 2019 04:59:08 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33541 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727154AbfHLI7I (ORCPT ); Mon, 12 Aug 2019 04:59:08 -0400 Received: by mail-wm1-f65.google.com with SMTP id p77so10394350wme.0 for ; Mon, 12 Aug 2019 01:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LQahR6/PicrquWkTB7keQum+C1FaoNXa+P9sb4J2ZDE=; b=KxsZjLOH6D4gpn8GcEvUCBzh4ZZLbjr14Xx6/Z1j8tdfCbO3pS0NcodVS+6v/tQKgZ ePBNE+9jl7BoqqavEfiGt0CLUaJZ2fK53VNRR8CxVd6cof5qhs08QoB0PSlSyIU0k4rs IsCF7HTZszYC0vx4FvGLbqRz6bMop/g6d8xUApx3u9XSVVEahMlAq1hSaRChuYvQhwXl Qxq2l+J4hswU3G3OQvPj/7mqvTd2tzPieZ1tS9ewcorWiyaZaWFO3WlgxpNJVJVMXdN/ ccL9zy7ZS6mUhxSRMiYTB3WH0DUe4IW0ZsulOSehSTerZwY5AL3xzh8r2Ui7YYhQ6MHW kigw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LQahR6/PicrquWkTB7keQum+C1FaoNXa+P9sb4J2ZDE=; b=LlfBCXrCx1nW1NM/SchGiGvBq7cNfrNwykBTeI4UTOeyNVnZZ9uf3npk5Qlyem62cC Q8YqHelIWnhuiHM29cly/MfNL/+Wj8ge7A8zRbmrYZFshgbKZDaFSVaOEtZQq1zctawv ZS7Cl0CProBnOsFCwfM4t6xFddeWAGurfYSFjEonm/iuBdWKtlgXNix+IxDJc6P+jlqI n96zxuqAoRm4kTwXjZH9C5bw1WpqqyBc/ciSXa9xib+KBoNyW9QiTe19Mm2SauT4nvkT Th2ru+XXWGl05ER8CMvghQ4kmhC2tB++etUbj53m40Bo0QIbWpsDr2DHp2eG31hQNlG/ wECA== X-Gm-Message-State: APjAAAXFPw+0kC6ZOtjjJOKRhQNVr7ZhiuCZA9OLVcYyvnWbqS+aLH8+ 6CkkMRVsOKkiXiONDTAOtmVnht41Kzc= X-Google-Smtp-Source: APXvYqykZFgxw1EWhxCXfjOtlAgA6y3mTZcO7z06ab0MRLL9KApwxRONDxoEeeyPIY/RdRn2APm+Zw== X-Received: by 2002:a1c:ed06:: with SMTP id l6mr18467490wmh.128.1565600344836; Mon, 12 Aug 2019 01:59:04 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:48cc:ae99:b746:39d8? ([2a01:e34:ed2f:f020:48cc:ae99:b746:39d8]) by smtp.googlemail.com with ESMTPSA id c187sm31179408wmd.39.2019.08.12.01.59.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 01:59:04 -0700 (PDT) Subject: Re: [PATCH 1/2] cpuidle: play_idle: Increase the resolution to usec From: Daniel Lezcano To: rafael@kernel.org Cc: linux-pm@vger.kernel.org References: <20190802173424.5844-1-daniel.lezcano@linaro.org> Openpgp: preference=signencrypt Autocrypt: addr=daniel.lezcano@linaro.org; prefer-encrypt=mutual; keydata= mQINBFv/yykBEADDdW8RZu7iZILSf3zxq5y8YdaeyZjI/MaqgnvG/c3WjFaunoTMspeusiFE sXvtg3ehTOoyD0oFjKkHaia1Zpa1m/gnNdT/WvTveLfGA1gH+yGes2Sr53Ht8hWYZFYMZc8V 2pbSKh8wepq4g8r5YI1XUy9YbcTdj5mVrTklyGWA49NOeJz2QbfytMT3DJmk40LqwK6CCSU0 9Ed8n0a+vevmQoRZJEd3Y1qXn2XHys0F6OHCC+VLENqNNZXdZE9E+b3FFW0lk49oLTzLRNIq 0wHeR1H54RffhLQAor2+4kSSu8mW5qB0n5Eb/zXJZZ/bRiXmT8kNg85UdYhvf03ZAsp3qxcr xMfMsC7m3+ADOtW90rNNLZnRvjhsYNrGIKH8Ub0UKXFXibHbafSuq7RqyRQzt01Ud8CAtq+w P9EftUysLtovGpLSpGDO5zQ++4ZGVygdYFr318aGDqCljKAKZ9hYgRimPBToDedho1S1uE6F 6YiBFnI3ry9+/KUnEP6L8Sfezwy7fp2JUNkUr41QF76nz43tl7oersrLxHzj2dYfWUAZWXva wW4IKF5sOPFMMgxoOJovSWqwh1b7hqI+nDlD3mmVMd20VyE9W7AgTIsvDxWUnMPvww5iExlY eIC0Wj9K4UqSYBOHcUPrVOKTcsBVPQA6SAMJlt82/v5l4J0pSQARAQABtCpEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz6JAlcEEwEIAEECGwEFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4ACGQEWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXAkeagUJDRnjhwAK CRCP9LjScWdVJ+vYEACStDg7is2JdE7xz1PFu7jnrlOzoITfw05BurgJMqlvoiFYt9tEeUMl zdU2+r0cevsmepqSUVuUvXztN8HA/Ep2vccmWnCXzlE56X1AK7PRRdaQd1SK/eVsJVaKbQTr ii0wjbs6AU1uo0LdLINLjwwItnQ83/ttbf1LheyN8yknlch7jn6H6J2A/ORZECTfJbG4ecVr 7AEm4A/G5nyPO4BG7dMKtjQ+crl/pSSuxV+JTDuoEWUO+YOClg6azjv8Onm0cQ46x9JRtahw YmXdIXD6NsJHmMG9bKmVI0I7o5Q4XL52X6QxkeMi8+VhvqXXIkIZeizZe5XLTYUvFHLdexzX Xze0LwLpmMObFLifjziJQsLP2lWwOfg6ZiH8z8eQJFB8bYTSMqmfTulB61YO0mhd676q17Y7 Z7u3md3CLH7rh61wU1g7FcLm9p5tXXWWaAud9Aa2kne2O3sirO0+JhsKbItz3d9yXuWgv6w3 heOIF0b91JyrY6tjz42hvyjxtHywRr4cdAEQa2S7HeQkw48BQOG6PqQ9d3FYU34pt3WFJ19V A5qqAiEjqc4N0uPkC79W32yLGdyg0EEe8v0Uhs3CxM9euGg37kr5fujMm+akMtR1ENITo+UI fgsxdwjBD5lNb/UGodU4QvPipB/xx4zz7pS5+2jGimfLeoe7mgGJxrkBDQRb/8z6AQgAvSkg 5w7dVCSbpP6nXc+i8OBz59aq8kuL3YpxT9RXE/y45IFUVuSc2kuUj683rEEgyD7XCf4QKzOw +XgnJcKFQiACpYAowhF/XNkMPQFspPNM1ChnIL5KWJdTp0DhW+WBeCnyCQ2pzeCzQlS/qfs3 dMLzzm9qCDrrDh/aEegMMZFO+reIgPZnInAcbHj3xUhz8p2dkExRMTnLry8XXkiMu9WpchHy XXWYxXbMnHkSRuT00lUfZAkYpMP7La2UudC/Uw9WqGuAQzTqhvE1kSQe0e11Uc+PqceLRHA2 bq/wz0cGriUrcCrnkzRmzYLoGXQHqRuZazMZn2/pSIMZdDxLbwARAQABiQI2BBgBCAAgFiEE JNYm8lO+nofmzlv0j/S40nFnVScFAlv/zPoCGwwACgkQj/S40nFnVSf4OhAAhWJPjgUu6VfS mV53AUGIyqpOynPvSaMoGJzhNsDeNUDfV5dEZN8K4qjuz2CTNvGIyt4DE/IJbtasvi5dW4wW Fl85bF6xeLM0qpCaZtXAsU5gzp3uT7ut++nTPYW+CpfYIlIpyOIzVAmw7rZbfgsId2Lj7g1w QCjvGHw19mq85/wiEiZZNHeJQ3GuAr/uMoiaRBnf6wVcdpUTFMXlkE8/tYHPWbW0YKcKFwJ3 uIsNxZUe6coNzYnL0d9GK2fkDoqKfKbFjNhW9TygfeL2Qhk949jMGQudFS3zlwvN9wwVaC0i KC/D303DiTnB0WFPT8CltMAZSbQ1WEWfwqxhY26di3k9pj+X3BfOmDL9GBlnRTSgwjqjqzpG VZsWouuTfXd9ZPPzvYdUBrlTKgojk1C8v4fhSqb+ard+bZcwNp8Tzl/EI9ygw6lYEATGCUYI Wco+fjehCgG1FWvWavMU+jLNs8/8uwj1u+BtRpWFj4ug/VaDDIuiApKPwl1Ge+zoC7TLMtyb c00W5/8EckjmNgLDIINEsOsidMH61ZOlwDKCxo2lbV+Ij078KHBIY76zuHlwonEQaHLCAdqm WiI95pYZNruAJEqZCpvXDdClmBVMZRDRePzSljCvoHxn7ArEt3F14mabn2RRq/hqB8IhC6ny xAEPQIZaxxginIFYEziOjR65AQ0EW//NCAEIALcJqSmQdkt04vIBD12dryF6WcVWYvVwhspt RlZbZ/NZ6nzarzEYPFcXaYOZCOCv+Xtm6hB8fh5XHd7Y8CWuZNDVp3ozuqwTkzQuux/aVdNb Fe4VNeKGN2FK1aNlguAXJNCDNRCpWgRHuU3rWwGUMgentJogARvxfex2/RV/5mzYG/N1DJKt F7g1zEcQD3JtK6WOwZXd+NDyke3tdG7vsNRFjMDkV4046bOOh1BKbWYu8nL3UtWBxhWKx3Pu 1VOBUVwL2MJKW6umk+WqUNgYc2bjelgcTSdz4A6ZhJxstUO4IUfjvYRjoqle+dQcx1u+mmCn 8EdKJlbAoR4NUFZy7WUAEQEAAYkDbAQYAQgAIBYhBCTWJvJTvp6H5s5b9I/0uNJxZ1UnBQJb /80IAhsCAUAJEI/0uNJxZ1UnwHQgBBkBCAAdFiEEGn3N4YVz0WNVyHskqDIjiipP6E8FAlv/ zQgACgkQqDIjiipP6E+FuggAl6lkO7BhTkrRbFhrcjCm0bEoYWnCkQtX9YFvElQeA7MhxznO BY/r1q2Uf6Ifr3YGEkLnME/tQQzUwznydM94CtRJ8KDSa1CxOseEsKq6B38xJtjgYSxNdgQb EIfCzUHIGfk94AFKPdV6pqqSU5VpPUagF+JxiAkoEPOdFiQCULFNRLMsOtG7yp8uSyJRp6Tz cQ+0+1QyX1krcHBUlNlvfdmL9DM+umPtbS9F6oRph15mvKVYiPObI1z8ymHoc68ReWjhUuHc IDQs4w9rJVAyLypQ0p+ySDcTc+AmPP6PGUayIHYX63Q0KhJFgpr1wH0pHKpC78DPtX1a7HGM 7MqzQ4NbD/4oLKKwByrIp12wLpSe3gDQPxLpfGgsJs6BBuAGVdkrdfIx2e6ENnwDoF0Veeji BGrVmjVgLUWV9nUP92zpyByzd8HkRSPNZNlisU4gnz1tKhQl+j6G/l2lDYsqKeRG55TXbu9M LqJYccPJ85B0PXcy63fL9U5DTysmxKQ5RgaxcxIZCM528ULFQs3dfEx5euWTWnnh7pN30RLg a+0AjSGd886Bh0kT1Dznrite0dzYlTHlacbITZG84yRk/gS7DkYQdjL8zgFr/pxH5CbYJDk0 tYUhisTESeesbvWSPO5uNqqy1dAFw+dqRcF5gXIh3NKX0gqiAA87NM7nL5ym/CNpJ7z7nRC8 qePOXubgouxumi5RQs1+crBmCDa/AyJHKdG2mqCt9fx5EPbDpw6Zzx7hgURh4ikHoS7/tLjK iqWjuat8/HWc01yEd8rtkGuUcMqbCi1XhcAmkaOnX8FYscMRoyyMrWClRZEQRokqZIj79+PR adkDXtr4MeL8BaB7Ij2oyRVjXUwhFQNKi5Z5Rve0a3zvGkkqw8Mz20BOksjSWjAF6g9byukl CUVjC03PdMSufNLK06x5hPc/c4tFR4J9cLrV+XxdCX7r0zGos9SzTPGNuIk1LK++S3EJhLFj 4eoWtNhMWc1uiTf9ENza0ntqH9XBWEQ6IA1gubCniGG+Xg== Message-ID: <4512ae04-e9a5-f0aa-2e6f-bf7a17b069e4@linaro.org> Date: Mon, 12 Aug 2019 10:59:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190802173424.5844-1-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Rafael, Can you consider these two patches for merging. There is no functional changes. On 02/08/2019 19:34, Daniel Lezcano wrote: > The play_idle resolution is 1ms. The intel_powerclamp bases the idle > duration on jiffies. The idle injection API is also using msec based > duration but has no user yet. > > Unfortunately, msec based time does not fit well when we want to > inject idle cycle precisely with shallow idle state. > > In order to set the scene for the incoming idle injection user, move > the precision up to usec when calling play_idle. > > Signed-off-by: Daniel Lezcano > --- > drivers/powercap/idle_inject.c | 2 +- > drivers/thermal/intel/intel_powerclamp.c | 2 +- > include/linux/cpu.h | 2 +- > kernel/sched/idle.c | 7 ++++--- > 4 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c > index 24ff2a068978..10601f4bdf72 100644 > --- a/drivers/powercap/idle_inject.c > +++ b/drivers/powercap/idle_inject.c > @@ -138,7 +138,7 @@ static void idle_inject_fn(unsigned int cpu) > */ > iit->should_run = 0; > > - play_idle(READ_ONCE(ii_dev->idle_duration_ms)); > + play_idle(READ_ONCE(ii_dev->idle_duration_ms) * USEC_PER_MSEC); > } > > /** > diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c > index 5149a817456b..53216dcbe173 100644 > --- a/drivers/thermal/intel/intel_powerclamp.c > +++ b/drivers/thermal/intel/intel_powerclamp.c > @@ -430,7 +430,7 @@ static void clamp_idle_injection_func(struct kthread_work *work) > if (should_skip) > goto balance; > > - play_idle(jiffies_to_msecs(w_data->duration_jiffies)); > + play_idle(jiffies_to_usecs(w_data->duration_jiffies)); > > balance: > if (clamping && w_data->clamping && cpu_online(w_data->cpu)) > diff --git a/include/linux/cpu.h b/include/linux/cpu.h > index fcb1386bb0d4..88dc0c653925 100644 > --- a/include/linux/cpu.h > +++ b/include/linux/cpu.h > @@ -179,7 +179,7 @@ void arch_cpu_idle_dead(void); > int cpu_report_state(int cpu); > int cpu_check_up_prepare(int cpu); > void cpu_set_state_online(int cpu); > -void play_idle(unsigned long duration_ms); > +void play_idle(unsigned long duration_us); > > #ifdef CONFIG_HOTPLUG_CPU > bool cpu_wait_death(unsigned int cpu, int seconds); > diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c > index 80940939b733..b98283fc6914 100644 > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -311,7 +311,7 @@ static enum hrtimer_restart idle_inject_timer_fn(struct hrtimer *timer) > return HRTIMER_NORESTART; > } > > -void play_idle(unsigned long duration_ms) > +void play_idle(unsigned long duration_us) > { > struct idle_timer it; > > @@ -323,7 +323,7 @@ void play_idle(unsigned long duration_ms) > WARN_ON_ONCE(current->nr_cpus_allowed != 1); > WARN_ON_ONCE(!(current->flags & PF_KTHREAD)); > WARN_ON_ONCE(!(current->flags & PF_NO_SETAFFINITY)); > - WARN_ON_ONCE(!duration_ms); > + WARN_ON_ONCE(!duration_us); > > rcu_sleep_check(); > preempt_disable(); > @@ -333,7 +333,8 @@ void play_idle(unsigned long duration_ms) > it.done = 0; > hrtimer_init_on_stack(&it.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); > it.timer.function = idle_inject_timer_fn; > - hrtimer_start(&it.timer, ms_to_ktime(duration_ms), HRTIMER_MODE_REL_PINNED); > + hrtimer_start(&it.timer, ns_to_ktime(duration_us * NSEC_PER_USEC), > + HRTIMER_MODE_REL_PINNED); > > while (!READ_ONCE(it.done)) > do_idle(); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog