From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Mario Limonciello <mario.limonciello@dell.com>,
Anthony Wong <anthony.wong@canonical.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] Commit "ACPI: PM: Allow transitions to D0 to occur in special cases"
Date: Thu, 01 Aug 2019 00:20:49 +0200 [thread overview]
Message-ID: <4787259.M8qLqd86a7@kreacher> (raw)
In-Reply-To: <578BD3F1-B185-471B-A3EB-FF71BA34B822@canonical.com>
On Wednesday, July 31, 2019 6:04:29 PM CEST Kai-Heng Feng wrote:
> Hi,
>
> After commit "ACPI: PM: Allow transitions to D0 to occur in special cases”,
> Thunderbolt on XPS 9380 spews the following when it runtime resumes:
> [ 36.136554] pci_raw_set_power_state: 25 callbacks suppressed
> [ 36.136558] pcieport 0000:03:00.0: Refused to change power state,
> currently in D3
> [ 36.143850] pcieport 0000:04:04.0: Refused to change power state,
> currently in D3
> [ 36.150796] pcieport 0000:04:00.0: Refused to change power state,
> currently in D3
> [ 36.157138] pcieport 0000:04:01.0: Refused to change power state,
> currently in D3
> [ 36.162635] pcieport 0000:04:02.0: Refused to change power state,
> currently in D3
Thanks for identifying the offending commit and sorry for the breakage.
The patch below should fix it.
---
drivers/acpi/device_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-pm/drivers/acpi/device_pm.c
===================================================================
--- linux-pm.orig/drivers/acpi/device_pm.c
+++ linux-pm/drivers/acpi/device_pm.c
@@ -236,13 +236,15 @@ int acpi_device_set_power(struct acpi_de
if (device->power.flags.power_resources)
result = acpi_power_transition(device, target_state);
} else {
+ int cur_state = device->power.state;
+
if (device->power.flags.power_resources) {
result = acpi_power_transition(device, ACPI_STATE_D0);
if (result)
goto end;
}
- if (device->power.state == ACPI_STATE_D0) {
+ if (cur_state == ACPI_STATE_D0) {
int psc;
/* Nothing to do here if _PSC is not present. */
prev parent reply other threads:[~2019-07-31 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:04 [Regression] Commit "ACPI: PM: Allow transitions to D0 to occur in special cases" Kai-Heng Feng
2019-07-31 16:12 ` Mario.Limonciello
2019-07-31 21:30 ` Bjorn Helgaas
2019-07-31 22:26 ` Rafael J. Wysocki
2019-08-02 22:36 ` Bjorn Helgaas
2019-07-31 22:20 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4787259.M8qLqd86a7@kreacher \
--to=rjw@rjwysocki.net \
--cc=anthony.wong@canonical.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).