From: Lukasz Luba <l.luba@partner.samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-clk@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
kgene@kernel.org, "Chanwoo Choi" <cw00.choi@samsung.com>,
kyungmin.park@samsung.com,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
s.nawrocki@samsung.com, myungjoo.ham@samsung.com,
keescook@chromium.org, tony@atomide.com, jroedel@suse.de,
treding@nvidia.com, digetx@gmail.com, gregkh@linuxfoundation.org,
willy.mh.wolff.ml@gmail.com
Subject: Re: [PATCH v9 08/13] drivers: memory: add DMC driver for Exynos5422
Date: Fri, 14 Jun 2019 10:50:18 +0200 [thread overview]
Message-ID: <4a88b188-eee9-2a16-82cf-ead94a3c24da@partner.samsung.com> (raw)
In-Reply-To: <CAJKOXPdKGG25T46d+SmES7wyQ=kAMj2jdT3GCYa+z87wpYKNEQ@mail.gmail.com>
Hi Krzysztof,
On 6/11/19 8:18 AM, Krzysztof Kozlowski wrote:
> On Fri, 7 Jun 2019 at 16:35, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>
>> This patch adds driver for Exynos5422 Dynamic Memory Controller.
>> The driver provides support for dynamic frequency and voltage scaling for
>> DMC and DRAM. It supports changing timings of DRAM running with different
>> frequency. There is also an algorithm to calculate timigns based on
>> memory description provided in DT.
>> The patch also contains needed MAINTAINERS file update.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>> MAINTAINERS | 8 +
>> drivers/memory/samsung/Kconfig | 17 +
>> drivers/memory/samsung/Makefile | 1 +
>> drivers/memory/samsung/exynos5422-dmc.c | 1261 +++++++++++++++++++++++
>> 4 files changed, 1287 insertions(+)
>> create mode 100644 drivers/memory/samsung/exynos5422-dmc.c
>
> (...)
>
>> +
>> +/**
>> + * exynos5_performance_counters_init() - Initializes performance DMC's counters
>> + * @dmc: DMC for which it does the setup
>> + *
>> + * Initialization of performance counters in DMC for estimating usage.
>> + * The counter's values are used for calculation of a memory bandwidth and based
>> + * on that the governor changes the frequency.
>> + * The counters are not used when the governor is GOVERNOR_USERSPACE.
>> + */
>> +static int exynos5_performance_counters_init(struct exynos5_dmc *dmc)
>> +{
>> + int counters_size;
>> + int ret, i;
>> +
>> + dmc->num_counters = devfreq_event_get_edev_count(dmc->dev);
>> + if (dmc->num_counters < 0) {
>> + dev_err(dmc->dev, "could not get devfreq-event counters\n");
>> + return dmc->num_counters;
>> + }
>> +
>> + counters_size = sizeof(struct devfreq_event_dev) * dmc->num_counters;
>> + dmc->counter = devm_kzalloc(dmc->dev, counters_size, GFP_KERNEL);
>> + if (!dmc->counter)
>> + return -ENOMEM;
>> +
>> + for (i = 0; i < dmc->num_counters; i++) {
>> + dmc->counter[i] =
>> + devfreq_event_get_edev_by_phandle(dmc->dev, i);
>> + if (IS_ERR_OR_NULL(dmc->counter[i]))
>> + return -EPROBE_DEFER;
>> + }
>> +
>> + ret = exynos5_counters_enable_edev(dmc);
>> + if (ret < 0) {
>> + dev_err(dmc->dev, "could not enable event counter\n");
>> + return ret;
>> + }
>> +
>> + ret = exynos5_counters_set_event(dmc);
>> + if (ret < 0) {
>> + dev_err(dmc->dev, "counld not set event counter\n");
>
> Missing cleanup - edev counters disable.
right
>
>> + return ret;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +/**
>> + * exynos5_dmc_set_pause_on_switching() - Controls a pause feature in DMC
>> + * @dmc: device which is used for changing this feature
>> + * @set: a boolean state passing enable/disable request
>> + *
>> + * There is a need of pausing DREX DMC when divider or MUX in clock tree
>> + * changes its configuration. In such situation access to the memory is blocked
>> + * in DMC automatically. This feature is used when clock frequency change
>> + * request appears and touches clock tree.
>> + */
>> +static inline int exynos5_dmc_set_pause_on_switching(struct exynos5_dmc *dmc)
>> +{
>> + unsigned int val;
>> + int ret;
>> +
>> + ret = regmap_read(dmc->clk_regmap, CDREX_PAUSE, &val);
>> + if (ret)
>> + return ret;
>> +
>> + val |= 1UL;
>> + regmap_write(dmc->clk_regmap, CDREX_PAUSE, val);
>> +
>> + return 0;
>> +}
>> +
>> +/**
>> + * exynos5_dmc_probe() - Probe function for the DMC driver
>> + * @pdev: platform device for which the driver is going to be initialized
>> + *
>> + * Initialize basic components: clocks, regulators, performance counters, etc.
>> + * Read out product version and based on the information setup
>> + * internal structures for the controller (frequency and voltage) and for DRAM
>> + * memory parameters: timings for each operating frequency.
>> + * Register new devfreq device for controlling DVFS of the DMC.
>> + */
>> +static int exynos5_dmc_probe(struct platform_device *pdev)
>> +{
>> + int ret = 0;
>> + struct device *dev = &pdev->dev;
>> + struct device_node *np = dev->of_node;
>> + struct exynos5_dmc *dmc;
>> + struct resource *res;
>> +
>> + dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);
>> + if (!dmc)
>> + return -ENOMEM;
>> +
>> + mutex_init(&dmc->lock);
>> +
>> + dmc->dev = dev;
>> + platform_set_drvdata(pdev, dmc);
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + dmc->base_drexi0 = devm_ioremap_resource(dev, res);
>> + if (IS_ERR(dmc->base_drexi0))
>> + return PTR_ERR(dmc->base_drexi0);
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> + dmc->base_drexi1 = devm_ioremap_resource(dev, res);
>> + if (IS_ERR(dmc->base_drexi1))
>> + return PTR_ERR(dmc->base_drexi1);
>> +
>> + dmc->clk_regmap = syscon_regmap_lookup_by_phandle(np,
>> + "samsung,syscon-clk");
>> + if (IS_ERR(dmc->clk_regmap))
>> + return PTR_ERR(dmc->clk_regmap);
>> +
>> + ret = exynos5_init_freq_table(dmc, &exynos5_dmc_df_profile);
>> + if (ret) {
>> + dev_warn(dev, "couldn't initialize frequency settings\n");
>> + return ret;
>> + }
>> +
>> + dmc->vdd_mif = devm_regulator_get(dev, "vdd");
>> + if (IS_ERR(dmc->vdd_mif)) {
>> + ret = PTR_ERR(dmc->vdd_mif);
>> + return ret;
>> + }
>> +
>> + ret = exynos5_dmc_init_clks(dmc);
>> + if (ret)
>> + return ret;
>> +
>> + ret = of_get_dram_timings(dmc);
>> + if (ret) {
>> + dev_warn(dev, "couldn't initialize timings settings\n");
>
> goto remove_clocks;
OK
>
>> + return ret;
>> + }
>> +
>> + ret = exynos5_performance_counters_init(dmc);
>> + if (ret) {
>> + dev_warn(dev, "couldn't probe performance counters\n");
>> + goto remove_clocks;
>> + }
>> +
>> + ret = exynos5_dmc_set_pause_on_switching(dmc);
>> + if (ret) {
>> + dev_warn(dev, "couldn't get access to PAUSE register\n");
>> + goto remove_clocks;
>
> goto err_devfreq_add;
Agree.
Thank you for the review.
Regards,
Lukasz
> Best regards,
> Krzysztof
>
>> + }
>> +
>> + /*
>> + * Setup default thresholds for the devfreq governor.
>> + * The values are chosen based on experiments.
>> + */
>> + dmc->gov_data.upthreshold = 30;
>> + dmc->gov_data.downdifferential = 5;
>> +
>> + dmc->df = devm_devfreq_add_device(dev, &exynos5_dmc_df_profile,
>> + DEVFREQ_GOV_USERSPACE,
>> + &dmc->gov_data);
>> +
>> + if (IS_ERR(dmc->df)) {
>> + ret = PTR_ERR(dmc->df);
>> + goto err_devfreq_add;
>> + }
>> +
>> + dev_info(dev, "DMC initialized\n");
>> +
>> + return 0;
>> +
>> +err_devfreq_add:
>> + exynos5_counters_disable_edev(dmc);
>> +remove_clocks:
>> + clk_disable_unprepare(dmc->mout_bpll);
>> + clk_disable_unprepare(dmc->fout_bpll);
>> +
>> + return ret;
>> +}
>> +
>>
>
>
next prev parent reply other threads:[~2019-06-14 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190607143523eucas1p1015a614a64ed22f4c65ace8b795dd6d0@eucas1p1.samsung.com>
2019-06-07 14:34 ` [PATCH v9 00/13] Exynos5 Dynamic Memory Controller driver Lukasz Luba
[not found] ` <CGME20190607143524eucas1p22e6310f1a5f6e4bab771ebbbcc40f88c@eucas1p2.samsung.com>
2019-06-07 14:34 ` [PATCH v9 01/13] clk: samsung: add needed IDs for DMC clocks in Exynos5420 Lukasz Luba
[not found] ` <CGME20190607143525eucas1p15a57ab0f8b9e6ce2e77702f04ebf0c22@eucas1p1.samsung.com>
2019-06-07 14:34 ` [PATCH v9 02/13] clk: samsung: add new clocks for DMC for Exynos5422 SoC Lukasz Luba
[not found] ` <CGME20190607143526eucas1p1b11e7a7bf57b80de893b5b5664d3fa09@eucas1p1.samsung.com>
2019-06-07 14:34 ` [PATCH v9 03/13] clk: samsung: add BPLL rate table for Exynos 5422 SoC Lukasz Luba
[not found] ` <CGME20190607143527eucas1p2afb1f2b11a16d61ad802f1a0c53cf880@eucas1p2.samsung.com>
2019-06-07 14:34 ` [PATCH v9 04/13] dt-bindings: ddr: rename lpddr2 directory Lukasz Luba
[not found] ` <CGME20190607143528eucas1p12875b8f2043264a452da2720195f629e@eucas1p1.samsung.com>
2019-06-07 14:34 ` [PATCH v9 05/13] dt-bindings: ddr: add LPDDR3 memories Lukasz Luba
[not found] ` <CGME20190607143529eucas1p2ed19649f0a5404a9a2a3b45cb07d0103@eucas1p2.samsung.com>
2019-06-07 14:35 ` [PATCH v9 06/13] drivers: memory: extend of_memory by LPDDR3 support Lukasz Luba
[not found] ` <CGME20190607143530eucas1p15c794d0f1401fc3a48f1408c3435084a@eucas1p1.samsung.com>
2019-06-07 14:35 ` [PATCH v9 07/13] dt-bindings: memory-controllers: add Exynos5422 DMC device description Lukasz Luba
2019-06-11 22:43 ` Rob Herring
2019-06-14 8:52 ` Lukasz Luba
[not found] ` <CGME20190607143531eucas1p11f6b3a63068d529dae8be16abaa60ed0@eucas1p1.samsung.com>
2019-06-07 14:35 ` [PATCH v9 08/13] drivers: memory: add DMC driver for Exynos5422 Lukasz Luba
2019-06-11 6:18 ` Krzysztof Kozlowski
2019-06-14 8:50 ` Lukasz Luba [this message]
[not found] ` <CGME20190607143532eucas1p275590080c3b1ce9e2ce90f5b5da9be60@eucas1p2.samsung.com>
2019-06-07 14:35 ` [PATCH v9 09/13] drivers: devfreq: events: add Exynos PPMU new events Lukasz Luba
[not found] ` <CGME20190607143533eucas1p15b29a74650422ff1eb1fec4307333e8d@eucas1p1.samsung.com>
2019-06-07 14:35 ` [PATCH v9 10/13] ARM: dts: exynos: add chipid label and syscon compatible Lukasz Luba
[not found] ` <CGME20190607143534eucas1p24e5bf121447c6e9a7ef546cf15f3d6fa@eucas1p2.samsung.com>
2019-06-07 14:35 ` [PATCH v9 11/13] ARM: dts: exynos: add syscon to clock compatible Lukasz Luba
[not found] ` <CGME20190607143535eucas1p2e1c3843aca8dd39a615f4ce26e845ed8@eucas1p2.samsung.com>
2019-06-07 14:35 ` [PATCH v9 12/13] ARM: dts: exynos: add DMC device for exynos5422 Lukasz Luba
[not found] ` <CGME20190607143536eucas1p2192a9061b835502ada88262ef427ce8a@eucas1p2.samsung.com>
2019-06-07 14:35 ` [PATCH v9 13/13] ARM: exynos_defconfig: enable DMC driver Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a88b188-eee9-2a16-82cf-ead94a3c24da@partner.samsung.com \
--to=l.luba@partner.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=treding@nvidia.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).