From: "H. Peter Anvin" <hpa@zytor.com>
To: "Christian Sünkenberg" <christian.suenkenberg@student.kit.edu>
Cc: Jonas Heinrich <onny@project-insanity.org>,
"len.brown@intel.com" <len.brown@intel.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>, "rjw@sisk.pl" <rjw@sisk.pl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [Bisected] 3.7-rc1 can't resume (still present in 3.9)
Date: Fri, 12 Jul 2013 16:45:52 -0700 [thread overview]
Message-ID: <51E09530.8030300@zytor.com> (raw)
In-Reply-To: <51E092FC.1030200@student.kit.edu>
On 07/12/2013 04:36 PM, Christian Sünkenberg wrote:
>
> Jonas tried your patch and it fixes suspend/resume on his T43, although
> IMHO the safest approach would be to just add an exception for
> Vendor==Intel && Family==6 && Model==13, or more generally Vendor==Intel
> && !supports_long_mode, as the same erratum also warns about wrmsr
> possibly not triggering a GP either.
> Anyways, at least on this specific MSR with the Pentium M Jonas tested,
> it behaved correctly on every try, so I'd say your patch does the trick,
> thank you very much!
>
Using vendor matches is not really a great way to deal with things that
can better be handled analytically.
If WRMSR doesn't fault, it is not a problem...
> As a side note, I found a similar erratum #33 in "Pentium® Processor
> Specification Update" for Intel P54C (Family 5, Model 2), which would,
> supposed there are P54C systems with ACPI sleep/resume support, result
> in MSR 0 (P5_MC_ADDR) to be saved and restored instead of nonexistent EFER.
Doesn't really matter, as we'd only read that one after an #MC.
-hpa
prev parent reply other threads:[~2013-07-12 23:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 15:54 [Bisected] 3.7-rc1 can't resume Jonas Heinrich
2013-02-18 16:21 ` H. Peter Anvin
2013-02-23 13:18 ` Jonas Heinrich
2013-02-23 21:54 ` H. Peter Anvin
[not found] ` <20130320143257.GA473@onny>
2013-05-01 17:01 ` [Bisected] 3.7-rc1 can't resume (still present in 3.9) Jonas Heinrich
2013-05-01 17:33 ` H. Peter Anvin
2013-05-01 18:51 ` Jonas Heinrich
2013-05-01 18:55 ` H. Peter Anvin
2013-05-02 0:45 ` Rafael J. Wysocki
2013-05-02 20:32 ` Jonas Heinrich
2013-05-02 23:29 ` Rafael J. Wysocki
2013-05-03 11:07 ` Jonas Heinrich
2013-05-03 11:37 ` Rafael J. Wysocki
2013-05-28 21:36 ` Rafael J. Wysocki
2013-05-03 12:15 ` Jarkko Sakkinen
2013-07-08 9:50 ` Jonas Heinrich
2013-07-08 13:05 ` Rafael J. Wysocki
2013-07-15 21:11 ` H. Peter Anvin
2013-07-10 20:52 ` Christian Sünkenberg
2013-07-10 23:57 ` H. Peter Anvin
2013-07-12 23:36 ` Christian Sünkenberg
2013-07-12 23:45 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E09530.8030300@zytor.com \
--to=hpa@zytor.com \
--cc=christian.suenkenberg@student.kit.edu \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=onny@project-insanity.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).