linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: linux-pm@vger.kernel.org, edubezval@gmail.com
Cc: linaro-kernel@lists.linaro.org, rui.zhang@intel.com,
	amit.daniel@samsung.com, javi.merino@arm.com,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 22/26] thermal: cpu_cooling: use cpufreq_dev_list instead of cpufreq_dev_count
Date: Thu,  4 Dec 2014 09:42:04 +0530	[thread overview]
Message-ID: <564b1bad6f91e237eee3eed823f45f3f32be1b48.1417664938.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1417664938.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1417664938.git.viresh.kumar@linaro.org>

As we already have a list of cpufreq_cooling_devices now, lets use it instead of
a local counter.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/thermal/cpu_cooling.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index d2e6f84..32ff6dc 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -71,8 +71,6 @@ struct cpufreq_cooling_device {
 static DEFINE_IDR(cpufreq_idr);
 static DEFINE_MUTEX(cooling_cpufreq_lock);
 
-static unsigned int cpufreq_dev_count;
-
 static LIST_HEAD(cpufreq_dev_list);
 
 /**
@@ -419,10 +417,9 @@ __cpufreq_cooling_register(struct device_node *np,
 	mutex_lock(&cooling_cpufreq_lock);
 
 	/* Register the notifier for first cpufreq cooling device */
-	if (cpufreq_dev_count == 0)
+	if (list_empty(&cpufreq_dev_list))
 		cpufreq_register_notifier(&thermal_cpufreq_notifier_block,
 					  CPUFREQ_POLICY_NOTIFIER);
-	cpufreq_dev_count++;
 	list_add(&cpufreq_dev->node, &cpufreq_dev_list);
 
 	mutex_unlock(&cooling_cpufreq_lock);
@@ -495,10 +492,9 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)
 	cpufreq_dev = cdev->devdata;
 	mutex_lock(&cooling_cpufreq_lock);
 	list_del(&cpufreq_dev->node);
-	cpufreq_dev_count--;
 
 	/* Unregister the notifier for the last cpufreq cooling device */
-	if (cpufreq_dev_count == 0)
+	if (list_empty(&cpufreq_dev_list))
 		cpufreq_unregister_notifier(&thermal_cpufreq_notifier_block,
 					    CPUFREQ_POLICY_NOTIFIER);
 	mutex_unlock(&cooling_cpufreq_lock);
-- 
2.0.3.693.g996b0fd


  parent reply	other threads:[~2014-12-04  4:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  4:11 [PATCH V2 00/26] thermal: cpu_cooling: Fixes and cleanups Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 01/26] thermal: cpu_cooling: check for the readiness of cpufreq layer Viresh Kumar
2014-12-04 14:08   ` Eduardo Valentin
2014-12-04  4:11 ` [PATCH V2 02/26] thermal: db8500: pass cpu_present_mask to cpufreq_cooling_register() Viresh Kumar
2014-12-31  8:11   ` Linus Walleij
2014-12-04  4:11 ` [PATCH V2 03/26] thermal: imx: " Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 04/26] thermal: exynos: " Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 05/26] thermal: cpu_cooling: random comment fixups Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 06/26] thermal: cpu_cooling: fix doc comment over struct cpufreq_cooling_device Viresh Kumar
2014-12-04 10:32   ` Javi Merino
2014-12-04 10:36     ` Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 07/26] thermal: cpu_cooling: Add comment to clarify relation between cooling state and frequency Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 08/26] thermal: cpu_cooling: Pass variable instead of its type to sizeof() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 09/26] thermal: cpu_cooling: no need to set cpufreq_state to zero Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 10/26] thermal: cpu_cooling: no need to set cpufreq_dev to NULL Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 11/26] thermal: cpu_cooling: no need to initialze 'ret' Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 12/26] thermal: cpu_cooling: propagate error returned by idr_alloc() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 13/26] thermal: cpu_cooling: Don't match min/max frequencies for all CPUs on cooling register Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 14/26] thermal: cpu_cooling: don't iterate over all allowed_cpus to update cpufreq policy Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 15/26] thermal: cpu_cooling: Don't check is_cpufreq_valid() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 16/26] thermal: cpu_cooling: do error handling at the bottom in __cpufreq_cooling_register() Viresh Kumar
2014-12-04  4:11 ` [PATCH V2 17/26] thermal: cpu_cooling: initialize 'cpufreq_val' on registration Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 18/26] thermal: cpu_cooling: Merge cpufreq_apply_cooling() into cpufreq_set_cur_state() Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 19/26] thermal: cpu_cooling: remove unnecessary wrapper get_cpu_frequency() Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 20/26] thermal: cpu_cooling: find max level during device registration Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 21/26] thermal: cpu_cooling: get_property() doesn't need to support GET_MAXL anymore Viresh Kumar
2014-12-04  4:12 ` Viresh Kumar [this message]
2014-12-04  4:12 ` [PATCH V2 23/26] thermal: cpu_cooling: Pass 'cpufreq_dev' to get_property() Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 24/26] thermal: cpu_cooling: Store frequencies in descending order Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 25/26] thermal: cpu_cooling: Use cpufreq_dev->freq_table for finding level/freq Viresh Kumar
2014-12-04 10:52   ` Javi Merino
2014-12-04 10:56     ` Viresh Kumar
2014-12-04  4:12 ` [PATCH V2 26/26] thermal: cpu_cooling: update copyright tags Viresh Kumar
2014-12-08 20:01 ` [PATCH V2 00/26] thermal: cpu_cooling: Fixes and cleanups Eduardo Valentin
2014-12-09  1:47   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564b1bad6f91e237eee3eed823f45f3f32be1b48.1417664938.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=amit.daniel@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=javi.merino@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).