From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators
Date: Mon, 29 Jul 2019 14:34:35 +0200 [thread overview]
Message-ID: <5D3EE7DB.9070706@bfs.de> (raw)
In-Reply-To: <20190729120323.15838-1-colin.king@canonical.com>
Am 29.07.2019 14:03, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable val is having the top 8 bits cleared and then the variable is being
> re-assinged and setting just the top 8 bits. I believe the intention was bitwise-or
> in the top 8 bits. Fix this by replacing the = operators with &= and |= instead.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b0c74b08517e ("drivers: thermal: processor_thermal_device: Export sysfs inteface for TCC offset")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: Add in &= operator missing from V1. Doh.
>
> ---
> .../thermal/intel/int340x_thermal/processor_thermal_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> index 6f6ac6a8e82d..97333fc4be42 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> @@ -163,8 +163,8 @@ static int tcc_offset_update(int tcc)
> if (err)
> return err;
>
> - val = ~GENMASK_ULL(31, 24);
> - val = (tcc & 0xff) << 24;
> + val &= ~GENMASK_ULL(31, 24);
> + val |= (tcc & 0xff) << 24;
>
IMHO GENMASK_ULL(31, 24) is a complicated way to say 0xFF000000
In this special case it would be better to use that (or 0xff<<24).
just my 2 cents,
re,
wh
> err = wrmsrl_safe(MSR_IA32_TEMPERATURE_TARGET, val);
> if (err)
next prev parent reply other threads:[~2019-07-29 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:03 [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators Colin King
2019-07-29 12:34 ` walter harms [this message]
2019-07-29 21:09 ` Srinivas Pandruvada
2019-08-19 6:32 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D3EE7DB.9070706@bfs.de \
--to=wharms@bfs.de \
--cc=colin.king@canonical.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).